00:29 < zoq> FawwazMaydaGitte: just commented on the proposal.

02:06 < rcurtin[m]1> shrit: I think I've centered in on a bug in the cover tree recursion... not exactly certain of what the fix is yet, but I think I have the cause of the infinite recursion pinpointed

02:06 < rcurtin[m]1> of course, there could be many issues :) but at least I am getting somewhere, more quickly than I expected too

02:27 < AnushKiniGitter[> Hi @rcurtin , @zoq . I had submitted a draft proposal a few days ago on the GSoC website. Would love to hear your comments on the same.

02:29 < zoq> AnushKiniGitter[: I thought I already reviewed that one, I'll take a look in the next minutes.

03:21 < RishabhGargGitte> Hii, I also haven't received any comments on my draft proposal other than from @jeffin143. Is it yet to be reviewed? Thanks!

03:23 < AnushKiniGitter[> @zoq Thanks, just got your comments. Will work on reflecting the same in the proposal.

06:52 < gitter_vstark21[> Hello everyone, I have submitted a draft proposal for GSOC 21. Looking forward to hearing your feedback.

11:44 < Roshan[m]> Ryan Curtin @shrit Below is my proposal for GSoC. Please give some feedback to it:

11:44 < Roshan[m]> <https://docs.google.com/document/d/1NTGHIbw5V2Sv_N8kW6dlBFfvRqV3ems_hwn_unvPW6I/edit?usp=drivesdk|https://docs.google.com/document/d/1NTGHIbw5V2Sv_N8kW6dlBFfvRqV3ems_hwn_unvPW6I/edit?usp=drivesdk>

11:44 < Roshan[m]> Thanks

13:18 < rcurtin[m]1> I agree, that seems like it would be the right approach here 👍

13:18 < RishabhGargGitte> Also I have opened a PR on it so I would like to know would you prefer having these long discussion there or it is fine here on the IRC?

13:19 < rcurtin[m]1> either is fine, maybe on the PR is better :)

13:19 < OleksandrNikolsk> hi ryan, can I use a visitor from ann/visitors to update the parameters of a model?

13:19 < OleksandrNikolsk> In my case I want to update parameters of a multilayer neural network, while they are stored in a N-dim vector.

13:19 < OleksandrNikolsk> Assuming that an optimizer from ensmallen is able to optimize a network, it should be possible right?

13:20 < RishabhGargGitte> > `rcurtin (@ryan:ratml.org)` either is fine, maybe on the PR is better :)

13:20 < RishabhGargGitte> Yeah, I too was thinking the same. It is easir to keep track of thoughts there. Then I will continue our discussion there :-)

13:31 < OleksandrNikolsk> (edited) hi ryan, can ... => hi, can ...

13:33 < rcurtin[m]1> Oleksandr Nikolskyy that seems like it would work; also, you could just access the parameters matrix directly from the FFN class I suppose

13:34 < zoq> OleksandrNikolsk: Yes, you can use a visitor to get the network parameters and update them as well.

14:20 < OleksandrNikolsk> cool. Does it copy them?

14:25 < rcurtin[m]1> in that case, that would be copied---use a move constructor? `x.Weight() = std::move(w);`

14:26 < rcurtin[m]1> however, on second thought, it may not be a good idea to do that

14:27 < rcurtin[m]1> the reason is that the FFN and RNN classes lay out the memory for each layer very explicitly, so, if inside of a network, `x.Weight()` will correspond to a very specific memory region

14:27 < rcurtin[m]1> in this case, it would be best to work directly on `x.Weight()` instead of copying another armadillo object into it, if possible

14:37 < OleksandrNikolsk> hm, did not get the last part.

14:37 < OleksandrNikolsk> explicitly in terms of

14:38 < OleksandrNikolsk> hm, did not get the last part.

14:38 < OleksandrNikolsk> so I don't get around copying?

14:43 < NippunSharmaGitt> Hey @rcurtin can you take a look at the draft proposal I submitted and provide some feedback. There are some things that I have pointed out in the proposal that may cause some issues while refactoring, such as a when multiple functions of name mlpackMain (one from "fit_main.cpp" and other from "predict_main.cpp") are wrapped in the same cython file then that would cause redefinition error. I am not able to think what

14:43 < NippunSharmaGitt> the best solution for this can be, we can have different functions for fit and predict that is for fit, we can have mlpackMainFit, and for predict we can have mlpackMainPredict. For this we would have to make some changes to mlpack_main.hpp file. What do you think about this? Any particular solution that you have in mind?

15:28 < zoq> OleksandrNikolsk: You can start with a copy, it's just not as fast as it could be, once you have something that works, we can improve it.

15:40 < zoq> Roshan[m]: Just left some comments on the proposal.

15:41 < zoq> Roshan[m]: Nevermind, that was another one, I'll take a look at yours next.

15:41 < zoq> Btw. did you upload the proposal to the GSoC dashboard?

15:42 < Roshan[m]> No...I was waiting for the feedbacks and then after changes, I thought I will upload

15:42 < zoq> Roshan[m]: You can upload drafts to the dashboard as well.

15:43 < zoq> Roshan[m]: Makes it easier for us to track who asked for feedback.

15:44 < AnmolpreetSinghG> Hi @zoq can you have a look at draft proposal submitted by me a couple of days ago on Adding Image Quality metrics. Hope to get feedback :)

15:45 < Roshan[m]> <zoq "swaingotnochill: You can upload "> By dashboard, does it means the GSoC official dashboard? I didn't do because I thought there are limited times one can upload a proposal

15:46 < zoq> Roshan[m]: There is no limit, it's the same as posting a link to the google doc here.

15:46 < zoq> AnmolpreetSinghG: I'll take a look in a moment.

15:55 < zoq> Roshan[m]: Alright, left some high level comments, thanks for putting this together!

16:03 < zoq> AnmolpreetSinghG: Comment on the proposal as well, hope anything I said is helpful.

16:13 < Roshan[m]> <zoq "swaingotnochill: Alright, left s"> zoq Thanks, that was valuable. If you have a couple of minutes, I have responded to your comments as I have some doubts about some. It will be really helpful if you could help me clear some of them.

16:15 < zoq> Roshan[m]: Yep I have some minutes.

16:23 < zoq> Roshan[m]: Done.

16:23 < Roshan[m]> Thanks zoq

16:40 < NippunSharmaGitt> @zoq can you please provide some feedback on my draft proposal too, it would be great to have some reviews to know if there are any major additions that I need to do before the deadline.

17:05 < rcurtin[m]1> Nippun Sharma (Gitter): I'll try to take a look, sorry I have not gotten to it yet

17:05 < rcurtin[m]1> note that the reason there is no problem that every function is currently called `mlpackMain()` in the Python bindings is that they are all each individually compiled in their own translation unit, so you don't get multiple definition errors

17:06 < rcurtin[m]1> so, e.g., you get `preprocess_split.so`, which contains an `mlpackMain()` function, but you also get `adaboost.so`, which contains a different `mlpackMain()` function

17:06 < rcurtin[m]1> then from Cython we use each generated .so individually

17:06 < rcurtin[m]1> so, we could preserve `mlpackMain()` by simply splitting a `train` and `predict` binding into completely separate `.so`s just like that

17:32 < NippunSharmaGitt> Okay, so you are suggesting that we should keep everything as is with respect to mlpackMain and generate seperate .so's and then call these .so's from a wrapper class's methods (fit, predict, etc.) ?

17:34 < NippunSharmaGitt> I can see how that can solve this issue, we would have completely different pipelines for each and then we just add a wrapper at the end

17:34 < NippunSharmaGitt> did i get it right?

17:38 < NippunSharmaGitt> [here](https://pastebin.com/Nt90y1yU) I have split the random forest bindings and generated each .so separately (named as random_forest_fit, random_forest_predict), and then created a RandomForestPy class to wrap these.. is this what you had in mind?

17:51 < jonpsy[m]> zoq Hey, sorry for the delay. College assignments came up so I couldn't address the comments, but i am making progress. Can i request one last review when I've fixed it? I'll ping you :D

17:51 < jonpsy[m]> Also, styled the NSGA2 PR.

17:51 < jonpsy[m]> traits PR is giving me a little trouble (nothing I can't fix) but I'll ping you in the PR when it's done.

18:02 < zoq> jonpsy[m]: no worries

18:44 < OleksandrNikolsk> zoq thx

19:29 < rcurtin[m]1> Nippun Sharma (Gitter): yeah, that seems reasonable, but ideally we wouldn't write the RandomForestPy class by hand---we would manage to auto-generate it too 😃

19:57 < NippunSharmaGitt> Yes I understand, this is just for demonstrating, we would have to write a function like PrintPYX() which prints this code... I was thinking to include this code into my proposal just as a proof of concept...will that be okay? I can also try to write a wrapper for Random Forest in other languages just for demonstrating... will that be a good idea?

19:59 < rcurtin[m]1> yeah, of course, that is just fine as a proof of concept :) it's probably a good idea for your proposal, though, to think through how you might automatically generate that class that holds both the bindings 👍️

20:02 < NippunSharmaGitt> Yes, I will spend some time to think about it and write my ideas in the proposal. Thanks for clearing up these doubts😀.

20:24 < rcurtin[m]1> 👍️

20:29 < jonpsy[m]> <zoq "jonpsy: no worries"> Thanks! Fixed both of them. Review them whenever :). I was thinking we should port @favre49s indicator code. This will help me in my test_function_tools.hpp PR.

20:49 < NippunSharmaGitt> @rcurtin I have added a wrapper for Random Forest in Julia similar to what I had shown for Python, I have added it in my proposal, you can take a look there. Hopefully I did it right, as it was working on my local system.

20:52 < OleksandrNikolsk> Hi, I see no tanh in the ann layers, would you mind if I add it and make a PR?

20:53 < zoq> OleksandrNikolsk: It's implemented as an activation function and uses the base layer.

20:58 < OleksandrNikolsk> okay, I see.

20:58 < OleksandrNikolsk> how can I connect an activation function to a linear layer?

21:01 < zoq> Either add BaseLayer<TanhFunction> after the Linear layer, or you can use TanHLayer instead which is an alias.

21:01 < zoq> https://github.com/mlpack/mlpack/blob/master/src/mlpack/methods/ann/layer/base_layer.hpp#L182