<leviathan>
Hey guys, I've recently been diving into the implementation of InputMethodPopup. As a complete newbie, this includes getting to grips with Wayland, wlroots, and Zig, so I've been referencing the implementations in projects like Hyprland and Sway. I noticed that Hyprland seems to have customized a lot of event listeners, while River appears to only
leviathan has quit [Client Quit]
leviathan has joined #river
<ifreund>
leviathan: I think your message got cut off, for me it stops after "while river appears to only" (IRC has a character limit per message)
<ifreund>
anyhow, I'd strongly recommend not looking at hyperland's code as a reference, all the hyperland code I've seen has been quite poor quality
<ifreund>
reading sway's code is generally fine to help understand the problem space but an implementation in river should neven just be a straight port of code from some other compositor
<ifreund>
if you have questions about wayland/zig/river's codebase feel free to ask them here
leviathan has quit [Quit: Client closed]
traidare has quit [Ping timeout: 272 seconds]
traidare has joined #river
leopoldek has joined #river
<ifreund>
well I touched the transaction system again since I found a possible assertion failure
<ifreund>
I've ended up making interactive resize of mpv behave even nicer I think
<ifreund>
always a bit nervous of causing regressions when I touch this code though
<ifreund>
you know, interactive resize of mpv is one thing river handles a lot better than sway. I'm kinda proud of that
Guest1667 has joined #river
Guest1667 has quit [Client Quit]
<larstiq_>
ifreund: cool!
pkap has joined #river
itshog has joined #river
traidare has quit [Ping timeout: 252 seconds]
<itshog>
Hi! I just wanted to thank ifreund for adding tablet support to river, much appreciated!
<ifreund>
itshog: no problem! Is it working well for you? I'm not a heavy tablet user myself and am not sure how annoying e.g. lack of pointer emulation is in practice
<itshog>
I have only a little annoyance
<itshog>
But maybe it's intended behaviour
<ifreund>
you mean the lack of pointer emulation? I wouldn't say it's intended behavior long-term, more a limitation of the current implementation
<pkap>
I am encountering a weird rendering thing. When I have Firefox and foot views next to each other and opening certain websites, slight horizontal lines are rendered in the foot view. next to the website.
<itshog>
ifreund: When using Xournal++ and trying to select an item from one of the dropdown menus (like the one for selecting eraser or pen type) with the pen the menu disappears almost instantly
<pkap>
Not problematic. It is very slightly. But I am curious if this is a bug in river, foot or is it my display?
<itshog>
It works fine with mouse and touch input, but not with the pen
<leon-p>
itshog: arguably that's a xournal++ bug for not making their menus usable with tablet input
<leon-p>
I for one really like that the tablet tool is not bound to the cursor
<leon-p>
*the primary cursor
<itshog>
ifreund: It works properly in Sway, but maybe it's becasue of the pointer emulation
<ifreund>
pkap: hmm, could you try to get a screen capture?
<leon-p>
however what I am missing is restricting the tablet to a specific area on screen. tablets really aren't made for ultra-wide screens. Clients really should be able to ask the compositor to restrict the tablet to their canvas, but I don't think that's a thing yet
<leon-p>
either way, I can finally use my tablet again for notes, thanks ifreund :]
<ifreund>
leon-p: yeah, we only have support for mapping tablets to outputs not arbitrary rectangles currently
<ifreund>
I wonder what UX GNOME has for tablet input region mapping, It would be nice to have something less manual than specifying a hardcoded rectangle of the compositor coordinate space in logical pixel coordinates
<ifreund>
itshog: If you open an issue I'll take a look eventually, I probably won't block 0.3.0 on it though
<leon-p>
I do remember reading something about clients requesting mapping the tablet just to their canvas, but I can't remember where. Also not sure how that would work with those expensive tablets that have a screen in them
<ifreund>
pkap: in any case, that kind of graphical glitch sounds like a bug somewhere lower in the graphics stack than river. Maybe a wlroots scene graph bug or maybe a driver issue triggered by firefox doing something strange
<itshog>
ifreund: Just tested, the same issue appears in LibreOffice so it's probably not a Xournal++ bug
<ifreund>
you could try running river with WLR_SCENE_DISABLE_VISIBILITY=1 set to rule out a lot of the most complex wlroots scene graph code
<ifreund>
itshog: excellent, please do open an issue telling me how to reproduce it in LibreOffice :)
<ifreund>
Though it could still be a Qt bug I suppose (I think both of those programs use Qt?)
<itshog>
They both use gtk3
<itshog>
It's kind of strange because in LibreOffice some menus work properly and some don't
<itshog>
Anyway I'll open an issue
<adamcstephens>
i accidentally touched my laptop screen last night and realized touch works well. also realized i have a touch screen on this x13s i bought used 😄
<ifreund>
that's pretty funny
<ifreund>
touch doesn't have any pointer emulation either, but gtk stuff and the like support touch input quite well
<ifreund>
anyhow, I'll probably be offline the rest of the day o7
pkap has quit [Quit: Client closed]
pkap has joined #river
<leon-p>
o7
<pkap>
ifreund: the rendering bug still occurs with with WLR_SCENE_DISABLE_VISIBILITY=1
pkap has quit [Client Quit]
pkap has joined #river
sls has joined #river
pkap has quit [Quit: Client closed]
sergei has joined #river
leopoldek has quit [Ping timeout: 255 seconds]
sergei has quit [Quit: WeeChat 4.2.1]
waleee has quit [Quit: WeeChat 4.1.2]
itshog has quit [Quit: WeeChat 4.2.1]
leopoldek has joined #river
sls has quit [Ping timeout: 250 seconds]
traidare has joined #river
sergei has joined #river
waleee has joined #river
leopoldek has quit [Read error: Connection reset by peer]
leopoldek has joined #river
traidare has quit [Ping timeout: 268 seconds]
traidare has joined #river
traidare has quit [Ping timeout: 252 seconds]
sugarbeet has quit [Ping timeout: 256 seconds]
sugarbeet has joined #river
lbia has quit [Ping timeout: 260 seconds]
lbia has joined #river
lbia has quit [Ping timeout: 268 seconds]
lbia has joined #river
Szadek369 has joined #river
Szadek36 has quit [Ping timeout: 252 seconds]
Szadek369 is now known as Szadek36
angry_vincent has quit [Ping timeout: 255 seconds]