<larry53>
Launching bemenu-run from the terminal emulator works just fine,while respecting the environment variables but launching using riverctl keybindings everything just reverts back to default.
<larry53>
How can I fix this issue?
<larry53>
Thank you for your time
<ifreund>
larry53: set the environment variables before launching river
larry53 has quit [Quit: Client closed]
larry53 has joined #river
<larry53>
Hi ifreund, thank you. That solved my issue.
larry53 has quit [Client Quit]
larry53 has joined #river
traidare has quit [Ping timeout: 260 seconds]
larry53 has quit [Quit: Client closed]
traidare has joined #river
lordmzte has joined #river
<lordmzte>
ifreund: regarding your comment on my PR: the difference between `MapToOutput.output_name` being null and `map-to-output` being null is that, in the former case, the input device is explicitly mapped to null whereas in the latter case, nothing will be done at all. If we were to eliminate the former case as you suggested, we'd have to add more special-casing here if a mapped input device should be
<lordmzte>
unmapped from an output, either by the user setting it to `disabled` or the output being removed.
<ifreund>
lordmzte: what's the differenc between an input device being mapped to NULL and an input device never having been mapped to anything?
<ifreund>
I'm pretty sure there is none
<ifreund>
I see no problem with mapping all input devices to NULL by default if it makes the code cleaner
<lordmzte>
Yes, but we must explicitly map an input device to null in the two cases I mentioned. If the user sets the setting to disabled or the output is disconnected, we need to call wlr_cursor_map_input_to_output(..., null). Currently, only settings that are non-null in InputConfig have their apply run.
<lordmzte>
I can add a special case here if you'd like to always call apply, if you'd prefer.
<ifreund>
lordmzte: then make InputConfig.@"map-to-output" non nullable?
<lordmzte>
Ah I see, I didn't even think about that as all the other settings were nullable :D Will do!
<ifreund>
As I've said, InputConfig needs a refactor to separate out the libinput config options
<ifreund>
all the other settings have different semantics since the default are determined by libinput version/hardware quirks/whatever, not by river
<lordmzte>
yup, but that should be left to another PR.
<ifreund>
yeah, just explaining why this new option is different :)
amuse has joined #river
<amuse>
@NickH I was using the default from from the github
<ifreund>
to be pedantic, there is no default init file, only an example
<amuse>
oh yeah the example file haha
<ifreund>
also note that the example from river's master branch may not match the river version you have installed from your distro package manager
<amuse>
i can *try* reproducing again
<amuse>
yeah, i believe i installed the 0.2.x init example file
<amuse>
but I don't think that matters, as i copied the init file from /usr/share/river/example/init like the archwiki said
<ifreund>
yeah, then that's the version installed by your package mananger
<amuse>
hm
<ifreund>
there might be something in the river logs related to your issue, you could try redirecting river's stderr to a file and reading that
<amuse>
I believe I tried that, there was no unusual errors that popped up
<ifreund>
do you have any funky keyboard layout stuff going on?
<amuse>
nope. I know it's not the keyboard cause only the exit river keybind worked
<amuse>
nothing else
<amuse>
i made sure the MOD key was correct, foot was correctly installed
<ifreund>
you could try starting river, switching to a different tty, and running `WAYLAND_DISPLAY=wayland-1 foot` or whatever
<ifreund>
and then run riverctl commands from that foot instance directly
<ifreund>
I must admit this doesn't really sound like a river bug but rather a configuration error though
<lordmzte>
What is your expert opinion on this code I came up with to handle both optional and non-optional fields in InputConfig? https://paste.rs/lSAIi
<adamcstephens>
I think I may have been premature in my celebration of frames being fixed. electron apps are still confused.
<amuse>
would it be related to the way i installed arch? i didn't fully manually install, I just used "archinstall" and clicked the "minimal installation" option
<amuse>
that would really be a long shot
<amuse>
but I will try again soon! thanks for your help
<ifreund>
adamcstephens: if you don't mind, opening a new issue with a WAYLAND_DEBUG=1 log of the program with visible window border glitches would be great
<ifreund>
lordmzte: maybe just special case the one field that's not optional?
<lordmzte>
well honestly that would boil down to even more code here :P
<ifreund>
or just do whatever works, codereview really belongs on github
<lordmzte>
yes sorry :)
<lordmzte>
On a separate note, I've also been getting some weirdness with window borders, but it's been to random for me to turn it into an issue.
<ifreund>
Theoretically it should only happen with buggy clients now
<lordmzte>
Happens with a client i wrote so probably yes xD
<ifreund>
in any case, a new issue with a WAYLAND_DEBUG=1 log of the client for me to look at would be helpful
<ifreund>
we could be more accomodating to buggy clients here and just log shame messages and fix their mistake
<ifreund>
such clients will never be frame perfect though and that's their fault
<lordmzte>
My client only creates a window for clipboard access and then immediately destroys it again
traidare has quit [Ping timeout: 256 seconds]
<lordmzte>
(I realize there was some protocol for getting clipboard access without a window, but that's not yet implemented.)
midgard has quit [Ping timeout: 255 seconds]
midgard has joined #river
<lordmzte>
Alright, we should be ready for the next round of review.
amuse has quit [Ping timeout: 250 seconds]
<lordmzte>
I see we're 3 issues away from reaching #1000!
leopoldek has joined #river
<lordmzte>
4*
traidare has joined #river
waleee has joined #river
notzmv has quit [Ping timeout: 256 seconds]
amuse has joined #river
amuse has quit [Remote host closed the connection]
<The_Buhs>
Why does `riverctl map normal Alt+Control Print spawn "grim -g - \"$(slurp)\" | wl-copy"` not work?
<The_Buhs>
by not work, I mean, when I make the bind it spawns the command immediately for some reason, and then when I try use it nothing happens
waleee has quit [Ping timeout: 255 seconds]
<leon-p>
The_Buhs: shell escaping fun
<The_Buhs>
😃
<leon-p>
when you call the command, your shell immediately sees the $(slurp), evaluates that, places the returned string into the rest of the command and then calls riverctl
<The_Buhs>
ah that makes sense
amuse has joined #river
<amuse>
ah, polkit seems to be an optional dependency for river on arch
<amuse>
and i forgot to install it
<amuse>
wow
<amuse>
i think my issues are mostly solved now
<amuse>
are yall using a greeter/dm for river?
<leon-p>
I use greetd, but configured it to automatically start river. I already habe a LUKS prompt, no need for a second password prompt
<lordmzte>
I have my own "greeter"
<lordmzte>
Which isn't technically a greeter, it's the login shell.
<amuse>
so you have river on autostart?
<amuse>
like once you log into tty
amuse has quit [Remote host closed the connection]
amuse has joined #river
amuse has quit [Remote host closed the connection]
amuse has joined #river
amuse has quit [Remote host closed the connection]
<leon-p>
no, I skip the TTY login. as I said, I already have a LUKS password prompt, why waste time entering another password?
notzmv has joined #river
alexherbo2 has joined #river
urosm has joined #river
urosm has quit [Ping timeout: 250 seconds]
alexherbo2 has quit [Remote host closed the connection]
lordmzte has quit [Quit: WeeChat 4.2.1]
traidare has quit [Ping timeout: 268 seconds]
Guest48 has joined #river
Guest48 has quit [Client Quit]
ninewise has quit [Ping timeout: 255 seconds]
ninewise has joined #river
b1tch-x has joined #river
b1tch-x has quit [Quit: Ping timeout (120 seconds)]
b1tch-x has joined #river
b1tch-x has quit [Ping timeout: 250 seconds]
b1tch-x has joined #river
waleee has joined #river
b1tch-x has quit [Ping timeout: 260 seconds]
b1tch-x has joined #river
b1TchX has joined #river
b1tch-x has quit [Quit: Quit]
b1TchX has quit [Remote host closed the connection]