16:12 <FractOrr> are there any docs for adding ui files to the build?  using the ExportPdfDialog as my starting point I created the ui file, added it to the CMakeLists.txt and openscad.pro files but the ui file does not seem to be added to the OpenSCAD_generated/include path.  I am sure I am missing something but I can't seem find what I am missing

17:40 <peeps[work]> othx: tell FractOrr in case you hadn't found it yet, .ui files are added here: https://github.com/openscad/openscad/blob/master/CMakeLists.txt#L1025-L1051

17:40 <othx> peeps[work]: 1 minute ago peeps[work] tell peeps[work] test

17:40 <othx> peeps[work]: I'll pass that on when FractOrr is around.

18:25 <teepee> I'm puzzled about openscad.pro being still there

18:33 <InPhase> I searched the repository for it, and found it only in doc/patchlevel-checklist.txt and scripts/docker-build.sh

18:33 <InPhase> Not sure where FractOrr would have gotten a copy of it though, except from a very old checkout.

18:34 <teepee> yep, that would be an unfortunate base for a PR

18:34 <InPhase> :)

18:34 <teepee> but as the PDF stuff is there it can't be *that* old

18:35 <InPhase> It's not like EVERY file has moved. Only almost all of them.

18:36 <teepee> indeed :)

19:53 <gbruno> [github] kjy5 opened issue #4785 (Next official release) https://github.com/openscad/openscad/issues/4785

20:03 <gbruno> [github] t-paul closed issue #4785 (Next official release) https://github.com/openscad/openscad/issues/4785

21:48 <FractOrr> Adding a new file export format and adding an options dialog to it like the PDF export has was quite a bit more work than I figured it would be but I think I have it done and working.

21:48 <othx> FractOrr: 4 hours, 7 minutes, 50 seconds ago peeps[work] tell FractOrr in case you hadn't found it yet, .ui files are added here: https://github.com/openscad/openscad/blob/master/CMakeLists.txt#L1025-L1051

21:49 <teepee> FractOrr: why do you still have an openscad.pro? that a bit odd, that should have been removed quite a while ago

21:49 <teepee> but working sounds great!

21:49 <FractOrr> yes, so I can delete that?

21:50 <peeps[work]> .pro is project file for Qt's qmake build tool, which we moved away from a couple years ago (in favor of cmake)

21:51 <othx> peeps[work]: 3 hours, 34 minutes, 40 seconds ago God tell peeps[work] to devote all of his time to OpenSCAD development.

21:51 <FractOrr> okay, will just nuke that file then

21:54 <InPhase> FractOrr: Where exactly did you get it from?

21:54 <InPhase> FractOrr: It hasn't been in the repository in a long time. Are you working from a current master branch?

21:54 <FractOrr> I just clone the repo a couple of days ago

21:54 <InPhase> Are you on the master branch?

21:55 <InPhase> Or did you clone from a PR or a fork or something?

21:55 <FractOrr> yes on the master branch

21:55 <InPhase> FractOrr: What does "git remote -v" show?

21:57 <FractOrr> origin https://github.com/openscad/openscad.git (fetch)

21:57 <FractOrr> origin https://github.com/openscad/openscad.git (push)

21:57 <InPhase> And does "git status" say "Your branch is up to date with 'origin/master'."

21:58 <FractOrr> On branch master

21:58 <FractOrr> Your branch is up to date with 'origin/master'.

21:58 <InPhase> Does "git log" have "commit 70309bcaa768bccb8405a90f6761434d790f0234" as the top line?

21:58 <peeps[work]> maybe Qt creator/designer created something automatically?

21:59 <FractOrr> yes

21:59 <InPhase> peeps[work]: Oh...

21:59 <peeps[work]> that's the only thing I can guess if things are actually current

21:59 <InPhase> FractOrr: Yeah, when opening it Qt Creator, click directly on the CMakeLists.txt file to open it.

21:59 <peeps[work]> but i agree it is very suspicious

22:00 <InPhase> FractOrr: But make sure to check that commit in the git log. That was the last item to verify you are completely current. :)

22:00 <InPhase> FractOrr: I just don't want you to waste time trying to integrate your work into horribly outdated code, because then you'd have to redo it.

22:01 <InPhase> And that would be a frustrating introduction to the project. ;)

22:02 <InPhase> FractOrr: The commit I referenced is the Oct 15 one. If you cloned prior to Oct 15 you might have "commit b23dd28acbb40c8629046cd587406cf5561f5784" for the Oct 11 work.

22:06 <FractOrr> These are the first 3 entries from git log

22:06 <FractOrr> commit 70309bcaa768bccb8405a90f6761434d790f0234 (HEAD -> master, origin/master, origin/HEAD)

22:06 <FractOrr> Author: Marius Kintel <marius@kintel.net>

22:06 <FractOrr> Date: Sun Oct 15 16:39:07 2023 -0400

22:06 <FractOrr>     Add note about LLVM bug on macOS (#4783)

22:06 <FractOrr> commit b23dd28acbb40c8629046cd587406cf5561f5784

22:06 <FractOrr> Author: Marius Kintel <marius@kintel.net>

22:06 <FractOrr> Date: Wed Oct 11 10:20:19 2023 -0400

22:06 <FractOrr>     Fall back to GLX if we're using GLEW (#4779)

22:06 <FractOrr> commit 1cdb00acc9eae8558bcfea1e1178ad44104dd7fd

22:06 <FractOrr> Author: Marius Kintel <marius@kintel.net>

22:06 <FractOrr> Date: Mon Oct 9 23:51:16 2023 -0400

22:06 <FractOrr>     Upgrade Cairo to 1.18.0 (#4775)

22:09 <teepee> looks good, all up-to-date

22:52 <FractOrr> well crap, I cleaned up some code and made some mods to the ui file and now I get a Segmentation fault when I try to export to the new file format.  Guess I begin the slow painful process of enabling debug and track down where the issue is

22:58 <peeps[work]> FractOrr: as long as you set CMAKE_BUILD_TYPE=Debug i *think* it should at least hint the offending line of code when it segfaults. though for a full stacktrace + stepping through you will need to connect proper debugger

22:59 <peeps[work]> brb, rebooting

23:12 <teepee> FractOrr: if you push the current state to github (or even create a draft PR) someone might be able to help with such cases

23:13 <FractOrr> it is almost done recompiling everything so I will what I can come up with

23:17 <teepee> no rush, I'm off to bed soon. just mentioning while there's maybe not much lightburn specific help, with general stuff we should be able to help

23:21 <peeps[work]> at first mention of lightburn, my brain went to this old tech for labeling optical discs, lol https://en.wikipedia.org/wiki/LightScribe but of course its actually laser cutter software which makes much more sense

23:23 <teepee> ah, yes, I've never seen those in the real world, but I do remember that name

23:27 <FractOrr> LOL!!!

23:30 <FractOrr> When I do the export in the gui the export works fine but when I close the app I get that Segmentation fault error.  When I run the export on the command line it creates the export file but it is 0 bytes and then I get the Segmentation fault error

23:33 <InPhase> FractOrr: Are you relatively new to C++?

23:33 <InPhase> (To calibrate the advice type.)

23:39 <FractOrr> has been about 20 years since I done any C / C++ coding

23:40 <FractOrr> have been doing mostly PHP

23:45 <teepee> oh, look https://github.com/FrameworkComputer/ExpansionCards/blob/main/Mechanical/OpenSCAD/ExpansionCard.scad