michaelni changed the topic of #ffmpeg-devel to: Welcome to the FFmpeg development channel | Questions about using FFmpeg or developing with libav* libs should be asked in #ffmpeg | This channel is publicly logged | FFmpeg 7.0.1 has been released! | Please read ffmpeg.org/developer.html#Code-of-conduct
lexano has quit [Ping timeout: 252 seconds]
jamrial has quit [Read error: Connection reset by peer]
jamrial_ has joined #ffmpeg-devel
System_Error has joined #ffmpeg-devel
System_Error has quit [Quit: Leaving]
System_Error has joined #ffmpeg-devel
thilo has quit [Ping timeout: 260 seconds]
thilo has joined #ffmpeg-devel
jamrial_ has quit [Read error: Connection reset by peer]
jamrial has joined #ffmpeg-devel
arch1t3cht1 has joined #ffmpeg-devel
arch1t3cht has quit [Ping timeout: 260 seconds]
arch1t3cht1 is now known as arch1t3cht
cone-340 has joined #ffmpeg-devel
<cone-340>
ffmpeg Leo Izen master:4225f51c62b6: avcodec/pngdec: avoid erroring with sBIT on indexed-color images
<cone-340>
ffmpeg Leo Izen master:90e28331c788: avcodec/png: more informative error message for invalid sBIT size
<cone-340>
ffmpeg Leo Izen release/7.0:b5d42852d055: avcodec/pngdec: avoid erroring with sBIT on indexed-color images
<cone-340>
ffmpeg Leo Izen release/7.0:daffde0544aa: avcodec/png: more informative error message for invalid sBIT size
<cone-340>
ffmpeg Leo Izen release/6.1:09c1c0b12653: avcodec/pngdec: avoid erroring with sBIT on indexed-color images
<cone-340>
ffmpeg Leo Izen release/6.1:6a8cf7b3834b: avcodec/png: more informative error message for invalid sBIT size
<Traneptora>
JEEB: think I can merge the v3 of the fate test?
<Lynne>
mainly the speed improvements come from downloading on AMD
<Lynne>
I also had code to merge different planes together when mapping if they were close enough, but with the realization we don't do some low-branch optimizations we really should, it was pointless
<Lynne>
so I optimized the alloc path instead
Traneptora has quit [Ping timeout: 248 seconds]
Traneptora_ has joined #ffmpeg-devel
<haasn>
Lynne: why don’t you use ff_log2 to align to the nearest power of two?
<haasn>
Reads cleaner and is on average faster
<haasn>
2 << log2(x - 1)
<Lynne>
for which part?
<elenril>
Lynne: to allow separating individual planes
Traneptora has joined #ffmpeg-devel
<elenril>
e.g. passing through luma in nv12 -> yuv420p
Traneptora_ has quit [Ping timeout: 276 seconds]
<elenril>
(which we don't do because swscale, but the idea was to make it possible)
Krowl has quit [Read error: Connection reset by peer]
<Lynne>
ah, I see
<Lynne>
I don't like it :/
<haasn>
Lynne: in your new alloc path you align up to nearest pot
<haasn>
elenril: funnily enough I was planning on finally making use of that capability in avscale
<Lynne>
haasn: do you remember the extension or API that let you assign opaque handles to vulkan objects?
ngaullier has joined #ffmpeg-devel
q66 has quit [Quit: WeeChat 4.3.5]
q66 has joined #ffmpeg-devel
jamrial has joined #ffmpeg-devel
HarshK23 has quit [Quit: Connection closed for inactivity]
<j-b>
good morning
<rajivharlalka>
why and how does the linesize depend on the output file format?
lexano has joined #ffmpeg-devel
<rajivharlalka>
I was trying to convert to exr format, and all the first three planes in linesize have equal values, which is 4x the width. the pixel is a 10bt value.
haihao_ has quit [Ping timeout: 276 seconds]
haihao_ has joined #ffmpeg-devel
Livio has quit [Ping timeout: 248 seconds]
mkver has joined #ffmpeg-devel
cone-869 has joined #ffmpeg-devel
<cone-869>
ffmpeg James Almer master:97fd5d336381: checkasm/lls: increase epsilon value for the update_lls test
Krowl has quit [Read error: Connection reset by peer]
Traneptora has quit [Quit: Quit]
Traneptora has joined #ffmpeg-devel
<AndrewSayers>
In the AV_OPT_TYPE_IMAGE_SIZE thread on the ML, it's been suggested to change the type of {Tile,Untile}Context from `unsigned` to `int`. These are private contexts, but publicly accessible through the AVOptions API. Would that change require a version bump?
<Lynne>
yeah, a major bump, options are unfortunately a part of the ABI and users are allowed to directly set them
<Lynne>
mpv does that for filters
\\Mr_C\\ has joined #ffmpeg-devel
<AndrewSayers>
Fair enough.
Krowl has joined #ffmpeg-devel
haihao_ has quit [Ping timeout: 252 seconds]
haihao_ has joined #ffmpeg-devel
<Lynne>
finally, its summer
<Lynne>
can't it be this warm all year round?
<gnafu>
Please, nowhere I live :-P.
Krowl has quit [Read error: Connection reset by peer]
SuRGeoNix has joined #ffmpeg-devel
<SuRGeoNix>
Hi guys, I was wondering how can i check if an output format supports a specific codec... I was looking into AVOutputFormat.codec_tag but for example in mkv it does not contain ff_mkv_codec_tags and in matroska.c has a comment to include them also in additional_video_tags which does not exist? (sorry if wrong channel for this question)
Livio has joined #ffmpeg-devel
<kepstin>
the most reliable way to check is to attempt to mux a particular codec into a particular format and see if you get an error
<kepstin>
(and yeah, this question is more of an #ffmpeg usage question)
<ramiro>
Traneptora: sorry to bother you again :). there are a few samples on the PngSuite that I thought were invalid, but they actually seem to be valid. for example: http://www.libpng.org/pub/png/PngSuite/s09n3p02.png
<SuRGeoNix>
kepstin that's the thing, using hevc for mp4 works fine bug actually you get rawvideo as a codec at the end
<Traneptora>
ramiro: Each depth specified in sBIT shall be greater than zero and less than or equal to the sample depth (which is 8 for indexed-colour images, and the bit depth given in IHDR for other colour types)
<Traneptora>
I see, the issue, I checked the spec
<SuRGeoNix>
(no mp4 but avi... when you mux hevc in avi you get not errors and at then with ffprobe it looks like is rawvideo/bgr24)
<Traneptora>
needs to be 8 for indexed
cone-357 has joined #ffmpeg-devel
<cone-357>
ffmpeg Leo Izen master:e30bc8a963ea: fate/png: add mDCv and cLLi read and write test
<ramiro>
Traneptora: also we should probably fix the same thing in pngenc.c (I had done 'grep -i sbit libavcodec/pngenc.c' and it had no hits so I assumed we weren't writing it out, but we are).
ngaullier has quit [Quit: Leaving]
<ramiro>
I guess we should add PngSuite to fate. what's the procedure for that?
<Traneptora>
we have to add individual files
SuRGeoNix has left #ffmpeg-devel [#ffmpeg-devel]
<ramiro>
not the whole suite? along with the extension suite with cicp and mdcv, there are 180 something files, but they're all small.
<ramiro>
less than 2mb for everything.
IndecisiveTurtle has joined #ffmpeg-devel
<JEEB>
that's a nice size for the suite
<courmisch>
I see the TC is about as responsive as the CC
<JEEB>
I was going to ask about the requirements for responses
<JEEB>
as in, by when the first response should happen etc
<courmisch>
or else what? I think that's the real question
<JEEB>
anyways, I should have at least some availability to write down things, which hopefully would at least kickstart something. my experience of TC so far has been that decisions do get made. but yea, no responses = no decision.
<courmisch>
my experience is that neither the TC nor the CC are responding to any request
<Traneptora>
ramiro: patch sent to ML
<Traneptora>
(for the sample, not for fate. that'll come later)
<ramiro>
JEEB: if there's no response after two weeks, we get to modify a random flag name from a public header file without bumping major.
haihao_ has quit [Ping timeout: 248 seconds]
haihao_ has joined #ffmpeg-devel
<courmisch>
soon, I'm at 12 days, 22 hours and 19 minutes
feiw1 has quit [Remote host closed the connection]
feiw1 has joined #ffmpeg-devel
<Lynne>
ramiro: you want to do what?
<ramiro>
Lynne: add PngSuite to fate
<Lynne>
no, about chaning a header
<ramiro>
Lynne: oh, that's just trolling...
<Lynne>
ah, humor
<Lynne>
I was in a technical meeting for 2 hours, I lost a sense for it
<ramiro>
Lynne: technical meetings are bad for our health...
<jamrial>
<@Lynne> yeah, a major bump, options are unfortunately a part of the ABI and users are allowed to directly set them <- uh? no, the internal fields are not exposed, just the AVOption, which will have no changes done to it
<jamrial>
and any changes to AVOptions is a micro bump. not even minor
<AndrewSayers>
jamrial: surely changing the signedness will affect the range of valid values - an API change?
<jamrial>
andrewrk: no, because it's limited to 0..INT_MAX regardless of where you store the value
<jamrial>
err, sorry, meant to ping AndrewSayers
<jamrial>
AVOptions of type image size will be parsed with av_parse_video_size()
HarshK23 has joined #ffmpeg-devel
<jamrial>
so just change the fields to int
<Lynne>
jamrial: each AVOption is exposed, by using av_opt_next you can iterate through each context's options
<Lynne>
but sure, we've changed options before
<jamrial>
and what does that have to do with anything?
<jamrial>
this is about the field type in the struct, not the AVOption
<jamrial>
he's not touching the latter
<Lynne>
you mentioned they're not exposed, that's all
<jamrial>
i said the struct fields aren't
<Lynne>
yeah, fair enough
<Lynne>
I got confused about changing an api, but options are free to change with hardly a micro bump
<AndrewSayers>
Hmm, technically it looks like UB - av_parse_video_size() calls strtol(), which returns a long that gets assigned to an int.
<AndrewSayers>
(even nitpickier: width and height == 0 are disallowed)
AbleBacon has joined #ffmpeg-devel
mkver has quit [Ping timeout: 252 seconds]
<Traneptora>
it also appears to ignore the x, like -video_size 128+456 is apparently parsed as 128 by 456
<Traneptora>
not sure if that's ideal/desired
haihao_ has quit [Ping timeout: 276 seconds]
haihao_ has joined #ffmpeg-devel
rodgort has quit [Quit: Leaving]
rodgort has joined #ffmpeg-devel
mkver has joined #ffmpeg-devel
Livio has quit [Ping timeout: 252 seconds]
MisterMinister has joined #ffmpeg-devel
IndecisiveTurtle has quit [Ping timeout: 248 seconds]
<andrewrk>
jamrial: thanks for taking care of my fellow Andrew's question
cone-357 has quit [Quit: transmission timeout]
MrZeus_ has joined #ffmpeg-devel
Livio has joined #ffmpeg-devel
MikhailAMD has joined #ffmpeg-devel
MikhailAMD has quit [Client Quit]
MikhailAMD has joined #ffmpeg-devel
Livio has quit [Ping timeout: 252 seconds]
fmlatghor has left #ffmpeg-devel [WeeChat 3.8]
haihao_ has quit [Ping timeout: 276 seconds]
haihao_ has joined #ffmpeg-devel
witchymary has quit [Remote host closed the connection]
witchymary has joined #ffmpeg-devel
HarshK23 has quit [Quit: Connection closed for inactivity]
MisterMinister has quit [Ping timeout: 248 seconds]
MisterMinister has joined #ffmpeg-devel
MisterMinister has quit [Remote host closed the connection]
haihao_ has quit [Ping timeout: 248 seconds]
haihao_ has joined #ffmpeg-devel
Livio has joined #ffmpeg-devel
georgereynolds8 has quit [Quit: Ping timeout (120 seconds)]
georgereynolds8 has joined #ffmpeg-devel
Marth64 has quit [Quit: Leaving]
Livio has quit [Ping timeout: 252 seconds]
haihao_ has quit [Ping timeout: 252 seconds]
haihao_ has joined #ffmpeg-devel
Kei_N has quit [Read error: Connection reset by peer]
Kei_N has joined #ffmpeg-devel
mkver has quit [Remote host closed the connection]
mkver has joined #ffmpeg-devel
ccawley2011 has quit [Read error: Connection reset by peer]