<gbruno>
[github] kintel pushed 32 modifications (Fix includes for `<array>`, `<map>`, `<set>`, `<unordered_map>`, `<unordered_set>` (#5334) * Include <unordered_set> for files using std::unordered_set * Include <unordered_map> for files using std::unordered_map * Include <set> for files using std::set * Include <map> for files using std::map * Include <array> in files using std::array) https://github.com/openscad/openscad/commit/8c17c8951449f95292c1f37ffc606e613
<InPhase>
I still wanted to put a PR that boosts the default to $fa=1; $fs=0.4; I even wrote it, but didn't put it up because it requires going through and fixing up a few of the tests that explode into complexity with that setting.
<InPhase>
I hit a few clobbering life events, so I didn't get around to that step yet.
<InPhase>
One must be at least a little bit careful replacing the test results to compare to. :)
<kintel>
yeah, test tweaking can be a bit of a mine field.. I've wanted to redesign our test framework many times, but there just isn't a great way of getting there.
<J24k35>
InPhase iirc teepee had the idea to put default $fa,$fs in the preferences - So on new installs it could ask you if you like to use higher resolution by default ..
<J24k35>
or change what ever is suitable for you to use
<J24k35>
it sure will be overwritten if defined in the code
<J24k35>
that shouldn't have any impact on testing
<J24k35>
btw: when installing default file locations are used - not where it was installed to upgrade (as other software does)
misterfish has quit [Ping timeout: 265 seconds]
misterfish has joined #openscad
Non-ICE has quit [Quit: Screw you guys, im going home!]
teepee_ has joined #openscad
teepee has quit [Ping timeout: 260 seconds]
teepee_ is now known as teepee
Non-ICE has joined #openscad
misterfish[x] has joined #openscad
Non-ICE has quit [Quit: Screw you guys, im going home!]
ccox_ has joined #openscad
ccox has quit [Ping timeout: 252 seconds]
Non-ICE has joined #openscad
misterfish has quit [Ping timeout: 265 seconds]
misterfish has joined #openscad
mmu_man has joined #openscad
fling_ has joined #openscad
fling has quit [Ping timeout: 260 seconds]
fling_ is now known as fling
snaked has quit [Quit: Leaving]
mtm has quit [Ping timeout: 265 seconds]
mtm has joined #openscad
<InPhase>
J24k35: There has to be a non-interactive default during installs, given that many installs are not interactive processes, and I'm quite convinced that needs to be $fa=1; $fa=0.4; or similar to modernize the output. We could of course override that default preference setting for testing just to keep all the tests unchanged, but that would be somewhat questionable in my view to have a default for all
<InPhase>
testing mismatching the released default.
<InPhase>
J24k35: So I think the more reasonable path includes one default for most tests, and hand-adjusting the small number of tests which are ballooning out of reasonable resolution scale with that adjusted default by inserting the old $fa and $fs settings into those handfuls of scad files.
<InPhase>
Then we would have tests that primarily match the defaults, and some tests which set other variable settings for these, which is totally reasonable.
Guest72 has joined #openscad
<InPhase>
s/$fa=1; $fa=0.4;/$fa=1; $fs=0.4;/
<J24k35>
having tests with different values ..
<InPhase>
J24k35: I actually don't mind if we choose to make it a preferences setting. I just think that if we do that, the preferences setting should first initialize to the more modern values, to get people onto a common modern base.
Guest72 has left #openscad [#openscad]
<J24k35>
yes sure - but as you (and me) tried to change this for now what 5years. And as such a simple change is not going through because the tests render differently - like having $fa limited to 72 and not 120 - it seems we need a work around for some progress
<InPhase>
There's a slight hazard to contemplate going forward in that different preferences for this introduces the notion that different people will get different default results within the gui. And also render results from the gui will not match render results from the command line (which don't load preferences) unless these are manually passed there.
<InPhase>
I'm not sure if that's a good thing, although I partly appreciate the idea that defaults for this would have some utility.
<J24k35>
i agree on the the command line issue - that would be bad
<J24k35>
could make a template with $fa=1;$fs=0.4; though
<J24k35>
but for new users this is just a terrible experience to start with $fa=12 and $fs=2;
<InPhase>
J24k35: Yeah. I think given the ease of adjusting it for specific designs, the notion of preferences and such are not such a big deal. I tend to put these settings anyway in any substantive design. Mostly to me it is just about the quality of that initial experience, which I think is very important.
<InPhase>
Also it would be nice to not have to throw those assignments in every one-line demo that involves round things. ;)
<InPhase>
I tend to do that just because of the frequency with which those one-line demos are being provided to new people who might not yet know about those.
<InPhase>
Which again, falls under initial experience.
fling has quit [Remote host closed the connection]
fling has joined #openscad
misterfish has joined #openscad
PolyBytes has joined #openscad
<PolyBytes>
hey everyone, is there a way that I can specify $fn for a particular block instead of just globally or per-shape? I want the $fn of all shapes in a difference() block to be the same
<teepee>
yes, you can do that
<teepee>
assuming those shapes don't overwrite it themselves
<PolyBytes>
thank you, how do I do it?
<teepee>
just put it into the block where is should start with the new value
<PolyBytes>
oh okay thank you! I was really overthinking that '=D
<teepee>
those $ variables are special in that behavior
<teepee>
maybe also check if $fa/$fs makes it simpler as those adapt to the size
<teepee>
like $fn = 100; for a big circle might just be enough, but it's crazy high for a 1mm circle
<teepee>
$fa = 1; $fs = 0.2; will create an angle resolution of 1 degree (= 360 circle segments) and a segment length of 0.2 units
<PolyBytes>
oh wow I didn't know those adapted to size, I am new to OpenSCAD and I love the workflow. I was already struggling with $fn and size issues because I'm making a modular part that can change size so I'll definitely check these out thank you!
<teepee>
so whatever is creating a larger segement is used
<PolyBytes>
if I have shapes that I only want to exist while im working, should I just wrap them in a if($preview) { ... }?
fling has quit [Ping timeout: 260 seconds]
myosotis has quit [Remote host closed the connection]
fling has joined #openscad
myosotis has joined #openscad
<teepee>
PolyBytes: that or use the % modifier
myosotis has quit [Ping timeout: 244 seconds]
PolyBytes has quit [Ping timeout: 256 seconds]
misterfish has quit [Ping timeout: 255 seconds]
myosotis has joined #openscad
guso78k has joined #openscad
UltimateCodeWarr has quit [Quit: Client closed]
Junxter has joined #openscad
ooxoo has quit [Ping timeout: 246 seconds]
UltimateCodeWarr has joined #openscad
guso78k has quit [Quit: Client closed]
<UltimateCodeWarr>
Is there such thing as a squished cylinder, like a toilet paper roll that you stepped on.
<UltimateCodeWarr>
can't seem to resize a cyllider
<guso78k>
quite sure, that there is no HTML. i am interested in a raw file rather
<peepsalot>
ok, i don't know what that zip is, but i can show you where to get the actual test report zips. there are seperate ones for each runner
<peepsalot>
from a PR with failing tests, click "Details" on one of the failing, then click on "Summary" from the left pane of the CI log page. then scroll down all the way and you will find the zip archives containing the generated report HTML
<JordanBrown>
Also, even with the DIY linear extrude, it isn't at all clear what translating a circle up in Z, and then extruding it, would do. Generally you should keep 2D objects in the Z=0 plane.
<J24k35>
you could use linear_extrude(50,v=[3,0,1])circle(20);
mmu_man has joined #openscad
<J24k35>
UltimateCodeWarr nice to see how your design improves
<JordanBrown>
Yes, looks nice.
<teepee>
guso78k: I have a somewhat working 3mf-v1 import, should we put that into the same PR as the color export? that could help with getting test cases sorted
<guso78k>
yeahh, dont hesitate to push into any of my branches ;)
guso78k has quit [Quit: Client closed]
guso78k has joined #openscad
guso78k has quit [Client Quit]
teepee_ has joined #openscad
teepee has quit [Ping timeout: 260 seconds]
teepee_ is now known as teepee
<PolyBytes>
how do you center a module on 0,0,0?
guso78k has joined #openscad
<UltimateCodeWarr>
How do I make that Nato Rail Tail Longer? module NatoSchiene(l=50,screw,ext=0)
<J24k35>
ext = 10
<J24k35>
UltimateCodeWarr ext = extend
guso78k has quit [Client Quit]
<UltimateCodeWarr>
Thx, worked perfectly!
snaked has joined #openscad
juri_ has quit [Ping timeout: 260 seconds]
<PolyBytes>
is it possible to set a minimum value for a spinbox in the customizer?