2018-11-12 22:39
ChanServ changed the topic of #mlpack to: "mlpack: a fast, flexible machine learning library :: We don't always respond instantly, but we will respond; please be patient :: Logs at
http://www.mlpack.org/irc/
06:08
ImQ009 has joined #mlpack
09:00
arun[m]1 has left #mlpack []
11:04
gaulishcoin has joined #mlpack
15:27
AnirudhSinghChau has joined #mlpack
15:27
<
AnirudhSinghChau >
Hello! Actually I am new here. I read some stuff regarding mlpack and found it really interesting and I would love to contribute.
15:35
<
zoq >
AnirudhSinghChau: Hello there, that is great.
17:11
<
AakashkaushikGit >
Hi @rcurtin, if you are free can you review #2603 ?
17:16
<
yashwants19[m] >
Hey "rcurtin" (
https://matrix.to/#/ @freenode_rcurtin:matrix.org) I think so mlpack-version in version.hpp is not correct.
17:20
<
yashwants19[m] >
If we submit R-bindings/mlpack_r_tarball from current release to CRAN, we might face some NOTE from CRAN of Status: 404.
17:22
<
yashwants19[m] >
BTW that NOTE will come with New submission.
17:28
<
yashwants19[m] >
Are we just incrementing the Version in version.hpp or we update the version according to the input to the mlpack-release.sh?
17:50
<
rcurtin >
yashwants19[m]: do you mean for 3.4.1 or 3.4.0?
17:51
<
rcurtin >
in mlpack-3.4.1.tar.gz, the file in src/mlpack/core/util/version.hpp has version 3.4.1 correctly
17:53
<
rcurtin >
which is the one built on the 3.4.1 tag, not on master (which now has 3.4.2 in version.hpp, since it may deviate from 3.4.1)
17:55
<
rcurtin >
anyway, I'll be working on the CRAN submission shortly, so I'll let you know what the results are
18:10
<
yashwants19[m] >
Ohh, I am sorry I was making blunder here.
18:17
<
yashwants19[m] >
Thank you for the clarification
18:17
<
yashwants19[m] >
Yoy are the best. :)
18:18
<
yashwants19[m] >
You*
18:22
<
rcurtin >
no worries, at least with R I only
*sort of* know what I'm doing :)
18:24
<
rcurtin >
ok, R CMD check --as-cran succeeds, but there are two warnings; one is the package size (which shouldn't be an issue)
18:24
<
rcurtin >
the other seems to be the DESCRIPTION file
18:24
<
rcurtin >
I think the description has to not start with the package name
18:24
<
rcurtin >
so it's currently: "Description: 'mlpack' is a fast, flexible machine learning library, written
18:25
<
rcurtin >
but I think I will change it to "Description: A fast, flexible machine learning library, written ..." for submission
18:27
<
yashwants19[m] >
But i think so CRAN will also complain about 'New Submission' under DESCRIPTION, which seems ok with other NOTES.
18:29
<
yashwants19[m] >
In this I think so initial initial tasks are almost done.
18:31
<
rcurtin >
ok, in this case, I'll try it without changing DESCRIPTION and we'll see what happens :)
18:39
<
yashwants19[m] >
Lets see how it works.
19:29
ImQ009 has quit [Quit: Leaving]