06:31 <kares[m]> also thinking of merging https://github.com/jruby/jruby/pull/7784 to 9.3 (as well), unless someone objects 😜

06:31 <kares[m]> only has an effect during compilation (code generation) and makes potential custom jruby patches easier to follow ...

14:02 <headius> kares: oh yeah for sure

14:03 <headius> maybe could improve build time if last modified is stable now?

14:04 <headius> enebo: so we need to fork jzlib

14:04 <headius> we have a few outstanding issues that are never going to get patched, and some fixed issues that are never going to get released because the original author has disappeared

14:04 <headius> https://github.com/jruby/jruby/issues/1422

14:05 <headius> this one affects rack tests for gz compression of responses

14:05 <headius> it tries to verify last modified is the same on the sending and receiving side but the receiving side runs into this bug in jzlib's inflater not populating its own mtime

14:06 <enebo[m]> yum

14:06 <headius> https://github.com/ymnk/jzlib/issues/22

14:06 <headius> others need this to be maintained and updated too

14:06 <headius> sigh

14:09 <headius> I'll just put it in my github and group ID unless we really want it under jruby

14:09 <enebo[m]> well if you want me to fix issues it may be smipler to have it on jruby

14:10 <enebo[m]> not much but you would have to add me :)

14:11 <headius> heh nevermind we already forked it at some point: https://github.com/jruby/jzlib

14:12 <headius> I don't want this to look like a dependent fork so I'm going to recreate this repo as an exact non-fork copy of the original and we'll take it over

14:34 <headius> enebo: merged unreleased fixes and merged my build changes and it passes the flaky rack test now

14:35 <headius> I think this could be released any time

14:35 <enebo[m]> you mean jzlib?

14:35 <headius> yeah

14:35 <enebo[m]> ship it!

14:35 <headius> org.jruby:jzlib:1.1.4

14:35 <headius> there's one other fix that merged in to support concatenated gzip streams

14:35 <headius> seems fine

14:36 <headius> wemight even have a bug open for that

15:05 <headius> the deed is done

15:05 <headius> when I see it in central I'll push PR to switch

15:05 <enebo[m]> ok

15:07 <headius> and my work machine has a functioning gpg key again so I can release stuff

17:53 <headius> that concatenated gzip thing seems to cause failures so I'm reverting it and will make a PR

17:53 <headius> it's not quite right apparently, or perhaps JRuby's user is incorrect

17:53 <headius> s/user/use/

18:15 <headius> testing jzlib 1.1.5 to make sure it's all green and then I'll release it

18:15 <headius> we can investigate the patch here if we want: https://github.com/jruby/jzlib/pull/1

18:15 <headius> we are now no longer a fork repo either and the other work branches from jzlib are only on ymnk/jzlib now

18:15 <headius> not sure if we want to bring those over or not

18:29 <headius> looks good

19:02 <enebo[m]> headius: I think not on branches. If someone wants to revive those we can add them or ask for a new PR

19:02 <enebo[m]> To me it feels like entropy

19:03 <enebo[m]> or potential entropy

19:03 <enebo[m]> working on kwargs issue now

19:03 <headius> Yeah

19:30 <headius> jzlib stuff is all settled on master

19:30 <headius> 39 targeted issues remain

19:56 <headius> going to the fair so calling it a day for now

19:56 <headius> ttfn