rcrews[m] has quit [Remote host closed the connection]
subbu has joined #jruby
subbu has quit [Ping timeout: 240 seconds]
subbu has joined #jruby
subbu has quit [Ping timeout: 248 seconds]
subbu has joined #jruby
subbu has quit [Ping timeout: 268 seconds]
subbu has joined #jruby
<headius>
Tim Uckun: Most of these would probably be best left to defaults, and CMS is largely deprecated now. We will want to revisit them and see if they're worth looping back in
<headius>
the only ones I'd say are good to keep would be invokedynamic, ipv4 (presumably needed for this to work right), and maybe the metaspace and codecache settings but only if they're actually needed
<headius>
the rest are better left unset or I would need to read up on them more
<headius>
enebo: any concerns about this? I know all modern JVMs can optimize through lazy static finals like this so I have no concerns at the moment
<enebo[m]>
yeah I saw it. No concerns.
<enebo[m]>
I asked lopex if hewould review the other PR
<headius>
only bit I would have trouble saying yes to is the naming of the properties
<headius>
but I don't have a good alternative... there's not really a joni.org and putting the properties under JRuby seems wrong now
<headius>
they're also snake_case instead of camelCase but I don't have a strong opinion on that either
<enebo[m]>
I don't think there has to be a real org for namespacing
<enebo[m]>
org.joni.opt wouldperhaps be more consistent for us but I doubt another joni will pop up in Java lib land
<enebo[m]>
I prefer snake case just because it is easier to delineate words
<enebo[m]>
but perhaps that is unusuable for java opts
<enebo[m]>
heh unusual
<headius>
unusual perhaps
<enebo[m]>
I don't care because these are rare options
<enebo[m]>
and these choices do not make them confusing
<headius>
yeah
<headius>
someone owns joni.org through godaddy but there's no site
<enebo[m]>
probaably not for software
<enebo[m]>
4 letter domains are tough to get
<headius>
there's plenty of other tlds now too
<headius>
but I'm fine just going with these properties as is
<enebo[m]>
2023-05-22T11:03:06.733-05:00 [main] INFO TraceType : Exception raised: TypeError : superclass must be a Class (Integer given)
<enebo[m]>
is it me or are all errors lacking where stuff happens
<headius>
that's interesting
<enebo[m]>
this is yarp parsing so perhaps not that interesting
<headius>
I have not seen that all of them are lacking
<headius>
I file an issue about some specific cases swallowing the Java cause when classloading fails but others have been ok
<headius>
something like that could be happening during boot before there's any backtrace to present
<headius>
final boolean DONT_OPTIMIZE = ConfigSupport.getBoolean("joni.dont_optimize", false);
<headius>
that's confusing
<headius>
should be OPTIMIZE=true or maaaaybe DISABLE_OPTIMIZATION=false
<enebo[m]>
optimise is a nearly meaningless term too
<headius>
it's better than turning off "don't optimize"
<headius>
but yeah it is pretty vague
<headius>
I assume it is configurable for debugging
<enebo[m]>
sure I do not use negatives even in if statements 99% of the time much less options
<enebo[m]>
protected final void setOptimizedInfoFromTree(Node node) {
<enebo[m]>
it is what it is called so I would reverse and default to true I guess
<headius>
yeah I just submitted a review with that and a couple other things
subbu has quit [Ping timeout: 256 seconds]
<byteit101[m]>
headius: did you see my message from saturday?
<headius>
no I will look back
<headius>
enebo: not sure what to do about that weird encoding error not erroring under indy on CI... I can't reproduce locally and have no idea how indy would affect it
<headius>
byteit101: trying it now
<enebo[m]>
headius: worst case we exclude it (even though it tests 10 million other combos)
<headius>
require 'subspawn' still works with new gem
<headius>
you have messed around with this optimization so maybe you have some thought here
<headius>
I guess it wasn't actually compiled before because it was static final false
<enebo[m]>
weird. I thought my revert to fix perf rgression enabled sunday search
<enebo[m]>
I will look into that I guess
<headius>
yeah confusing
<headius>
enebo: ok yeah reverse what I said... it was true before but now it might be true or false so the old path is followed and does not initialize the variable
<headius>
I'm looking into the cve's
<headius>
both CVEs should be patched and should be simple gem upgrades
<headius>
I have lots track of CRuby security since March but I knew these were floating around
<headius>
s/lots/lost/
<headius>
enebo: joni PR looks good to me at this point, other than not knowing whether that sunday search patch is right
subbu has quit [Ping timeout: 265 seconds]
<byteit101[m]>
Only took me 2 hours to recover from oom/swap hell, but I just published and tagged 0.5.1.1. can be updated in the pom.rb file now