<coder_kalyan>
hmm, im having some trouble with your OSC8 PRs on senpai dnkl
<coder_kalyan>
ill try to make sure everything is up to date and try again/file a report tmrw
ecocode__ has joined #foot
gtms has joined #foot
<dnkl>
coder_kalyan: the crashing kind of trouble?
<dnkl>
coder_kalyan: it kind of looks like senpai doesn't terminate the OSC-8 URLs correctly
<dnkl>
But I haven't looked at the escapes emitted, so could be something else
<dnkl>
emersion: I noticed that your OSC-8 PR for tcell adds a new capability to tcell's built-in terminfo database. Foot has several terminfos. Any thoughts/plan to improve that?
<dnkl>
For example, I currently use foot-extra
<dnkl>
But there's also foot-direct (part of ncurses)
<emersion>
dnkl: hm, not sure what you mean…
<emersion>
do you mean we should copy over foot-extra to tcell?
<dnkl>
emersion: might not be necessary to copy over, since tcell's terminfo is very stripped down. But some way to handle TERM=foot-* would be good
<emersion>
oh, i see
<dnkl>
I don't think foot-extra has any capabilities tcell uses/cares about, and could probably map directly to "foot"
<dnkl>
Foot-direct* may require a separate entry in tcell
<dnkl>
coder_kalyan: I did manage to find a way to crash foot, even with the latest patches
<dnkl>
Basically, emit an OSC-8, move the cursor back somewhere inside the hyperlink, start a new link, move the cursor outside the old hyperlink, terminate the second link. And crash
<dnkl>
That's not something a well behaving application should be doing, but should of course still be handled by foot
<dnkl>
I did see this with senpai, but it'll probably disappear once senpai starts terminating the links correctly
<dnkl>
Will push a fix for foot later
ynakao has quit [Quit: WeeChat 3.3]
ynakao has joined #foot
<dnkl>
hhirtz: I think senpai has an issue with terminating OSC-8 URLs, when the URL is at the end of the string being parsed (i.e the string ends with an URL)
<dnkl>
Probably because the last "style", where the hyperlink is being reset, isn't being applied
<dnkl>
I'm guessing because the last style's start index is at the end of the string
<dnkl>
Hmm, sorry, maybe you're not the right person
<dnkl>
Just noticed your name all over the source
<dnkl>
S
* dnkl
goes to #senpai
novakane has quit [Quit: WeeChat 3.3]
novakane has joined #foot
cbb has joined #foot
<coder_kalyan>
hhirtz is indeed the creator of senpai :)