michaelni changed the topic of #ffmpeg-devel to: Welcome to the FFmpeg development channel | Questions about using FFmpeg or developing with libav* libs should be asked in #ffmpeg | This channel is publicly logged | FFmpeg 7.0.2 has been released! | Please read ffmpeg.org/developer.html#Code-of-conduct
Kei_N has joined #ffmpeg-devel
arch1t3cht2 has joined #ffmpeg-devel
arch1t3cht has quit [Ping timeout: 248 seconds]
arch1t3cht2 is now known as arch1t3cht
Guest3917 has quit [Ping timeout: 252 seconds]
Son_Goku has quit [Ping timeout: 252 seconds]
jdek has quit [Ping timeout: 252 seconds]
Guest3917 has joined #ffmpeg-devel
Son_Goku has joined #ffmpeg-devel
jdek has joined #ffmpeg-devel
thilo has quit [Ping timeout: 265 seconds]
thilo has joined #ffmpeg-devel
IndecisiveTurtle has quit [Ping timeout: 265 seconds]
Guest3917 is now known as ringo
SuperFashi has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
SuperFashi has joined #ffmpeg-devel
jamrial has quit []
Martchus_ has joined #ffmpeg-devel
Martchus has quit [Ping timeout: 272 seconds]
mkver has quit [Ping timeout: 272 seconds]
Kei_N has quit [Read error: Connection reset by peer]
SystemError has quit [Remote host closed the connection]
SystemError has joined #ffmpeg-devel
feiw2 has joined #ffmpeg-devel
feiw1 has quit [Remote host closed the connection]
ramiro has quit [Ping timeout: 260 seconds]
ramiro has joined #ffmpeg-devel
feiw2 has quit [Remote host closed the connection]
feiw2 has joined #ffmpeg-devel
Krowl has joined #ffmpeg-devel
ngaullier has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
kasper93_ has joined #ffmpeg-devel
kasper93 has quit [Ping timeout: 272 seconds]
Krowl has joined #ffmpeg-devel
IndecisiveTurtle has joined #ffmpeg-devel
ccawley2011 has joined #ffmpeg-devel
<llyyr> elenril: ffmpeg can't decode DV Profile 5 files after 90fc331b0fc6f7d9c31f9e6d543102ba7fe02daf, is that intended?
<llyyr> Sample file is here in case it's needed https://github.com/mpv-player/mpv/issues/14764
j45 has quit [Quit: ZNC 1.8.2 - https://znc.in]
j45 has joined #ffmpeg-devel
j45 has quit [Changing host]
j45 has joined #ffmpeg-devel
nasso has joined #ffmpeg-devel
<nasso> not sure if i should ask this here or in #ffmpeg, but has anyone ever asked for a light theme on the documentation website? i couldn't find any ticket on trac
<nasso> my main concern is accessibility, as it's pretty hard on my eyes to navigate the website in a very bright room
<JEEB> nope, no such requests to my knowledge
<JEEB> web site specific stuff is on the web repo, and then the stuff talking about options etc are actually built off the stuff that also generates man pages :)
<JEEB> llyyr: so NAL unit types 62 and 63 now get ignored?
<nasso> so the change would just need to be on the web repo, right?
<JEEB> or something even worse than thaT?
<JEEB> nasso: I think the main repo builds the HTML for https://www.ffmpeg.org/ffmpeg-all.html for example, so I'm not 100% sure
<llyyr> JEEB: it fails to decode nal type SEI_PREFIX, previously it'd just print a message and continue decoding anyway but now it explicitly fails
<JEEB> SEI_PREFIX... that's surprising
<llyyr> that's what nal_unit_type says at least, is it possible that's wrong?
<JEEB> nah
<JEEB> it should be correct
<JEEB> you can also verify it against `ffmpeg -v verbose -i input -map 0:v -c copy -bsf:v trace_headers -frames:v 5 -f null pipe: 2> trace_headers`
<JEEB> that should output a nice per-NAL listing of units, I'd expect to see the SEI there too
<llyyr> I don't know how to read the output but >Failed to read unit 1 (type 39).
<llyyr> https://0x0.st/Xvjc.txt maybe it makes more sense to you
<quietvoid> fwiw it only fails when reading off the mkv
mkver has joined #ffmpeg-devel
<quietvoid> and there are errors just when demuxing it
<JEEB> llyyr: you can see the Prefix Supplemental Enhancement Information, that's a prefix SEI
<JEEB> then it reads more of it and finds out it's a buffering period SEI
<JEEB> then that refers to SPS id 0
<JEEB> ... which is not available :D
<JEEB> and in that trace_headers output I don't see any SPS (sequence parameter set)
<JEEB> usually it prints both extradata (the stuff in the container initialization data)
<JEEB> and then the packets
<JEEB> so that looks really sus
<JEEB> > Stream #0:0: Video: hevc, 1 reference frame, none, 3840x1920, SAR 1:1 DAR 2:1, 23.98 fps, 23.98 tbr, 1k tbn (default)
<JEEB> this kind of hints that something is off since usually you get the profile from the parameter sets
<JEEB> in this case there's just... none
<JEEB> llyyr: so if you compare to trace headers before, did you get parameter sets?
<llyyr> no, everything is the same.
<llyyr> previously ffmpeg just soldiered through the errors, now after that change it explicitly fails
<JEEB> yeh, but at least we have now verified that we are not missing parameter sets
<nevcairiel> hevc buffering period? i dont even see where that is parsed at all
<JEEB> or have a bug in that bit
<JEEB> nevcairiel: it's a lot of NAL units referring to SPS
<JEEB> the first might just be a SEI of some sort
<nevcairiel> which must be returning something thats not AVERROR_INVALIDDATA?
<JEEB> llyyr: so what seems to be happening is that this mkv file doesn't have anything in the decoder initialization data (or broken data?) and thus the decoder has no parameter sets, and then the stream *also* does not start with a random access point which would contain the parameter sets. if after decoding N frames it succeeded then at some point you should have a parameter set there (if you raise the
<JEEB> number of frames in the trace_headers command it should show up)
<JEEB> let me know if that is the case, which would then more or less confirm my theory
<nevcairiel> from what I'm seeing, any unknown SEI will return FF_H2645_SEI_MESSAGE_UNHANDLED, which decode_nal_unit now sees as a fatal error, maybe special casing that is all thats needed
<nevcairiel> hm or maybe not, its not a negative value
<nevcairiel> error should really get into the habbit of logging what the error code is
<JEEB> yea
<nevcairiel> decode_nal_sei_pic_timing return ENOMEM if the SPS isnt available
<nevcairiel> which seems like a bizarre choice of return value
<JEEB> :D
<nevcairiel> that should just be invaliddata i guess
<nevcairiel> and then it should work again
<JEEB> interesting choice indeed
<JEEB> llyyr: if you have a clone around, try poking at libavcodec/hevc/sei.c::decode_nal_sei_pic_timing's sps check in the beginning that returns ENOMEM atm to AVERROR_INVALIDDATA
<llyyr> works
<nevcairiel> https://pastebin.com/S6ra0xLk i made an easy to apply patch, but iwas too slow :D
<JEEB> llyyr: noice
<JEEB> `git grep -A4 "sps" |grep -C3 ENOMEM` does give a few sus bits but a lot of proper allocation locations
Krowl has quit [Read error: Connection reset by peer]
<llyyr> could you submit the patch so I can just link it in the issue?
ccawley2011 has quit [Quit: Leaving]
<JEEB> yeh, at least there are no other such cases in hevc sei parser
<JEEB> so I think that one could be posted unless FATE fails for some reason
<JEEB> (also this file funnily enough probably would be worth as a FATE sample when cut)
<JEEB> since it's technically bork, but it can be decoded after a while
<JEEB> (I wonder how the heck it got created)
<llyyr> seems like a netflix rip
<nevcairiel> i'll run fate and just send my patch, unless someone else wants to
<JEEB> nevcairiel: cheers, please do
<JEEB> since you have a commit message and all
<JEEB> I have $dayjob :D
<nevcairiel> send
<JEEB> cheers
<nevcairiel> only had to reset my gmail app password, must've gotten invalidated since i used it last :P
IndecisiveTurtle has quit [Ping timeout: 260 seconds]
kasper93 has joined #ffmpeg-devel
SuperFashi has quit [Read error: Connection reset by peer]
SuperFashi has joined #ffmpeg-devel
kasper93_ has quit [Ping timeout: 252 seconds]
SuperFashi has quit [Read error: Connection reset by peer]
SuperFashi has joined #ffmpeg-devel
jamrial has joined #ffmpeg-devel
kasper93_ has joined #ffmpeg-devel
kasper93 has quit [Ping timeout: 252 seconds]
Krowl has joined #ffmpeg-devel
kasper93_ has quit [Ping timeout: 248 seconds]
kasper93 has joined #ffmpeg-devel
feiw1 has joined #ffmpeg-devel
feiw2 has quit [Read error: Connection reset by peer]
SuperFashi has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
ngaullier has quit [Quit: Leaving]
SuperFashi has joined #ffmpeg-devel
ngaullier has joined #ffmpeg-devel
SuperFashi has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
SuperFashi has joined #ffmpeg-devel
feiw1 has quit [Remote host closed the connection]
feiw1 has joined #ffmpeg-devel
IndecisiveTurtle has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
Krowl has joined #ffmpeg-devel
mkver has quit [Ping timeout: 272 seconds]
kasper93 has quit [Ping timeout: 252 seconds]
kasper93 has joined #ffmpeg-devel
kasper93 has quit [Ping timeout: 272 seconds]
rvalue has quit [Read error: Connection reset by peer]
rvalue has joined #ffmpeg-devel
jarthur has joined #ffmpeg-devel
mkver has joined #ffmpeg-devel
kasper93 has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
vipyne has joined #ffmpeg-devel
vipyne has quit [Ping timeout: 260 seconds]
<JEEB> huh, weird
<JEEB> I don't see nevcairiel's patch in my ffmpeg-devel mailbox
<nevcairiel> the archive got it :shrug:
<JEEB> yea
<JEEB> that's why it's weird
* JEEB checks if it's on patchwork
<quietvoid> i got it but it was late
vipyne has joined #ffmpeg-devel
<JEEB> quietvoid: ok, thanks for noting that you also had a delay
<JEEB> I could try doing a LGTM as a manual In-Reply-To from archive
<nevcairiel> email is just a very limited thing, why arent we moving forward on some new workflows
<JEEB> I think at some point I wanted to start a thread on alternatives to move to. personally I'd like videolan's gitlab, but there was a person open to hosting ffmpeg's own until people notice that maintaining a thing is not fun.
<JEEB> then there were some other things and github as the other alternatives. and then there would be some sort of decision
<elenril> Lynne: no special reason
<elenril> just randomly picked a codec with many files
<nevcairiel> i would also be happy to assist with hosting something like gitea/forgejo or our own gitlab, in the time of docker such things arent that much effort anylonger, as long as i'm not ending up being the only person, i would hope hosting wouldnt be the lynchpin in a decision
SystemError has quit [Remote host closed the connection]
zsoltiv_ has quit [Ping timeout: 246 seconds]
feiw2 has joined #ffmpeg-devel
feiw1 has quit [Remote host closed the connection]
<Lynne> I'd be happy to admin a forgejo instance
<wbs> ramiro: btw, on which device do you test A55?
ccawley2011 has joined #ffmpeg-devel
ngaullier has quit [Ping timeout: 246 seconds]
feiw1 has joined #ffmpeg-devel
feiw2 has quit [Ping timeout: 265 seconds]
IndecisiveTurtle has quit [Remote host closed the connection]
IndecisiveTurtle has joined #ffmpeg-devel
SystemError has joined #ffmpeg-devel
_whitelogger has quit [Ping timeout: 252 seconds]
_whitelogger has joined #ffmpeg-devel
jarthur has quit [Ping timeout: 260 seconds]
Sean_McG has quit [Ping timeout: 260 seconds]
kepstin has quit [Ping timeout: 260 seconds]
kepstin has joined #ffmpeg-devel
Sean_McG has joined #ffmpeg-devel
bcheng has quit [Ping timeout: 260 seconds]
bcheng has joined #ffmpeg-devel
<JEEB> apparently I finally got the email at... > Fri, Aug 30, 2024 at 2:20 PM (Delivered after 22784 seconds)
jarthur has joined #ffmpeg-devel
___nick___ has joined #ffmpeg-devel
<Daemon404> there has been some major delay lately
<Daemon404> i think jamrial mentioned it
darkapex_ has quit [Remote host closed the connection]
darkapex_ has joined #ffmpeg-devel
vipyne has joined #ffmpeg-devel
<ramiro> wbs: Orange Pi 5 Plus (rk3588). it has both a55 and a76, so I can easily benchmark both locally.
<wbs> ramiro: ah, I see
<ramiro> wbs: btw the new patch I just sent (deinterleaveBytes) is basically just a copy of interleaveBytes with ld2/st1 instead of ld1/st2. the only place that is a bit different is that I changed zip1 to shrn/xtn.
<wbs> ramiro: ah, nice, that looks reasonsble. I guess the same could be done uzp1/uzp2 too, but it's probably equivalent
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #ffmpeg-devel
<elenril> wow, amerge sure is a giant hack
<jamrial> yeah, i recall that's one of the filters where i had to just assume the layout was native
<elenril> it has way bigger problems, it assumes query_formats is caled exactly once, and in a specific order
HarshK23 has quit [Quit: Connection closed for inactivity]
___nick___ has quit [Ping timeout: 252 seconds]
<courmisch> elenril: you *forgot* to move the arch-stuff into $arch/opus/ tsk tsk tsk
<Lynne> I think its okay the way it is
<kasper93> JEEB: 30 August 2024 at 13:20 (Delivered after 31185 seconds)
<JEEB> yea, quite the queue
SystemError has quit [Remote host closed the connection]
SystemError has joined #ffmpeg-devel
<JEEB> nevcairiel: gave your patch a LGTM
feiw2 has joined #ffmpeg-devel
feiw1 has quit [Read error: Connection reset by peer]
aaabbb has quit [Ping timeout: 272 seconds]
s55 has quit [Quit: ZNC 1.9.0 - https://znc.in]
s55 has joined #ffmpeg-devel
IndecisiveTurtle has quit [Ping timeout: 252 seconds]
aaabbb has joined #ffmpeg-devel
ccawley2011 has quit [Read error: Connection reset by peer]
Traneptora has quit [Ping timeout: 255 seconds]
IndecisiveTurtle has joined #ffmpeg-devel
vipyne has quit [Quit: Leaving.]
<ramiro> I don't know which cores are affected by these commits. it improves for A55, and has no changes for A76. but I don't know if it may negatively impact other cores, and I don't plan on testing older cores.
feiw1 has joined #ffmpeg-devel
feiw2 has quit [Remote host closed the connection]
IndecisiveTurtle has quit [Ping timeout: 272 seconds]
aaabbb has quit [Changing host]
aaabbb has joined #ffmpeg-devel