califax has quit [Remote host closed the connection]
snakedGT has joined #openscad
califax has joined #openscad
teepee_ has joined #openscad
teepee has quit [Ping timeout: 268 seconds]
teepee_ is now known as teepee
<JordanBrown>
teepee Right, I'd squash them out on my end and force-push to my repo before you merge. And yes, I agree that once it's in the main line, it's permanent. (Before that, I believe I can use git rebase to do whatever selective squashing is desirable, though in this case it would be to squash to one commit.)
<JordanBrown>
You know, the raw stuff wasn't that much trouble to add. If somebody wants it in the future, I'll add it again. I'll rip it out for now.
<teepee>
my first thought was using the PRINTD stuff, but I'm not sure that works well
<JordanBrown>
Of course, if you have any review comments, just let me know.
teepee has quit [Ping timeout: 268 seconds]
teepee has joined #openscad
<InPhase>
JordanBrown: On 2021.01 the release, that polyhedron-tests.scad produces "WARNING: Object may not be a valid 2-manifold and may need repair!" on render.
<InPhase>
This might be a terrible test to expect to work right. :)
<InPhase>
Has anyone inspected the details?
<InPhase>
Or, has someone inspected the details and that's why it's not part of the automated tests?
<JordanBrown>
I have not.
<InPhase>
Preview with Thrown Together shows that many faces are inside out in a mixed manne.
<InPhase>
manner
<InPhase>
Which I guess confirms it's a garbage test.
<JordanBrown>
My script that runs tests has a set of exclusions, but I don't remember where that list came from.
<InPhase>
Oh. But in fact, the comments of the source code say "One face flipped" and "More malformed polyhedrons". I think this was on purpose...
<InPhase>
git blame puts this back to 2011 attributed to Kintel, with more added in 2014. I think he was trying to test good handling of defective inputs without crashing.
<JordanBrown>
Testing malformed polyhedra is probably a good idea, but the criterion for success should be "doesn't crash" rather than that it produces any particular results.
<InPhase>
Yes. That's in fact in one of the comments. "don't crash (issue #703)" :)
<JordanBrown>
I can look at it if nobody else wants to, but it might be better for somebody more familiar with the geometry engines to do it.
<InPhase>
fast-cgi actually produces a "better" result it seems, in that its output is closer to what an implementer making all these mistakes probably would have intended. But, no result is specifically required with that many mistakes and issues.
<InPhase>
Well I don't think there's anything to do in the geometry engines. If some method of running the tests is being misleading about this being a valid test, then we should adjust how the testing system reports this.
califax has quit [Remote host closed the connection]
GNUmoon2 has quit [Remote host closed the connection]
fling has quit [Write error: Broken pipe]
TheAssass1n has quit [Remote host closed the connection]
aiyion1 has quit [Write error: Broken pipe]
teepee has quit [Write error: Broken pipe]
TheAssassin has joined #openscad
fling has joined #openscad
califax has joined #openscad
aiyion1 has joined #openscad
GNUmoon2 has joined #openscad
teepee has joined #openscad
ecraven has quit [Ping timeout: 260 seconds]
ecraven has joined #openscad
<JordanBrown>
I will try to remember to take a look at it after I'm done with this font size project.
Scopeuk has quit [Read error: Connection reset by peer]
Scopeuk has joined #openscad
califax has quit [Remote host closed the connection]
califax has joined #openscad
LordOfBikes has quit [Ping timeout: 245 seconds]
califax has quit [Remote host closed the connection]
califax has joined #openscad
LordOfBikes has joined #openscad
Non-ICE has joined #openscad
califax has quit [Remote host closed the connection]
teepee has quit [Remote host closed the connection]
teepee has joined #openscad
<Friithian>
the background to th elinked website for neovim ther eis… ugly
<Friithian>
is there any easy was to round the edges of something quickly? or is this something I need to plan for while constructing it
<JordanBrown>
No, there is no easy way. Easiest (least difficult) is to build things with round edges. Some libraries have modules that will help - e.g. rounded-edge cubes.
<JordanBrown>
There are general ways that involve minkowski(), but they are very slow.
aiyion1 has quit [Remote host closed the connection]
aiyion1 has joined #openscad
qeed_ has joined #openscad
qeed has quit [Ping timeout: 272 seconds]
milza has joined #openscad
milza has quit [Quit: milza]
milza has joined #openscad
peepsalot has joined #openscad
<JordanBrown>
I notice that the project calls itself FreeType (with a capital T), but our files are Freetype (with a lower-case t). Any thoughts on changing our stuff to conform? Mostly I ask so that I don't have to always think about which way to type it...
<teepee>
I don't mind if it's changed, supposedly the github issue with renames is solved