13:16 <discocaml> <kaitrna> hello, i'm using js_of_ocaml and there's a stack overflow in List.map. the github issue [1] suggests we should use a different stdlib, but the map call is deep in library code and it's not something we can easily change. is there some way to patch this stdlib function's js implementation? or any other suggestions?

13:16 <discocaml> <kaitrna>

13:16 <discocaml> <kaitrna> [1]: https://github.com/ocsigen/js_of_ocaml/issues/1072)

13:29 <discocaml> <deepspacejohn> The stdlib List.map is tail-recursive since 5.1, if upgrading OCaml is an option for you.

13:34 <discocaml> <kaitrna> possibly, but a less preferred option

13:57 <discocaml> <limp.biskit> is it your library?

13:58 <discocaml> <limp.biskit> you can monkeypatch map in each file you need it as a temporary solution; you can then vendor those patched versions in dune

14:00 <discocaml> <limp.biskit> or just do a find and replace across your codebase from `List.map` to `CCList.map`

14:01 <companion_cube> Does jsoo even support tail rec modulo cons?

14:07 <Fardale> I was wondering the same and I did not find anything in the manual page of tail rec modulo cons

14:12 <octachron> jsoo starts from bytecode. Since tail rec modulo cons is a lambda transformation pass, it doesn't require any jsoo specific support.

14:21 <Fardale> OK, that was my impression, thanks for the confirmation.

14:50 <companion_cube> oh good

14:50 <companion_cube> it happens before lambda then

15:05 <discocaml> <kaitrna> yes it's my library, but I wouldn't want to rely on a manual find and replace. is there some compiler flag to effect the same thing?

15:18 <discocaml> <leviroth> I suppose that it might be possible to link against a different List module?

15:18 <discocaml> <limp.biskit> no compiler flag but you can redefine List to a new module including Stdlib.List but replacing map with a tail recursive version

15:23 <discocaml> <kaitrna> they sounds possibly reasonable

15:23 <discocaml> <kaitrna> that sounds possibly reasonable

16:47 <discocaml> <limp.biskit> ```ocaml

16:47 <discocaml> <limp.biskit> module List = struct include Stdlib.List;; let map = CCList.map end;;

16:47 <discocaml> <limp.biskit> ```

16:47 <discocaml> <limp.biskit> replace cclist with your own impl if you don't want to link in containers

16:48 <companion_cube> or just copy the 5 lines of code, go for it