14:15 <rockorager> dnkl: I've updated the mode 2032 spec

14:28 <cbb> rockorager: that spec in general seems like a really good idea

14:28 <cbb> I wonder if there are terminals that might want/need to omit the pixel sizes though

14:29 <rockorager> Oh I should add a note for that

14:29 <cbb> from the new unified XTWINOPS 48 sequence I mean

14:29 <rockorager> they must be present but *could* be 0

14:29 <rockorager> actually they could be omitted

14:29 <rockorager> since they are the last ones

14:53 <dnkl> rockorager: great, will update the PR as soon as I have some free time

15:05 <rockorager> cbb: "If a terminal is not capable of omitting pixel sizes, it may omit those fields or report them as 0. A terminal MUST include pixel sizes if it is capable of reporting them."

15:05 <rockorager> lol woops ... "omitting"

15:12 <cbb> rockorager: lgtm… that seems like a sensible way to state the requirements

16:12 <dnkl> rockorager: nit, but might be easier to remember if the private mode more closely matches the response number: 2048. Other than that, it looks good. I can't think of anything else that I'd like to change

16:12 <rockorager> Oh good idea

16:12 <rockorager> I'll change that

16:12 <dnkl> oh, one more thing

16:13 <dnkl> https://gist.github.com/rockorager/e695fb2924d36b2bcf1fff4a3704bd83#reports, here, it says CSI 48

16:13 <dnkl> but in the example you use 4;48

16:14 <dnkl> rockorager: ^^

16:14 <rockorager> fixing that too, thanks

16:14 <rockorager> should be good now

16:16 <rockorager> Ok *now* it's good

16:17 <rockorager> The nice thing is you can almost skip querying for support...

16:17 <rockorager> Just blindly enable, and if you don't get a response you know it's not supported

16:19 <dnkl> just realized; one thing that should be clarified is whether the notifications are sent on font size changes that doesn't change the window size

16:19 <dnkl> think zooming in/out in a tiled window

16:19 <rockorager> Those change the text area size though?

16:20 <rockorager> I will add a note either way

16:20 <dnkl> they do, but at least the title and initial description talk about "window size changes"

16:22 <rockorager> Ok I add an [!IMPORTANT] block in implementation notes about it

16:23 <rockorager> s/add/added

16:24 <dnkl> *now* I think I'm happy 😅

16:47 <rockorager> dnkl: https://github.com/rockorager/libvaxis/commit/edaeb17f3d416b2870032a5a91a82d4b39e4504b

16:47 <rockorager> Gotta do my go version now

17:19 <rockorager> Alright that one is done now too - let me know whenever you get your pr updated and I'll do some testing

17:47 <dnkl> rockorager: done

17:47 <dnkl> closed the original PR and opened https://codeberg.org/dnkl/foot/pulls/1753 instead

17:48 <dnkl> (new branch, as I started over from the beginning)

18:07 <rockorager> works great :)