whitequark[cis] changed the topic of #amaranth-lang to: Amaranth hardware definition language · weekly meetings: Amaranth each Mon 1700 UTC, Amaranth SoC each Fri 1700 UTC · code https://github.com/amaranth-lang · logs https://libera.irclog.whitequark.org/amaranth-lang · Matrix #amaranth-lang:matrix.org
charlottia has quit [Quit: Idle timeout reached: 172800s]
Degi_ has joined #amaranth-lang
Degi has quit [Ping timeout: 260 seconds]
Degi_ is now known as Degi
jjsuperpower has quit [Ping timeout: 255 seconds]
mindw0rk has quit [Quit: ZNC 1.8.2 - https://znc.in]
mindw0rk has joined #amaranth-lang
<_whitenotifier-f> [amaranth-soc] jfng opened pull request #56: Revert "wishbone: restrict addr_width to positive integers." - https://github.com/amaranth-lang/amaranth-soc/pull/56
<_whitenotifier-f> [amaranth-soc] github-merge-queue[bot] created branch gh-readonly-queue/main/pr-56-9ffaf949d853467d32e3e19fc0d472de65e45427 - https://github.com/amaranth-lang/amaranth-soc
<_whitenotifier-f> [amaranth-lang/amaranth-soc] github-merge-queue[bot] pushed 1 commit to main [+0/-0/±2] https://github.com/amaranth-lang/amaranth-soc/compare/9ffaf949d853...2d3d1762d682
<_whitenotifier-f> [amaranth-lang/amaranth-soc] jfng 2d3d176 - Revert "wishbone: restrict addr_width to positive integers."
<_whitenotifier-f> [amaranth-soc] jfng closed pull request #56: Revert "wishbone: restrict addr_width to positive integers." - https://github.com/amaranth-lang/amaranth-soc/pull/56
<_whitenotifier-f> [amaranth-soc] github-merge-queue[bot] deleted branch gh-readonly-queue/main/pr-56-9ffaf949d853467d32e3e19fc0d472de65e45427 - https://github.com/amaranth-lang/amaranth-soc
Guest80 has joined #amaranth-lang
Guest80 has quit [Client Quit]
phire has quit [Quit: No Ping reply in 180 seconds.]
phire has joined #amaranth-lang
DX-MON has quit [Quit: I'm not disconnecting, you're disconnecting!]
DX-MON| has joined #amaranth-lang
alanvgreen has quit [Read error: Connection reset by peer]
alanvgreen has joined #amaranth-lang
lethalbit has quit [Remote host closed the connection]
ebb has quit [Remote host closed the connection]
Ekho has quit [Remote host closed the connection]
lethalbit has joined #amaranth-lang
nyanotech has quit [Quit: No Ping reply in 180 seconds.]
nyanotech has joined #amaranth-lang
ebb has joined #amaranth-lang
Ekho has joined #amaranth-lang
GenTooMan has quit [Ping timeout: 272 seconds]
GenTooMan has joined #amaranth-lang
GenTooMan has quit [Ping timeout: 252 seconds]
GenTooMan has joined #amaranth-lang
korken89[m] has quit [Quit: Idle timeout reached: 172800s]
<cr1901> https://github.com/amaranth-lang/amaranth/blob/main/amaranth/lib/wiring.py#L570 Why does a FlippedInterface delegate to the unflipped Interface when accessing the FlippedInterfaces' Members?
<zyp[m]> because it's possible to define custom methods on an interface, which FlippedInterface has to proxy
<cr1901> Assuming interface object foo has member "bar", it's very weird to me that foo.members["bar"].signature and "foo.bar.signature" return FlippedSignature and Signature respectively
adamgreig[m] has quit [Quit: Idle timeout reached: 172800s]
<zyp[m]> foo.members?
<cr1901> I'm trying to adjust my MCVE, hold on
<zyp[m]> you mean foo.signature.members["bar"] vs foo.bar.signature?
<cr1901> yes
<zyp[m]> hmm, I'd expect those to return the same orientation
<zyp[m]> * you mean foo.signature.members["bar"].signature vs foo.bar.signature?
<zyp[m]> I looked through the code and as far as I see they should both be flipped if necessary
<cr1901> Oh this one is updated
<cr1901> I get a random UUID each time so each paste is different lol
<cr1901> Comment out the first two print statements; the first two of the remaining print statements return Signatures; the last two print statements return FlippedSignature
<cr1901> zyp[m]: I also personally think they should all be flipped, and before a90bc7b they _we're_ all flipped.
<zyp[m]> ah, I see what's happening
<zyp[m]> self.fwd.periph is a FlippedInterface, but __getattr__ doesn't propagate the flipped attribute to subinterfaces
<cr1901> my question is... should it propagate? (And according to the custom methods argument, the answer is "no")
<zyp[m]> it should, the custom methods gets the FlippedInterface proxy as self so they can account for it
<cr1901> Oooooh, yea that makes sense. I think this is a bug then
<zyp[m]> I figure something like this should do it: https://paste.jvnv.net/view/FMhXF
<cr1901> FIXME: Document this logic :P. Yea cool, mind opening the PR and tagging me?
<zyp[m]> I don't think I've put enough thought into this that I'm sure this is correct yet
* cr1901 nods
<cr1901> well, I'm just happy someone besides me think this is weird behavior
<zyp[m]> feel free to submit it as a PR yourself once you believe in it
lf has quit [Ping timeout: 240 seconds]
lf has joined #amaranth-lang