#amaranth-lang on 2023-10-05 — irc logs at libera.irclog.whitequark.org

2023-08-14 23:59 whitequark[cis] changed the topic of #amaranth-lang to: Amaranth hardware definition language · weekly meetings: Amaranth each Mon 1700 UTC, Amaranth SoC each Fri 1700 UTC · code https://github.com/amaranth-lang · logs https://libera.irclog.whitequark.org/amaranth-lang · Matrix #amaranth-lang:matrix.org

00:11 Degi_ has joined #amaranth-lang

00:11 Degi has quit [Ping timeout: 272 seconds]

00:11 Degi_ is now known as Degi

00:45 <_whitenotifier-f> [YoWASP/yosys] whitequark pushed 1 commit to develop [+0/-0/±1] https://github.com/YoWASP/yosys/compare/b9020142de47...034d20dfb03f

00:45 <_whitenotifier-f> [YoWASP/yosys] whitequark 034d20d - Update dependencies.

00:46 <_whitenotifier-f> [rfcs] whitequark commented on pull request #28: Add RFC to allow overriding Value operators - https://github.com/amaranth-lang/rfcs/pull/28#issuecomment-1747860051

01:30 nelgau has quit [Read error: Connection reset by peer]

01:30 nelgau_ has joined #amaranth-lang

01:43 <_whitenotifier-f> [amaranth] whitequark opened pull request #925: build.plat: allow removing `src` attributes from RTLIL output - https://github.com/amaranth-lang/amaranth/pull/925

01:46 <_whitenotifier-f> [amaranth] codecov[bot] commented on pull request #925: build.plat: allow removing `src` attributes from RTLIL output - https://github.com/amaranth-lang/amaranth/pull/925#issuecomment-1747911573

01:51 <_whitenotifier-f> [amaranth-lang/amaranth] github-merge-queue[bot] pushed 1 commit to gh-readonly-queue/main/pr-925-c9416674d1e89b0537870d80588ee34b8cd12097 [+0/-0/±1] https://github.com/amaranth-lang/amaranth/commit/cce4e4462e41

01:51 <_whitenotifier-f> [amaranth-lang/amaranth] whitequark cce4e44 - build.plat: allow removing `src` attributes from RTLIL output.

01:51 <_whitenotifier-f> [amaranth] github-merge-queue[bot] created branch gh-readonly-queue/main/pr-925-c9416674d1e89b0537870d80588ee34b8cd12097 - https://github.com/amaranth-lang/amaranth

01:58 <_whitenotifier-f> [amaranth-lang/amaranth] github-merge-queue[bot] pushed 1 commit to main [+0/-0/±1] https://github.com/amaranth-lang/amaranth/compare/c9416674d1e8...cce4e4462e41

01:58 <_whitenotifier-f> [amaranth-lang/amaranth] whitequark cce4e44 - build.plat: allow removing `src` attributes from RTLIL output.

01:58 <_whitenotifier-f> [amaranth-lang/amaranth] github-merge-queue[bot] deleted branch gh-readonly-queue/main/pr-925-c9416674d1e89b0537870d80588ee34b8cd12097

01:58 <_whitenotifier-f> [amaranth] whitequark closed pull request #925: build.plat: allow removing `src` attributes from RTLIL output - https://github.com/amaranth-lang/amaranth/pull/925

01:58 <_whitenotifier-f> [amaranth] github-merge-queue[bot] deleted branch gh-readonly-queue/main/pr-925-c9416674d1e89b0537870d80588ee34b8cd12097 - https://github.com/amaranth-lang/amaranth

01:59 <_whitenotifier-f> [amaranth-lang/amaranth-lang.github.io] whitequark pushed 1 commit to main [+0/-0/±32] https://github.com/amaranth-lang/amaranth-lang.github.io/compare/87e0e515c26e...dd7f63733cc4

01:59 <_whitenotifier-f> [amaranth-lang/amaranth-lang.github.io] github-merge-queue[bot] dd7f637 - Deploying to main from @ amaranth-lang/amaranth@cce4e4462e41b630bfb1c4f77d431ec39420b650 🚀

02:13 roflincopter has quit [Ping timeout: 272 seconds]

02:17 roflincopter has joined #amaranth-lang

02:55 <cr1901> Okay, I found something very weird... are there any known bugs with the Python simulator for initializing mems?

02:58 <whitequark[cis]> the Python simulation stuff was recently rewritten, it could be related to that

03:01 <cr1901> On one run, the simulator decided to just init some bits to 0 unconditionally in memory. On another run, the init=[] parameter just plain zeroed all entries after the second

03:01 <cr1901> I will see if I can make an MCVE

03:02 <cr1901> FWIW, the generated Verilog is correct

03:02 <cr1901> ignore "On another run, the init=[] parameter just plain zeroed all entries after the second", had the wrong mem open in gtkwave

03:05 <cr1901> My VCDs must've been stable... disregard for now, if I can dup, I'll make an MCVE

03:05 <cr1901> stale*

10:18 <_whitenotifier-f> [amaranth] tilk opened issue #926: Failure of sign-extension for bitwise operations - https://github.com/amaranth-lang/amaranth/issues/926

10:44 Chips4MakersakaS has quit [Quit: Idle timeout reached: 172800s]

10:55 <_whitenotifier-f> [amaranth] whitequark commented on issue #926: Failure of sign-extension for bitwise operations - https://github.com/amaranth-lang/amaranth/issues/926#issuecomment-1748653732

11:04 <_whitenotifier-f> [amaranth] wanda-phi commented on issue #926: Failure of sign-extension for bitwise operations - https://github.com/amaranth-lang/amaranth/issues/926#issuecomment-1748666492

11:15 <_whitenotifier-f> [amaranth] tilk commented on issue #926: Failure of sign-extension for bitwise operations - https://github.com/amaranth-lang/amaranth/issues/926#issuecomment-1748681337

11:16 <Wanda[cis]> ... I'm going to take this one and also fix an unrelated bug (I think)

11:17 <Wanda[cis]> let's just see if it's really a bug

11:19 <Wanda[cis]> okay, to be certain

11:20 <Wanda[cis]> self.sig3 = Signal(32)

11:20 <Wanda[cis]> m.d.comb += self.sig3.eq(Mux(C(1), C(1, 1).as_signed(), C(0)))

11:20 <Wanda[cis]> the result should be sig3 == 0xffffffff, right?

11:24 <galibert[m]> I would agree yes

11:25 <galibert[m]> Then, maybe no

11:25 <galibert[m]> Mux ends up 1-bit wide, but signed or unsigned? The

11:25 <galibert[m]> What happens is you make C(0) signed?

11:27 <Wanda[cis]> heh

11:27 <Wanda[cis]> it works

11:27 <Wanda[cis]> but

11:27 <Wanda[cis]> consider this

11:27 <Wanda[cis]> m.d.comb += self.sig3.eq(Mux(C(1), C(1, 1).as_signed(), C(0, 32).as_signed()))

11:27 <Wanda[cis]> this results in 1, currently

11:55 <_whitenotifier-f> [amaranth] wanda-phi opened pull request #927: sim._pyrtl: fix masking for bitwise operands and muxes. - https://github.com/amaranth-lang/amaranth/pull/927

11:56 <Wanda[cis]> ... okay took me a moment to figure out how to test this

11:59 <_whitenotifier-f> [amaranth] codecov[bot] commented on pull request #927: sim._pyrtl: fix masking for bitwise operands and muxes. - https://github.com/amaranth-lang/amaranth/pull/927#issuecomment-1748742192

12:27 <_whitenotifier-f> [amaranth-lang/amaranth] github-merge-queue[bot] pushed 1 commit to gh-readonly-queue/main/pr-927-cce4e4462e41b630bfb1c4f77d431ec39420b650 [+0/-0/±2] https://github.com/amaranth-lang/amaranth/commit/ccf7aaf00db5

12:27 <_whitenotifier-f> [amaranth-lang/amaranth] wanda-phi ccf7aaf - sim._pyrtl: fix masking for bitwise operands and muxes.

12:27 <_whitenotifier-f> [amaranth] github-merge-queue[bot] created branch gh-readonly-queue/main/pr-927-cce4e4462e41b630bfb1c4f77d431ec39420b650 - https://github.com/amaranth-lang/amaranth

12:36 <_whitenotifier-f> [amaranth-lang/amaranth] github-merge-queue[bot] pushed 1 commit to main [+0/-0/±2] https://github.com/amaranth-lang/amaranth/compare/cce4e4462e41...ccf7aaf00db5

12:36 <_whitenotifier-f> [amaranth-lang/amaranth] wanda-phi ccf7aaf - sim._pyrtl: fix masking for bitwise operands and muxes.

12:36 <_whitenotifier-f> [amaranth-lang/amaranth] github-merge-queue[bot] deleted branch gh-readonly-queue/main/pr-927-cce4e4462e41b630bfb1c4f77d431ec39420b650

12:36 <_whitenotifier-f> [amaranth] whitequark closed pull request #927: sim._pyrtl: fix masking for bitwise operands and muxes. - https://github.com/amaranth-lang/amaranth/pull/927

12:36 <_whitenotifier-f> [amaranth] github-merge-queue[bot] deleted branch gh-readonly-queue/main/pr-927-cce4e4462e41b630bfb1c4f77d431ec39420b650 - https://github.com/amaranth-lang/amaranth

12:36 <_whitenotifier-f> [amaranth] whitequark closed issue #926: Failure of sign-extension for bitwise operations - https://github.com/amaranth-lang/amaranth/issues/926

12:38 <_whitenotifier-f> [amaranth-lang/amaranth-lang.github.io] whitequark pushed 1 commit to main [+0/-0/±32] https://github.com/amaranth-lang/amaranth-lang.github.io/compare/dd7f63733cc4...6c92efff567c

12:38 <_whitenotifier-f> [amaranth-lang/amaranth-lang.github.io] github-merge-queue[bot] 6c92eff - Deploying to main from @ amaranth-lang/amaranth@ccf7aaf00db54c7647b2f0f0cfdf34835c16fa8f 🚀

13:13 crzwdjk has quit [Ping timeout: 240 seconds]

13:15 MarekMaterzok[m] has joined #amaranth-lang

13:15 <MarekMaterzok[m]> Thanks for the fix - our unit tests are now passing on the current Amaranth version.

13:20 crzwdjk has joined #amaranth-lang

13:43 jfng[m] has joined #amaranth-lang

13:43 <jfng[m]> what's the rationale for having `isinstance(MySignature().flip(), MySignature)` return True, but not `iface = Interface(MySignature(), ...); isinstance(flipped(iface), Interface)` ?

13:45 <jfng[m]> also, is Interface even part of the public lib.wiring API ? it is not present in __all__

13:57 <whitequark[cis]> <jfng[m]> "what's the rationale for having..." <- IIRC it wasn't feasible for a technical reason; I will need to revisit it and write an extended comment detailing why

13:58 <whitequark[cis]> I think it's because I didn't want to add a metaclass to Interface / interface objects not being necessarily derived from that

13:58 <whitequark[cis]> <jfng[m]> "also, is Interface even part..." <- that is an oversight

14:02 <_whitenotifier-f> [amaranth] jfng opened pull request #928: lib.wiring: add Interface to __all__. - https://github.com/amaranth-lang/amaranth/pull/928

14:04 <jfng[m]> <whitequark[cis]> "I think it's because I didn't..." <- got it, i should be able to get away with some if..else boilerplate as a workaround

14:05 <whitequark[cis]> ideally we would revisit/reconsider this

14:06 <_whitenotifier-f> [amaranth] codecov[bot] commented on pull request #928: lib.wiring: add Interface to __all__. - https://github.com/amaranth-lang/amaranth/pull/928#issuecomment-1748974964

14:11 <_whitenotifier-f> [amaranth-lang/amaranth] github-merge-queue[bot] pushed 1 commit to gh-readonly-queue/main/pr-928-ccf7aaf00db54c7647b2f0f0cfdf34835c16fa8f [+0/-0/±1] https://github.com/amaranth-lang/amaranth/commit/c7da6c1292ea

14:11 <_whitenotifier-f> [amaranth-lang/amaranth] jfng c7da6c1 - lib.wiring: add Interface to __all__.

14:12 <_whitenotifier-f> [amaranth] github-merge-queue[bot] created branch gh-readonly-queue/main/pr-928-ccf7aaf00db54c7647b2f0f0cfdf34835c16fa8f - https://github.com/amaranth-lang/amaranth

14:20 <_whitenotifier-f> [amaranth-lang/amaranth] github-merge-queue[bot] pushed 1 commit to main [+0/-0/±1] https://github.com/amaranth-lang/amaranth/compare/ccf7aaf00db5...c7da6c1292ea

14:20 <_whitenotifier-f> [amaranth-lang/amaranth] jfng c7da6c1 - lib.wiring: add Interface to __all__.

14:20 <_whitenotifier-f> [amaranth-lang/amaranth] github-merge-queue[bot] deleted branch gh-readonly-queue/main/pr-928-ccf7aaf00db54c7647b2f0f0cfdf34835c16fa8f

14:20 <_whitenotifier-f> [amaranth] whitequark closed pull request #928: lib.wiring: add Interface to __all__. - https://github.com/amaranth-lang/amaranth/pull/928

14:20 <_whitenotifier-f> [amaranth] github-merge-queue[bot] deleted branch gh-readonly-queue/main/pr-928-ccf7aaf00db54c7647b2f0f0cfdf34835c16fa8f - https://github.com/amaranth-lang/amaranth

14:22 <_whitenotifier-f> [amaranth-lang/amaranth-lang.github.io] whitequark pushed 1 commit to main [+0/-0/±32] https://github.com/amaranth-lang/amaranth-lang.github.io/compare/6c92efff567c...e87d4d6387af

14:23 <_whitenotifier-f> [amaranth-lang/amaranth-lang.github.io] github-merge-queue[bot] e87d4d6 - Deploying to main from @ amaranth-lang/amaranth@c7da6c1292ea60a612ee9fd0f75d603485939580 🚀

15:44 notgull has quit [Ping timeout: 260 seconds]

15:47 GenTooMan has quit [Ping timeout: 272 seconds]

15:48 notgull has joined #amaranth-lang

16:00 GenTooMan has joined #amaranth-lang

16:21 phire has quit [Quit: No Ping reply in 180 seconds.]

16:23 phire has joined #amaranth-lang

17:59 SpaceCoaster has quit [Quit: Bye]

18:00 SpaceCoaster has joined #amaranth-lang

18:13 mcc111[m] has quit [Quit: Idle timeout reached: 172800s]

19:29 <_whitenotifier-f> [amaranth] zyp opened pull request #929: ast: allow overriding Value operators. - https://github.com/amaranth-lang/amaranth/pull/929

19:58 <_whitenotifier-f> [amaranth] wanda-phi reviewed pull request #929 commit - https://github.com/amaranth-lang/amaranth/pull/929#discussion_r1347908053

20:04 <_whitenotifier-f> [amaranth] zyp reviewed pull request #929 commit - https://github.com/amaranth-lang/amaranth/pull/929#discussion_r1347913067

20:57 richlatticefae[m has quit [Quit: Idle timeout reached: 172800s]

21:01 bob_twinkles[m] has quit [Quit: Idle timeout reached: 172800s]

21:41 Psentee has quit [Quit: Off]

21:42 Psentee has joined #amaranth-lang

21:42 Psentee has quit [Client Quit]

21:44 Psentee has joined #amaranth-lang

22:15 pie_ has quit []

22:15 pie_ has joined #amaranth-lang

22:51 <_whitenotifier-f> [amaranth] whitequark reviewed pull request #929 commit - https://github.com/amaranth-lang/amaranth/pull/929#discussion_r1348079000

22:56 agg has quit [Ping timeout: 272 seconds]

22:56 roflincopter has quit [Ping timeout: 272 seconds]

22:57 agg has joined #amaranth-lang

22:58 roflincopter has joined #amaranth-lang

23:14 <_whitenotifier-f> [amaranth] zyp reviewed pull request #929 commit - https://github.com/amaranth-lang/amaranth/pull/929#discussion_r1348090923

23:18 <_whitenotifier-f> [amaranth] whitequark reviewed pull request #929 commit - https://github.com/amaranth-lang/amaranth/pull/929#discussion_r1348092414

23:19 <_whitenotifier-f> [amaranth] whitequark reviewed pull request #929 commit - https://github.com/amaranth-lang/amaranth/pull/929#discussion_r1348092946

23:20 <_whitenotifier-f> [amaranth] zyp reviewed pull request #929 commit - https://github.com/amaranth-lang/amaranth/pull/929#discussion_r1348093414

23:22 lf has quit [Ping timeout: 260 seconds]

23:22 lf has joined #amaranth-lang

23:29 <_whitenotifier-f> [amaranth] whitequark reviewed pull request #929 commit - https://github.com/amaranth-lang/amaranth/pull/929#discussion_r1348101436

23:46 jjsuperpower has joined #amaranth-lang