11:29 <azonenberg> Soooo that refactoring was easier than i thought

11:29 <azonenberg> i forgot that the stream index field in StreamDescriptor defaults to zero

11:29 <azonenberg> literally i had to do was change that one line, the function that pops the vector, and recompile all the drivers without changing any code in them

11:31 <_whitenotifier-7> [scopehal] azonenberg pushed 1 commit to master [+0/-0/±2] https://github.com/azonenberg/scopehal/compare/ea5b7147996d...b8a36c0448c8

11:31 <_whitenotifier-7> [scopehal] azonenberg b8a36c0 - Oscilloscope: SequenceSet now takes a StreamDescriptor so we can have more than one stream on a scope channel

12:20 <azonenberg> So now trying to figure out how to handle s-parameter channels a bit more cleanly

12:20 <azonenberg> more specifically, the fact that s-params are normally log mag / degree angles for display

12:20 <azonenberg> but need to be linear mag / radian angles for math processing

12:22 <azonenberg> The current TouchstoneImportFilter has a method GetParams() which returns the actual internal s-parameters

12:23 <azonenberg> and DeEmbedFilter, the sole user of the s-params, ignores the actual mag/angle waveforms you give it

12:23 <azonenberg> and casts the source object to TouchstoneImportFilter* and calls that method

12:23 <azonenberg> Which is, to say the least, an ugly strategy

12:24 <azonenberg> I could easily change DeEmbedFilter to actually use the raw mag/angle inputs but then i would need to do a lot of trig and rescaling every update

12:24 <azonenberg> which would hurt performance

12:35 <azonenberg> also the other issue to consider is that i might at some point want to do math operations on the s-params

12:36 <azonenberg> For now i think i'll remove the fast path and actually use the db/degree data, converting as needed

12:36 <azonenberg> imports and VNA sweeps don't change nearly as fast as scope waveforms so the cost of rescaling is minimal

12:36 <azonenberg> and this is a more clean, unified approach that works with data from any source

13:08 <_whitenotifier-7> [scopehal] azonenberg pushed 1 commit to master [+0/-0/±4] https://github.com/azonenberg/scopehal/compare/b8a36c0448c8...b34877ffd42b

13:08 <_whitenotifier-7> [scopehal] azonenberg b34877f - SParameters: can now construct an SParameterVector from an AnalogChannel pair containing dB mag and degree angle data

13:24 <_whitenotifier-7> [scopehal] azonenberg pushed 4 commits to master [+0/-0/±5] https://github.com/azonenberg/scopehal/compare/b34877ffd42b...99e3aa6d86a2

13:24 <_whitenotifier-7> [scopehal] azonenberg dbeeee2 - MockOscillosope: Touchstone imports are not physical channels

13:25 <_whitenotifier-7> [scopehal] azonenberg d418395 - SParameters: fixed SParameterVector constructor for non-dense-packed waveforms

13:25 <_whitenotifier-7> [scopehal] azonenberg 1e0b113 - DeEmbedFilter: fixed group delay calculation not using cached S-parameters

13:25 <_whitenotifier-7> [scopehal] azonenberg 99e3aa6 - Added comment to SParameterVector constructor

13:44 <_whitenotifier-7> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/azonenberg/scopehal-apps/compare/4aa5f959c3dc...e4ff1eb73201

13:44 <_whitenotifier-7> [scopehal-apps] azonenberg e4ff1eb - Updated submodules

14:58 <_whitenotifier-7> [scopehal] danielkucera opened issue #538: Range cannot be changed using touchpad - https://github.com/azonenberg/scopehal/issues/538

14:58 <_whitenotifier-7> [scopehal] danielkucera closed issue #538: Range cannot be changed using touchpad - https://github.com/azonenberg/scopehal/issues/538

14:58 <_whitenotifier-7> [scopehal] danielkucera commented on issue #538: Range cannot be changed using touchpad - https://github.com/azonenberg/scopehal/issues/538#issuecomment-1019502257

14:59 <_whitenotifier-7> [scopehal-apps] danielkucera opened issue #402: Range cannot be changed using touchpad - https://github.com/azonenberg/scopehal-apps/issues/402

15:45 <_whitenotifier-7> [scopehal] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/azonenberg/scopehal/compare/99e3aa6d86a2...c09b084510d8

15:45 <_whitenotifier-7> [scopehal] azonenberg c09b084 - FlowGraphNode: added GetXAxisUnits()

15:45 <_whitenotifier-7> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±5] https://github.com/azonenberg/scopehal-apps/compare/e4ff1eb73201...85849b1ff454

15:45 <_whitenotifier-7> [scopehal-apps] azonenberg 85849b1 - OscilloscopeWindow::OnAddChannel() makes sure to pick a compatible group, creating one if needed