03:48 <leviathan> I have roughly implemented the input-method-v2 popups feature and completed testing on my device.

03:48 <leviathan> This is my first time contributing code to open-source software, and I am a novice in both Zig and wlroots, which may lead to many formatting issues or other less obvious errors in the code.

03:50 <leviathan> I have submitted a PR and conducted testing using fcitx5.

04:46 <NickH> levi

04:48 <NickH> leviathan: I just built your fork and am running it now.

04:48 <NickH> Only just started playing with it, but it seems to work

04:55 <leviathan> NickH: Thanks a lot for your interest. If you encounter any issues during execution, please don't hesitate to let me know right away.

04:56 <NickH> I'm only an occasionnal user of fcitx5 so I expect the testing your have already done would be more likely to find issues

04:57 <NickH> But I'll let you know if I notice anything

04:58 <leviathan> Thanks a lot! :)

06:25 <leon-p> wow, the review interface on codeberg is so much more responsive then the github one

06:25 <leon-p> it's not even funny anymore, the difference is insane

07:03 <tiosgz> hah, nice work on this! i'm also just a casual user of an input method, but gotta test it :)

07:04 <tiosgz> also glad that leon-p has made most of the nitpicking comments that i'd otherwise make :P

07:05 <leon-p> I made all of the "I haven't actually read the protocol myself yet" comments :]

07:10 <leviathan> Thank you very much for your review. It seems I should set this PR to WIP, shouldn't I?

07:10 <leviathan> In addition to your commit, I've also identified some other functional issues.

07:10 <leviathan> It might take some time to fix.

07:13 <NickH> I noticed that the popup location is mostely off the bottom of the screen if on the bottom line of a terminal.

07:15 <vyivel> probably needs unconstraining

07:18 <tiosgz> leon-p: well i think we've flooded the pr with too much review? (neither have i read the protocol, heh)

07:19 <leon-p> everyones inbox will be full :)

07:19 <leviathan> NickH:  That's exactly the issue I'm talking about. I might need some time to fix this problem.

07:20 <NickH> I don't remember how the position worked for those pop-ups back when I as on X11...

07:20 <leon-p> leviathan: it's your code, so take all the time you need. this is unpaid volunteer labour after all

09:04 <leviathan> I need your input on what the boundaries for the popup window should be and what the expected behavior is when it goes out of bounds.

09:04 <leviathan> tiosgz

09:04 <leviathan> leon-p

09:04 <leviathan> ifreund

09:06 <leviathan> I'm currently considering two options: one is to use the current window as the boundary, and the other is to use the current view as the boundary. I'm not sure which one to choose.

09:06 <leviathan> It seems this is not related to functionality implementation but rather a matter of personal preference.

09:07 <leviathan> NickH: also thank you for pointing out this issue. Do you have any insights on it?

09:07 <leon-p> view == window

09:07 <leon-p> == toplevel

09:08 <leon-p> you could also use the output as boundry and allow some overflow, as f.e. with xdg-popups

09:10 <leviathan> Perhaps I wasn't clear in my description. For instance, I have multiple instances of the 'foot' client open on one monitor, and I refer to each instance's display area as a 'window'. How should this be properly described?

09:10 <leon-p> window is fine, river internally uses view, the xdg-shell protocol calls it toplevel

09:10 <leviathan> In the code, this concept seems to be referred to as an 'output_box'.

09:11 <leon-p> I think that's something else

09:11 <tiosgz> "output" is the same as screen/monitor/display/what other names exist

09:12 <leon-p> (well, output is the logical object backing physical screens but can also do other things)

09:12 <leon-p> leviathan: what you probably want is the view size and position, that is not called window

09:13 <leon-p> but if you attach the popup scene tree to the views scene tree, you don't actually need the position

09:14 <tiosgz> well it may be needed if the popup is to be within the output

09:15 <leon-p> true

09:16 <leon-p> this kind of elastic positioning is indeed annoying. maybe it can share code with the positioning stuff from the xdg-shell impl

09:16 <leon-p> not sure if wlroots exposes any of that though

09:19 <leon-p> i think for now constraining to the view instead of the output is fine, that can always be changed later

11:05 <ifreund> yeah, iirc I looked at this briefly and decided that wlroots should expose a more flexible helper for positioning popups that works for more than xdg popups

11:06 <ifreund> in a train on my way back home today, probably won't do any code review till tomorrow though :)

17:43 <rdbo> ifreund, i think i may have found an issue. i tried to figure it out/try to fix it, but i didn't understand why this happens. basically, doing `send-layout-cmd rivertile "main-count -1"` *seems* to go below 0 (it takes many 'main-count +1's to get back to the original state, even though there are 0 main windows). but i checked the source code, and the `main_count` variable in `output` is defined as

17:43 <rdbo> `u31` so i don't know what's going on

17:44 <rdbo> i could also be misunderstanding how the main-count works

17:46 <rdbo> oh wait, never mind

17:46 <rdbo> i found an issue in my config

17:46 <rdbo> oops, sorry

19:53 <catman> i'm using riverctl rule-add -app-id "firefox" ssd and riverctl rule-add -app-id "thunar" ssd per wiki but still not getting borders on either app. am i missing something?

20:25 <rdbo> catman, if you are on 0.2.6, i think that rule-add doesn't exist yet

20:26 <rdbo> i'm not sure what the old command would be though

21:07 <catman> i am on 0.3.0-dev.207+f0b0606 from the arch aur

21:30 <catman> ok cool.. i was able to get borders around firefox and thunar with riverctl rule-add -app-id "*" ssd

22:28 <rdbo> anybody knows how i can make popups always go on top?

22:28 <rdbo> sometimes an app shows a popup, but i move the mouse to the main window (i have focus always on mouse window), and that makes the popup go behind the window

22:30 <rdbo> i wanted to still focus always on mouse, but except the popups

23:07 <waleee> rdbo: is the popups in firefox?

23:08 <waleee> (as in download dialogs etc etc, not actual web popups)

23:35 <rdbo> well, any sort of popups, really. like confirmation boxes with cancel/ok