snakedye has quit [Read error: Connection reset by peer]
snakedye has joined #river
mon_aaraj has quit [Quit: WeeChat 3.4]
mon_aaraj has joined #river
Evo2 has quit [Ping timeout: 250 seconds]
waleee has quit [Ping timeout: 245 seconds]
Evo2 has joined #river
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
notzmv has quit [Ping timeout: 260 seconds]
snakedye has quit [Ping timeout: 250 seconds]
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
notzmv has joined #river
kraem_ has quit [Ping timeout: 268 seconds]
Snektron[m] has quit [Ping timeout: 268 seconds]
bfiedler has quit [Ping timeout: 268 seconds]
kraem_ has joined #river
bfiedler has joined #river
Snektron[m] has joined #river
MariaSmith has joined #river
MariaSmith has left #river [#river]
notzmv has quit [Ping timeout: 250 seconds]
dimaom has joined #river
snakedye has joined #river
dimaom has quit [Quit: Leaving.]
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
notzmv has joined #river
mon_aaraj has quit [Ping timeout: 256 seconds]
waleee has joined #river
adelaide has joined #river
adelaide has quit [Remote host closed the connection]
<ifreund>
novakane: I may have messed up the depends line... depends="pam-base>=0.4.0_2"
Danacus has joined #river
<ifreund>
instead of 0.4_2 :/
nani8ot[m] has joined #river
<ifreund>
leon-p: sounds like a good idea to me, I was actually wishing I made it GPLv2 only recently, I didn't realize I could easily switch to v3 only though that's nice
<ifreund>
I'll plan on doing that before releasing 0.1.3 unless anyone has objections
<leon-p>
ifreund: the switching to GPLv3-only works because you can include GPLv3-or-later code into GPLv3-only projects, so basically you include old river in new river, which uses GPLv3-only
<ifreund>
Yeah it makes sense to me, just hadn't clicked last time I thought about this
Guest65dsadsadsa has joined #river
Guest65dsadsadsa has quit [Client Quit]
<novakane>
ifreund: ah yeah it's probably that, wasn't too bad for me but for someone who never used it, it could be annoying
<ifreund>
novakane: #xbps tells me it's fine
<novakane>
allright then, it just didn't change pam-base on my system I guess
Fr0stBit has joined #river
<Fr0stBit>
Hello!
<ifreund>
o7
<Fr0stBit>
ifreund: I'm here to say a big thank you! I am trying to jump from X11 to Wayland world and river is the closest to bspwm when it comes to flexibility, so I'll probably stick with it for some years if everything goes well!
<ifreund>
glad it's useful to you :)
<Fr0stBit>
I would like to make kind request though: I still find annoying the gtk titlebars (that is gtk's fault for not implementing xdg-decoration)
<Fr0stBit>
The PR seems to be stuck after some (minor) comments, is there any change that this goes through?
<ifreund>
Yeah, I lost interest in working on that patch
<Fr0stBit>
Ah I see
<ifreund>
There are more than just minor issues with the GTK side of that code iirc
<ifreund>
the GDK side is solid though if anyone wants to pick it up
<Fr0stBit>
I wish I had the knowledge to do this but I would need to learn some serious gtk first
<Fr0stBit>
I suppose sway implements it into the compositor side?
<ifreund>
sway implments an obsolete KDE specific protocol
<Fr0stBit>
Is it in wlroots, or it is in sway itself?
<ifreund>
both
<Fr0stBit>
I agree with you on not implementing any non-standard protocol it in river, but I don't have any hope either for gtk maintainers implementing xdg-decoration too
<Fr0stBit>
I see that most of the MR comments are cosmetic changes, I guess I could pick them up
<Fr0stBit>
Is there anything that is problematic that I should check out aside these?
<ifreund>
Fr0stBit: try toggling CSD/SSD and back a few times at runtime
<ifreund>
you can use riverctl csd-filter-add/csd-filter-remove
<Fr0stBit>
ifreund: ok I'll rebase your patch and run some gtk example locally to test this
<Fr0stBit>
I'll report back if I find anything / manage to solve this!
<ifreund>
cool! It would be very nice to get that merged
<ifreund>
I can help with anything wayland/river related but am pretty clueless about GTK internals
<Fr0stBit>
I'm pretty clueless about gtk / wayland in general, but i'll try to make it
<Fr0stBit>
gotta go, see you soon!
Fr0stBit has quit [Quit: WeeChat 3.4]
gwizon has joined #river
gwizon has quit [Client Quit]
gwizon has joined #river
gwizon has quit [Ping timeout: 256 seconds]
snakedye has quit [Ping timeout: 256 seconds]
gwizon has joined #river
norkki has quit [Ping timeout: 268 seconds]
mon_aaraj has joined #river
norkki has joined #river
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
Fr0stBit has joined #river
mon_aaraj has quit [Ping timeout: 268 seconds]
<Fr0stBit>
ifreund: Just cloned and rebased your branch to latest GNOME:gtk-3-24
<Fr0stBit>
I run a build, all compiles good so far, and I'm trying play around with the examples
<ifreund>
pattern just means the exact string matching the app-id of the client currently
<Fr0stBit>
ifreund: Ok I just toggled csd in an example window multiple times with no issues :(
<Fr0stBit>
Do you remember exactly what was the problem?
<ifreund>
Fr0stBit: did anything actually change? This is only supposed to affect programs that don't create a custom title bar thing
<ifreund>
e.g. zathura or firefox
<Fr0stBit>
ifreund: I tested it with both the hello-world and plugman gtk examples
<Fr0stBit>
toggled csd with riverctl multipletimes, everything worked snappy as it should
<tiosgz`>
ifreund: huh, i thought it was also supposed to remove the superfluous buttons/title from custom titlebars?
<Fr0stBit>
ifreund: is there a way to test this without recompiling firefox? somekind of ld preload or other trick?
<ifreund>
tiosgz`: nope, gtk maintainers definitely wouldn't merge that and for fairly good reason. The gtk program can put special functionality in the titlebar that would be othewise inaccessible
<ifreund>
Fr0stBit: setting LD_PRELOAD to include the directory containing your patched gtk .so files should do it
<Fr0stBit>
ifreund: Just tested it on firefox, toggled csd multiple times again, it works as it should!
<ifreund>
Fr0stBit: here's what I mean by a non-custom gtk3 title bar https://0x0.st/oHOZ.png
<ifreund>
are you seeing that toggle properly on firefox?
<ifreund>
Maybe things are working better than I remembered
<Fr0stBit>
titlebar hides and shows completely in firefox, let me test it on zathura
<ifreund>
would be worth testing starting the client in both CSD and SSD states too
<Fr0stBit>
ifreund: Seems that zathura ignores the patch :(
<Fr0stBit>
zathura shows titlebar no matter what
<Fr0stBit>
ifreund: hmm I think I found another bug: if I add csd filter for firefox, start firefox, close firefox, remove csd filter, and start firefox again, I get gdk_wayland_window_configure height > 0 assertion
<ifreund>
Yeah, I seem to recall seeing firefox crash on something like that
<Fr0stBit>
Do you want me to push it in some remote branch to at least resolve these little things?
<ifreund>
Fr0stBit: Feel free to do whatever you want with my patches, they're open source under gtk's license. I don't currently have any plans on touching that MR again.
<Fr0stBit>
ifreund: I'm wondering, is there a particular reason you kinda seem to hate gtk? (Appart from that horrific coding style)
<ifreund>
I don't hate gtk
<Fr0stBit>
You just don't see any value in this MR?
<ifreund>
I just have a million other things I find more valuable to spend my time on currently though
<Fr0stBit>
Fair enough
<ifreund>
I don't thing that fixing this would be useless, I just have other things I find more important currently
<ifreund>
I will also admit that I don
<ifreund>
*don't enjoy working with gtk code
<Fr0stBit>
Yeah that seems very reasonable. I'll try to dig deeper into your patch and try to make these two cases work (zathura / firefox) on my spare time
<Fr0stBit>
The window decorations is actually one of the things that are keeping me from switching full time on wayland/river
<Fr0stBit>
The other is the slight blurring that I get with fractional scaling on fonts :(
<ifreund>
fwiw, firefox has its own setting to disable them
norkki has quit [Ping timeout: 256 seconds]
<ifreund>
I can't recommend fractional scaling tbh
<Fr0stBit>
I don't get why Xft.dpi: 168 (equivalent of scale 1.75) is crispy clean on Xorg but fractional scaling on wayland shows a slight blurring
<tiosgz`>
fwiw i've been using `export GTK_CSD=0` (dunno if that has any effect) and a piece of css to get rid of most(?) csd
<Fr0stBit>
Multi-monitor hidpi in Linux is years behind and that makes me sad :( My 16" laptop is 2.5K and needs a scaling factor of 1.75 and my external 24" monitor is also 2.5k and needs 1.25 scaling factor to show everything as it should
<Fr0stBit>
tiosgz`: Mind sharing the css?
<ifreund>
tiosgz`: oh? iirc GTK_CSD has no effect on wayland
<tiosgz`>
ifreund: yeah i thought so. but i'm afraid to remove it
<tiosgz`>
Fr0stBit: just a min
<Fr0stBit>
tiosgz`: Yeah, just tried it, no effect
<Fr0stBit>
tiosgz`: Almost works, leaves a part of the title bar, about 0.5em
<tiosgz`>
just play with the values, my theme's titlebar is quite small
<tiosgz`>
`GTK_DEBUG=interactive some-app` to test it live
snakedye has joined #river
<Fr0stBit>
ifreund: Another question about river: How does riverctl spawn work? I export some env vars in .config/river/init but they do not have any effect when launching anything with riverctl spawn
<ifreund>
Fr0stBit: programs are run with river's environment + WAYLAND_DISPLAY set
<ifreund>
you may want to start river with a wrapper script that sets some environment variables
<Fr0stBit>
ah ok
<ifreund>
tiosgz`: neat! Looks like I need to find the right css selector to delete the close button for my gtk theme (whatever the default is)
snakedye has quit [Read error: Connection reset by peer]
<tiosgz`>
ifreund: or gsettings set org.gnome.desktop.wm.preferences button-layout 'appmenu:'
<tiosgz`>
that's what i have
Fr0stBit is now known as agorglouk
<tiosgz`>
actually "appmenu" seems not to be supported
snakedye has joined #river
agorglouk is now known as ElArtista
ElArtista is now known as agorgl
norkki has joined #river
agorgl has quit [Quit: WeeChat 3.4]
<ifreund>
tiosgz`: I managed to hide the button with CSS, but then things crashed when I changed something (not sure what) in the CSS
<ifreund>
anyhow, that's enough time put into this for now, I'll just go back to avoiding using programs where I have to look at ugly titlebars xD
<tiosgz`>
:D
<tiosgz`>
i think that the gsettings trick should work
<ifreund>
thanks for the GTK_DEBUG=interactive tip, that's super neat
<ifreund>
tiosgz`: I just rebased the session-lock branch and included the fix to not modify output focus while locked by the way
<tiosgz`>
i have noticed that, thanks!
snakedye has quit [Read error: Connection reset by peer]
snakedye has joined #river
gwizon has quit [Ping timeout: 268 seconds]
mon_aaraj has joined #river
notzmv has quit [Ping timeout: 268 seconds]
groknull has joined #river
groknull has quit [Remote host closed the connection]