ifreund changed the topic of #river to: river - a dynamic tiling wayland compositor || https://github.com/riverwm/river || channel logs: https://libera.irclog.whitequark.org/river/
gwizon has quit [Ping timeout: 240 seconds]
groknull has joined #river
groknull has quit [Remote host closed the connection]
groknull has joined #river
groknull has quit [Remote host closed the connection]
Guest6 has joined #river
Guest6 has quit [Client Quit]
groknull has joined #river
groknull has quit [Remote host closed the connection]
waleee has quit [Ping timeout: 250 seconds]
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
mon_aaraj has quit [Ping timeout: 240 seconds]
mon_aaraj has joined #river
snakedye has quit [Ping timeout: 240 seconds]
mon_aaraj has quit [Ping timeout: 240 seconds]
mon_aaraj has joined #river
mon_aaraj has quit [Ping timeout: 250 seconds]
mon_aaraj has joined #river
mon_aaraj has quit [Ping timeout: 250 seconds]
mon_aaraj has joined #river
snakedye has joined #river
Guest58 has joined #river
Guest58 has quit [Client Quit]
mon_aaraj has quit [Ping timeout: 240 seconds]
mon_aaraj has joined #river
<ifreund> leon-p: I can reproduce one weird cursor thing on startup that goes away as soon as I move my mouse: I see a second cursor with the wrong orientation on my second 90 degree transformed monitor
<ifreund> it doesn't happen on river 0.1.0/wlroots 0.14.1
<ifreund> I can't reproduce any other cursor weirdness on startup
<ifreund> do you think this is worth delaying 0.1.3 to investigate? if not I'll probably tag that this weekend. A fair number of bugfixes have collected since 0.1.2
<leon-p> ifreund: I might have time today to investigate, if not I don't think its worth delaying 0.1.3 for though
<ifreund> cool
<novakane> oh yeah I use shortlog from 0.1.2, didn't thought there was already so many fixes
groknull has joined #river
groknull has quit [Remote host closed the connection]
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
groknull has joined #river
groknull has quit [Remote host closed the connection]
elshize has quit [Ping timeout: 240 seconds]
elshize has joined #river
<leon-p> ifreund: fixed it: https://github.com/riverwm/river/pull/520
<leon-p> also 519 seems worth investigating. I encountered issues that appeared similar whenever I touched cursor code. We probably have a few different places where view size is stored and they may get out of sync
Misthios has quit [Ping timeout: 240 seconds]
Misthios has joined #river
<ifreund> hmm, yeah that's certainly a bug
Misthios has quit [Client Quit]
Misthios has joined #river
pkap has joined #river
<pkap> When I unfocus an output with full layout, the output is re-rendered with the top-stack view instead of the last focused view. Is this intended for some reason or is it a bug?
<pkap> I hope it's clear what I mean...
<ifreund> pkap: what's happening there is that focused views are rendered on top of all unfocused views regardless of the order of the view stack.
<ifreund> and if no views are focused the stack is just rendered in order
<ifreund> so it's not really a bug as that's what's intended, but I agree that it'll seem weird with a layout where views overlap
<pkap> Ah I understand, thank you for the detailed explanation.
<ifreund> no problem!
<ifreund> I'm not really attached to this behavior, but I don't know of any better way to do this while keeping things simple
norkki has quit [Ping timeout: 268 seconds]
<leon-p> ifreund: FWIW we already discussed changing render order to reverse focus order
<ifreund> for which seat though? (yes I know we currently only have one)
<leon-p> that was your answer back then as well :D
<ifreund> :D
<ifreund> Maybe having a specially handled default seat wouldn't be the worst thing in the world
<ifreund> or we could use focus order across all seats to determine render order
<leon-p> eh, I think the solution to this can be defered. Just let the layout generator set z ordering eventually and it's no longer rivers problem.
<ifreund> yep, that's pretty much my plan
<novakane> is 521 really a bug? I make some test with the game and if the settings is set to fullscreen mode it is weird like in the screnshot but if you set it to windowed it works as expected
<novakane> so it makes sense that if the game is set in fullscrenn river still saw it as a fullscreen toplevel since it is set by the app
<leon-p> novakane: if it crashes river, than it vertainly is
<leon-p> *certainly
<leon-p> the game rendering weirdly however can definitely be a bug in that game
<novakane> yeah sure didn't have any crash though
<leon-p> the issue contains a backtrace from a crash, so apparently for them it did. Maybe you got lucky :P
<novakane> yeah I saw, I tried switching fullscreen on/off like 30 times in row and didn't have any porblems so I can't say anything about this part lol
<novakane> but for the rendering that doesn't sounds like an issue for me
<ifreund> yeah, the bug is the crash
<leon-p> it's probably part of it. The client - due to a bug or incorrect understanding of Wayland - does something weird, which results in the bad rendering and may result in a crash. The first symptom is not our problem, but the second is. The server should not crash, regardless of how wrong or weird the client behaves.
<novakane> well can't reproduce it, the only thing I have is a timeout in the transaction at the start of the programm with 2 pending configure
<leon-p> it may depend on the setup, or maybe you two are running different version?
<leon-p> Maybe I'll try to reproduce later, but now I have a session I'd rather not loose :P
<novakane> that's why you have multiple tty :P
pkap has quit [Quit: Client closed]
snakedye has quit [Ping timeout: 256 seconds]
<ghostbuster> so if one of my outputs is not recognized by wlr-randr, is that the responsibility of wlroots?
<ifreund> ghostbuster: probably yes, you might find more information in debug logs from river
norkki has joined #river
snakedye has joined #river
<ghostbuster> ifreund: i can see it being detected but then it gets deallocated I think
<ghostbuster> debug(wlroots): [backend/drm/atomic.c:34] connector DP-1: Atomic test failed (modeset): Invalid argument
<ifreund> ghostbuster: that seems to be the same error as https://github.com/riverwm/river/issues/502
<ifreund> Pretty sure this a wlroots 0.15.0 change/regression is triggering this
<ifreund> ghostbuster: do you happen to have sway installed? If so it might be useful to see a debug sway log of whatever they do to make this work
<ghostbuster> i can test it yeah
<ghostbuster> FWIW I've had issues with sway as well
<ghostbuster> this one is intermittent though, all three monitors work sometimes
<ifreund> gabm[m] in the issue said it worked for them on sway, so they may very well be doing something differently
<ifreund> sway's code dealing with this stuff is way more complex than river's though, so it's hard to know exactly what thing they do differently matters here :D
<ghostbuster> hmm i just tried on sway and same issue, only 2/3 displays come up
<ghostbuster> also interesting that it's not always the same display that fails
<ifreund> almost certainly a wlroots bug then :/
<ifreund> feel free to open an issue there with all the logs you have: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues
<ghostbuster> river has better logs too, sway doesn't even really report an error, even when started with --debug
<ifreund> hmm, really? maybe they disable debug logs entirely in release builds?
<ghostbuster> oh nvm I didn't look hard enough
<ghostbuster> yeah same error, Atomic test failed
<ifreund> thanks for testing, that certainly suggest a wlroots bug then
<tiosgz`> re "focus seems not to update after unlocking", apparently it's not that simple, coz i "accidentally" typed something right after and it worked
<tiosgz`> model situation: a window (nheko) is focused on output eDP-1, with the cursor over a text field (thus that weird text-cursor-ish shape)
<tiosgz`> i lock the session, then unlock
<tiosgz`> the previously focused view still has brighter (i.e. focus-marking) border, but the mouse cursor has the default shape and there's no text cursor in the text field
<tiosgz`> i press "f", which is apparently registered by qutebrowser on my other output, VGA-1, coz it starts showing hints
<tiosgz`> moving the mouse out of nheko and back onto it restores the expected state
<ghostbuster> so i'm a complete newbie to all things graphical, but backend/drm/atomic.c is including xf86drm.h and xf86drmMode.h .. are those for xwayland compatibility or is that how modesetting works on linux even for wayland
<ifreund> I think that's where the modesetting interface lives and the xf86 in the name is just legacy
<ghostbuster> drmModeAtomicCommit is the the call that's failing and it doesn't seem to be defined within wlroots
<ifreund> ghostbuster: you'll probably have better luck getting help debugging this in #sway-devel (general wlroots development channel despite the name)
<ghostbuster> will do
<ifreund> I'm not very familiar with the DRM api
<tiosgz`> oops, forgot to note that i have focus-follows-cursor enabled
<ghostbuster> rebooted and now all monitors come up, randomly
<ifreund> tiosgz`: ah, yeah it's bound to be related to that
waleee has joined #river
<tiosgz`> ifreund: the difference with ffc disabled is only that i cannot re-focus the correct view so easily
norkki has quit [Read error: Connection reset by peer]
<ifreund> tiosgz`: roger that, I see code I wrote that was intended to handle this. Probably need to pull out a debugger and see why it isn't working
norkki has joined #river
<tiosgz`> ifreund: i think it's coz the lock manager focuses whichever output it wants, but then it just asks the seat to focus last focused view on focused output
<tiosgz`> focus focus focus, there hasn't been enough of this word :D
<ifreund> tiosgz`: ah, yeah maybe need to save the currently focused output on lock and restore that
<tiosgz`> does it need to change it at all during lock?
<ifreund> tiosgz`: actually probably not, not sure why I made it do that
<ifreund> tiosgz`: Untested patch: https://0x0.st/oHM9.diff
<tiosgz`> s/un//, thanks!
<tiosgz`> will report if i find out it introduces another problem
<ifreund> tiosgz`: sweet, does that mean it fixes the issues you were seeing?
<tiosgz`> yes, afaict
<ifreund> nice, thanks for investigating this
hspak has quit [Quit: The Lounge - https://thelounge.chat]
hspak has joined #river
notzmv has quit [Ping timeout: 260 seconds]
notzmv has joined #river