teepee changed the topic of #openscad to: OpenSCAD - The Programmers Solid 3D CAD Modeller | This channel is logged! | Website: http://www.openscad.org/ | FAQ: https://goo.gl/pcT7y3 | Request features / report bugs: https://goo.gl/lj0JRI | Tutorial: https://bit.ly/37P6z0B | Books: https://bit.ly/3xlLcQq | FOSDEM 2020: https://bit.ly/35xZGy6 | Logs: https://bit.ly/32MfbH5
<peeps[zen]> kintel: looks like a clang thing, not clang-tidy specific: https://clang.llvm.org/docs/DiagnosticsReference.html#wdeprecated-builtins
<peeps[zen]> clang tidy should be disabled on submodules
<kintel> Issue is that this only fails with -DCLANG_TIDY=1
<peeps[zen]> kintel: there are multiple .clang-tidy files under diffrent paths: https://github.com/openscad/openscad/blob/master/submodules/.clang-tidy
<peeps[zen]> kintel: i am guessing that without clang-tidy, the build uses gcc though?
<kintel> No, this is on a clang-only system (macOS)
<peeps[zen]> is this your local dev box
<kintel> yup
<kintel> Anyway, I can dig deeper, was just hoping it was obvious to you :)
<peeps[zen]> but regarding the header filter, the comments above that line try to explain, its doing the equivalant of a negative lookahead, to say "exclude headers under /src/ext "
<peeps[zen]> the way that clang-tidy interfaces with projects is frustrating. header-filter only acts as a whitelist, there is not a straightforward way to exclude subdirectories
<peeps[zen]> and then i forget how source files (as opposed to headers) are handled, but there's essentially no control over that
<linext> any update on the WASM build
<kintel> peeps[zen] Yeah, that ext header filter just looks scary : /
<kintel> linext Did you see https://ochafik.com/openscad2 ?
<linext> not yet
<kintel> linext Looks like it's build from the regular snapshots, which includes manifold.
<gbruno> [github] kintel pushed 2 additions 1 removals (CGL -> NSOpenGL) https://github.com/openscad/openscad/commit/98ca1b8584d91fdb2fb0e2da6d6dfc284e8b4692
<gbruno> [github] kintel synchronize pull request #4576 (WIP: Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
<gbruno> [github] kintel edited pull request #4576 (WIP: Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
<gbruno> [github] kintel pushed 2 additions 2 modifications 1 removals (CGL -> NSOpenGL) https://github.com/openscad/openscad/commit/62a7e2559e19814926117951ce62d3ca71efbcae
<gbruno> [github] kintel synchronize pull request #4576 (WIP: Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
<peeps[zen]> kintel: glad to see you refactoring the OffscreenContext code btw. i was thinking about refactoring it a while back, but kinda froze up on the objective-c code as I am mostly clueless to all things apple
<kintel> peeps[zen] It's slow process, but I think I'm getting there. Will also rewrite ObjC to C++ soon
<kintel> ..and Real Soon Now, I can request OpenGL 3 context :)
<peeps[zen]> nice!
<peeps[zen]> coincidentally it was a clang-tidy check that led me to want to refactor that in the first place.
<peeps[zen]> src/glview/OffscreenContextGLX.cc:224:3: warning: Potential leak of memory pointed to by 'ctx' [clang-analyzer-cplusplus.NewDeleteLeaks]
<kintel> Yeah, I did a clean implementation of GL context handling here: https://github.com/kintel/offscreen
<kintel> For those types of issues I ended up using a scope guard: https://github.com/kintel/offscreen/blob/master/src/OffscreenContextGLX.cc#L62
<kintel> Once I'm done with green refactoring of OpenSCAD, I plan to replace all the context handling with my new code
ur5us has quit [Ping timeout: 248 seconds]
<linext> hmmm...
qeed has quit [Quit: qeed]
<linext> if ochafik could add manifold to the branch "filtered-number", i could build using dschroer's build scripts
<linext> if not, i guess it's time to switch away from dschroer to ochafik
<peeps[zen]> kintel: oh interesting. that reminds me, i was curious about reasons for going with GLAD?
qeed has joined #openscad
<linext> hull.scad is kind of funny
<linext> poor man's benchy
<peeps[zen]> kintel: have ever used or looked at gl3w ?
LordOfBikes has quit [Ping timeout: 248 seconds]
<peeps[zen]> what is filtered-number?
<linext> it builds a version of the OpenSCAD wasm
<kintel> Looks like ochafik since then has moved to using the openscad master branch
<kintel> peeps[zen] Looks like GLAD has a bit more traction these days. I'm not 100% convinced yet, just experimenting
<kintel> Didn't look into gl3w
LordOfBikes has joined #openscad
mack has left #openscad [#openscad]
<kintel> Good thing about GLAD, is that it supports GLX, EGL, WGL as well, and does aliasing of ARB/EXT calls quite nicely
<kintel> The entire GLAD binding is generated from the official OpenGL spec's XML files
J238737 has joined #openscad
<gbruno> [github] kintel pushed 1 additions 5 modifications 1 removals (Removed OffscreenContextAll.hpp) https://github.com/openscad/openscad/commit/95fe5e2b16e88bf5906e7b850764055e698ca632
<gbruno> [github] kintel synchronize pull request #4576 (WIP: Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
J2387 has quit [Ping timeout: 260 seconds]
<gbruno> [github] kintel pushed 16 modifications 1 removals (cosmetics) https://github.com/openscad/openscad/commit/f5cc7555baf786bc9c0880c3d98c89dd4a124222
<gbruno> [github] kintel synchronize pull request #4576 (WIP: Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
JakeSays has quit [Ping timeout: 250 seconds]
<gbruno> [github] kintel pushed 16 modifications 1 removals (cosmetics) https://github.com/openscad/openscad/commit/0b49fb714c470207f0be23f4aea4c87c052832f4
<gbruno> [github] kintel synchronize pull request #4576 (WIP: Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
<gbruno> [github] kintel pushed 7 modifications (Use exception instead of throwing -1) https://github.com/openscad/openscad/commit/6f1d5975555ba9bf5a62105cb0738f4f239a6194
<gbruno> [github] kintel synchronize pull request #4576 (WIP: Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
ur5us has joined #openscad
ur5us has quit [Ping timeout: 250 seconds]
ur5us has joined #openscad
<gbruno> [github] kintel pushed 7 modifications (Removed duplicate machine info which is already provided by PlatformUtils) https://github.com/openscad/openscad/commit/27ea4abb4c915b37b17fb3446efdf98cd5c958e2
<gbruno> [github] kintel opened pull request #4581 (Removed duplicate machine info which is already provided by PlatformUtils) https://github.com/openscad/openscad/pull/4581
<gbruno> [github] kintel ready_for_review pull request #4581 (Removed duplicate machine info which is already provided by PlatformUtils) https://github.com/openscad/openscad/pull/4581
<gbruno> [github] kintel pushed 2 modifications (Windows fixes) https://github.com/openscad/openscad/commit/e6cd8038215e69bcdd86719d4f8f3124ea35a4d4
<gbruno> [github] kintel pushed 2 modifications (Merge branch 'kintel-cpuinfo' of github.com:openscad/openscad into kintel-cpuinfo) https://github.com/openscad/openscad/commit/36d70923b0ac3638ecfb0c54167323c8755932a2
<gbruno> [github] kintel synchronize pull request #4581 (Removed duplicate machine info which is already provided by PlatformUtils) https://github.com/openscad/openscad/pull/4581
<gbruno> [github] kintel synchronize pull request #4581 (Removed duplicate machine info which is already provided by PlatformUtils) https://github.com/openscad/openscad/pull/4581
kintel has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
ur5us has quit [Ping timeout: 250 seconds]
fedorafan has quit [Ping timeout: 265 seconds]
fedorafan has joined #openscad
fedorafan has quit [Ping timeout: 252 seconds]
fedorafan has joined #openscad
fedorafan has quit [Ping timeout: 246 seconds]
fedorafan has joined #openscad
guso78 has joined #openscad
Av8r has quit [Quit: Ping timeout (120 seconds)]
fedorafan has quit [Ping timeout: 246 seconds]
fedorafan has joined #openscad
use-value has joined #openscad
JakeSays has joined #openscad
guso78 has quit [Quit: Client closed]
guso78 has joined #openscad
mechadense has joined #openscad
ToAruShiroiNeko has quit [Ping timeout: 255 seconds]
ToAruShiroiNeko has joined #openscad
paddymahoney has joined #openscad
fedorafan has quit [Ping timeout: 246 seconds]
fedorafan has joined #openscad
snaked has quit [Quit: Leaving]
kintel has joined #openscad
gunnbr_ has joined #openscad
gunnbr__ has quit [Ping timeout: 240 seconds]
teepee has quit [Remote host closed the connection]
<guso78> lf94, this is a chamfered union. more blendings to come https://imgpile.com/i/hMVXDL
teepee has joined #openscad
<gbruno> [github] kintel pushed 4 modifications (Updated use of deprecated strstream) https://github.com/openscad/openscad/commit/75c66b2d8c63ce0cdac6fb9166da629f159f8f93
<gbruno> [github] kintel synchronize pull request #4581 (Removed duplicate machine info which is already provided by PlatformUtils) https://github.com/openscad/openscad/pull/4581
mechadense has quit [Ping timeout: 260 seconds]
use-value has quit [Remote host closed the connection]
use-value has joined #openscad
fedorafan has quit [Ping timeout: 252 seconds]
linext has quit [Read error: Connection reset by peer]
fedorafan has joined #openscad
teepee_ has joined #openscad
teepee has quit [Ping timeout: 255 seconds]
teepee_ is now known as teepee
fedorafan has quit [Ping timeout: 246 seconds]
<gbruno> [github] kintel pushed 1 modifications (build fix) https://github.com/openscad/openscad/commit/0c8676e4f00acc406b17d6c42c23ed04bee6b935
<gbruno> [github] kintel synchronize pull request #4576 (WIP: Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
<lf94> guso78: so nice :)
<lf94> InPhase: you seeing this?
<InPhase> I clicked. It's a chamfer. :)
<lf94> InPhase: it's libfive in openscad
<lf94> :D
<lf94> I know it's not with OpenSCADs intepreter but still
<lf94> It's a great step
<guso78> next step is to set up the utilty library. so many things which can leverage from curv
<guso78> actually it was me who ported quite some blenders to curv
fedorafan has joined #openscad
<lf94> guso78: it'd be incredible if you got the integration working with OpenSCAD language too
<lf94> it's already amazing now, but just saying
<lf94> you have some experience now dealing with the codebase
<guso78> i dont know ANYTHING about openscad before the parser function :(
fedorafan has quit [Ping timeout: 252 seconds]
<lf94> ah
use-value has quit [Remote host closed the connection]
<lf94> well one of these days im looking into it, because i think the more people doing code cad = the more great things ill see in my lifetime come from it :D
use-value has joined #openscad
<lf94> i wanna see people do some crazy shit!
fedorafan has joined #openscad
<gbruno> [github] kintel edited pull request #4581 (Removed duplicate machine info which is already provided by PlatformUtils) https://github.com/openscad/openscad/pull/4581
Guest1848 has joined #openscad
Guest1848 has quit [Client Quit]
JakeSays_ has joined #openscad
JakeSays has quit [Ping timeout: 250 seconds]
<gbruno> [github] kintel edited pull request #4576 (WIP: Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
<gbruno> [github] kintel pushed 1 modifications (Include windows.h before glad) https://github.com/openscad/openscad/commit/f127abfe2b398725c0ec425e3a803cf8d40ac8a8
<gbruno> [github] kintel synchronize pull request #4549 (Add support for GLAD) https://github.com/openscad/openscad/pull/4549
fedorafan has quit [Ping timeout: 252 seconds]
fedorafan has joined #openscad
<gbruno> [github] kintel closed pull request #4581 (Removed duplicate machine info which is already provided by PlatformUtils) https://github.com/openscad/openscad/pull/4581
<gbruno> [github] kintel pushed 7 modifications (Removed duplicate machine info which is already provided by PlatformUtils (#4581)) https://github.com/openscad/openscad/commit/8a07b27b7fa72f0318f02875c4e05720e0db6a47
<gbruno> [github] kintel pushed 1 modifications (build fix) https://github.com/openscad/openscad/commit/716c1a665f3117793caa18cd156a4f9ead427831
<gbruno> [github] kintel synchronize pull request #4576 (WIP: Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
<gbruno> [github] kintel edited pull request #4576 (WIP: Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
<gbruno> [github] kintel ready_for_review pull request #4576 (WIP: Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
<kintel> Initial (green) offscreen refactoring is ready in case anyone has comments: https://github.com/openscad/openscad/pull/4576
<guso78[m]> Great! I regularily merge Master 😄
fedorafan has quit [Ping timeout: 248 seconds]
fedorafan has joined #openscad
guso78 has quit [Quit: Client closed]
guso78 has joined #openscad
<gbruno> [github] kintel edited pull request #4576 (WIP: Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
fedorafan has quit [Ping timeout: 246 seconds]
<pa> https://i.imgur.com/0dAsCp4.png so in the end i went rambo, and printed without testing the sockets.. Turns out they are a tad too fit and bump slightly. How can i "file" that tpu surface to even it? if i go on with a hot air station, do i risk to melt down everyting? ideally a disc of metal sligtly larger, and hot, to press on each bump?
fedorafan has joined #openscad
<pa> i guess easier would be to reprint lol
L29Ah has left #openscad [#openscad]
<gbruno> [github] kintel edited pull request #4576 (Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
<gbruno> [github] kintel pushed 1 modifications (Windows build fix) https://github.com/openscad/openscad/commit/c1279aeaae345a2e7ad78840faa90ed990289a31
<gbruno> [github] kintel synchronize pull request #4576 (Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
JakeSays_ is now known as JakeSays
<InPhase> pa: Sub-layer tweaks, sand paper. Tweaks on the scale of one layer or so can be made effectively with a sharp knife, preferably a quality carbon steel blade so you're slicing smoothly and not peeling or hacking. If you need more than your outer layer count minus 1, then a reprint is usually mandatory. :)
<InPhase> For internal rounded sanding, I've achieved success by wrapping sand paper around an appropriately sized bolt.
<InPhase> The sharp knife can also do a slight post-print chamfer if a printing defect gave you a bit of an issue at an opening (like overextrusion on the bottom layer on a design that you didn't leave enough clearance for this).
<InPhase> You can ultimately build any shape out of plastic using epoxy, a knife, and patience. But the goal here is to make the printer do most of the work. :) So I try to leave the adjustments to quick hack fixes to save time, or for scenarios where higher accuracy is needed than printing tolerances can achieve.
<pa> InPhase: so heat-based tweaks not recommended?
<gbruno> [github] kintel pushed 2 additions 9 modifications (Add OffscreenContextCGL) https://github.com/openscad/openscad/commit/8267f69e36d992d9e8da3293658dc77f37579fa5
fedorafan has quit [Ping timeout: 248 seconds]
<gbruno> [github] kintel opened pull request #4582 (Add new, more capable, offscreen classes) https://github.com/openscad/openscad/pull/4582
fedorafan has joined #openscad
<gbruno> [github] kintel pushed 4 modifications (Use std::ostringstream where possible) https://github.com/openscad/openscad/commit/d0049919591e2b4c74a3992fd08d1e2de1f40510
<gbruno> [github] kintel synchronize pull request #4576 (Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
<kintel> InPhase I've finally circled back to running tests under Windows, and it looks like the venv stuff behaves slightly differently between plain win32 and msys2
<teepee> joseph_: turns out the GSoC app does not like just any google account, it only works with some specific ones, not the one I tried to use first.
<kintel> -> the python executable is in venv/bin/python.exe, not venv/Scripts/python.exe
<kintel> Did you happen to bump into that, or am I on my own?
<teepee> I seem to remember that difference caused some trouble earlier
<kintel> Yeah, I'm a bit scared to touch it ;)
<kintel> Not sure if it matters, since our build script cannot install PIL under Windows anyway : /
<kintel> oh, and our Windows cmake Find macros are not very well behaved; I have to remove CMakeCache.txt and re-configure between each build, as there is some broken cmake cache stuff going on.
<kintel> I guess I'm the first to run tests under msys2. Not sure if I can fit into that rabbit hole ;)
<kintel> InPhase Btw., do you actually have a way of running tests locally, or do you just CI do the job?
<kintel> (all tests run in 1 minute here, so it would be awesome if it worked)
teepee_ has joined #openscad
teepee has quit [Ping timeout: 255 seconds]
teepee_ is now known as teepee
<gbruno> [github] kintel pushed 6 modifications (Split glew_dump() into separate glew and GL functions") https://github.com/openscad/openscad/commit/ecc45ad2f78d13f72bc93bf514d3f3a31657d1bf
<gbruno> [github] kintel synchronize pull request #4582 (Add new, more capable, offscreen classes) https://github.com/openscad/openscad/pull/4582
<gbruno> [github] kintel edited pull request #4582 (Add new, more capable, offscreen classes) https://github.com/openscad/openscad/pull/4582
<InPhase> kintel: I run tests locally.
<kintel> InPhase Using msys2?
<InPhase> I don't test on Windows nor build on Windows locally.
<kintel> aah
<InPhase> I rely on cross-platform development fingers being crossed for that, and CI to check that this has been successful. :)
<kintel> Sorry, had you confused with Jordan for a sec there
<InPhase> I won't take it personally. ;) He's very sharp for a Windows user.
<kintel> I'll open a bug, see if someone takes the bait :)
<kintel> First-class Windows dev-env would be a good GSoC project
<InPhase> pa: The only heat based tweak I've really attempted was fixing a printing defect bend. Emphasis on attempted. It's tricky work.
<teepee> kintel: there's one maintained in a PR
<teepee> updated occationally
<kintel> wait, really?
<kintel> oh, Visual Studio. That's a bit above my paygrade :{}
<kintel> Anyway, I pinged the PR, let's see what happens
<kintel> If anyone else is using msys2 on Windows and are able to run tests, let me know :)
<gbruno> [github] kintel opened issue #4583 (Tests are not runnable for msys2 build) https://github.com/openscad/openscad/issues/4583
<teepee> kintel: github action seems to be able to run it though https://github.com/openscad/openscad/actions/runs/4566588861/jobs/8059302263
<kintel> Thanks! I somehow thought we were running MXE binaries for the CI...
<kintel> Looks like the trick is to use native Windows Python, not msys2 python.
L29Ah has joined #openscad
<InPhase> kintel: The msys2 script in the repository sets it up okay for the CI with msys2.
<InPhase> I edited something in that...
<InPhase> Right. I edited adding in both python and python-pip.
<gbruno> [github] kintel edited issue #4583 (Tests are not runnable for msys2 build) https://github.com/openscad/openscad/issues/4583
<InPhase> kintel: Maybe if you skipped that you have an msys2 that has a python but no pip. The error message does not reveal no pip, but instead was something else more obscure that is actually due to a missing dependency that is bundled into python-pip. Maybe something about wheels missing or something?
<InPhase> It took me a little googling, thinking, and guesswork to put that together that day. It was not an obvious failure pattern.
kintel has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
ur5us has joined #openscad
guso7841 has joined #openscad
<joseph_> teepee: So were you able to successfully get added as a mentor?
<teepee> yes
snaked has joined #openscad
Guest87 has joined #openscad
Guest87 has quit [Client Quit]
use-value has quit [Remote host closed the connection]
use-value has joined #openscad
ur5us has quit [Quit: Leaving]
ur5us has joined #openscad
kintel has joined #openscad
<kintel> InPhase It looks like the problem may be that it cannot install the binary wheel for PIL, and it tries to compile it, but PIL doesn't support building on Windows using gcc.
<kintel> On the CI, it uses a pre-built non-msys2 version of Python, which seems to be able to download pre-built packages
<gbruno> [github] kintel pushed 6 modifications (Merge branch 'kintel-offscreen-refactor' of github.com:openscad/openscad into kintel-offscreen-refactor) https://github.com/openscad/openscad/commit/0d81c0aea6c4117fea5ac672cddff980e8f6dd11
<gbruno> [github] kintel synchronize pull request #4576 (Refactor offscreen context management) https://github.com/openscad/openscad/pull/4576
guso7841 has quit [Ping timeout: 260 seconds]
castaway has quit [Ping timeout: 250 seconds]
pa has quit [Ping timeout: 276 seconds]
kintel has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
pah has joined #openscad
linext has joined #openscad
linext_ has joined #openscad
linext_ has quit [Client Quit]