<freemangordon>
the second has the function name on the same line as function type
<freemangordon>
brackets have to be on a separate line
<Wizzup>
yeah, I'll make it match yours
<freemangordon>
mhm
<Wizzup>
but I mean apart from indent
<Wizzup>
sorry, we're just used to different things :D
<Wizzup>
but it's absolutely np, I'll fix it
<freemangordon>
one question: why gtk_combo_box_new_text() ?
<Wizzup>
As opposed to / instead of?
<freemangordon>
I am almost sure some hildon widget is used instead
<freemangordon>
lemme try to find it
<Wizzup>
I think I took this from other combo boxes from connui
<freemangordon>
hmm, could be
* freemangordon
checks
<Wizzup>
The only limitation it has that I don't want to fix right now is that when you switch providers to something else and then back to what it was, it won't "remember" the service id (i.e. provider specific config) you selected initially, but I think that shouldn't be a big deal
<uvos>
oh btw please rewiev the mce and h-d pr
<freemangordon>
uvos: will do
<freemangordon>
Wizzup: I am almost sure hildon_picker_button/hildon_touch_selector is used elsewhere
<Wizzup>
do you have an example? I took this from the wlan tab
<Wizzup>
in advanced
<freemangordon>
oh, right
<freemangordon>
pickers are on the main 'page'
<freemangordon>
"Internet connections" that is
<freemangordon>
so yeah, combobox is fine
<freemangordon>
LMK when you fix the coding style
<freemangordon>
uvos: reviewing those will take more time I have ATM, will try to do h-d at least tomorrow
Temp1933 has joined #maemo-leste
<uvos>
mce is way more important
<uvos>
is blocking everything
<freemangordon>
ok
<uvos>
the hildon pr just replaces a hack i wrote some time ago with soemthing better
<freemangordon>
I am not sure how usefull I will be, given I never used cmake :)
<uvos>
so it dosent change any real functionality
<freemangordon>
but will do my best
<uvos>
thank you
Temp1933 has left #maemo-leste [#maemo-leste]
inky has quit [Ping timeout: 240 seconds]
<freemangordon>
Wizzup: also, please keep 80 chars per line limit
<uvos>
well if he has nothing further to add we need to close 329 by voteing on a style or something
<uvos>
something to put into guidelines
<Wizzup>
I think the concensus we have is that we stick to whatever the repo has
<Wizzup>
and if the maintainer wants to switch, they can do that
<uvos>
thats not how 329 reads
<freemangordon>
:nod:
<Wizzup>
maybe we can narrow it down to like two or three styles
<Wizzup>
and then make it clear which uses which
<uvos>
and besides a prefered style is sensible
<Wizzup>
not if we can't agree on one :P
<uvos>
even if it comes with a dont change coherent repos preface
<Wizzup>
I'm fine changing my PR for fmg's style, but I won't use it for new repos (only I) work on
<bencoh>
:)
<freemangordon>
well, at the end of the day I think it comes to which style is the easiest to read
<uvos>
i dont think there is a style that is easiest to read
<uvos>
that just whatever you are used to
<Wizzup>
I will switch to your style if you switch to my editor ;)
<freemangordon>
not really
<Wizzup>
(joke)
<bencoh>
acctually a 80-ish limit really is easier to read
<freemangordon>
Wizzup: and give up on QtCreator?
<Wizzup>
:p
<uvos>
i dissagree on modern displays that just creates whitespace
<bencoh>
it basically means your eyes to need to move too far
<freemangordon>
bencoh: :nod:
<uvos>
to many line breaks is bad too
<Wizzup>
I just want to get to a sitation where we can use tooling with a set of indentation rules
<bencoh>
and that you can have several opened files in columns
<uvos>
sure
<Wizzup>
and then you can run it when you work, revert it with the standard rules, and commit code
<uvos>
but 80 coll is to narrow imo
<uvos>
110 at least
<uvos>
200 is def to long
<uvos>
etc
<bencoh>
(s/to need/don't need/ )
<freemangordon>
uvos: no matter the display, eyes still have limit on the minimum font size that's ok for them
<freemangordon>
and that changes with aging
<bencoh>
uvos: oh, right, the limit itself is obviously a matter of taste, and 80 is legacy
<uvos>
right
inky has joined #maemo-leste
<uvos>
its very mutch a matter of taste
<freemangordon>
80 chars limit forces you to beautify the code you write, more or less
<bencoh>
relaxed-limit in linux is 80 soft-limit, ~100 hard-limit now, right?
<uvos>
110
<bencoh>
freemangordon: indeed :)
<uvos>
soft ish at 110
<freemangordon>
that's why I prefer to stick to it
<uvos>
80 is totaly gohne from docs iirc
<bencoh>
oh? sad
<bencoh>
tbh I always wonder how people manage to keep under 80 with tabsize 8 (I use 4)
<uvos>
wel linux uses tab
<uvos>
so that counts as one
<freemangordon>
which is a huge waste of space IMO
<Wizzup>
maybe we can pick 2 rules and settle on those, and make some bash aliases or helper scripts to let people switch from styles before they commit?
<uvos>
tab?
<bencoh>
8 ? definitely a waste
<Wizzup>
as much as I like discussing code formatting
<freemangordon>
yes
<Wizzup>
I don't think this leading us anywhere
<freemangordon>
Wizzup: ok
<bencoh>
Wizzup: didn't you toy with indent (the tool) at some point?
<uvos>
how is tab a waste of space you can set it to any with you like
<freemangordon>
Wizzup: we are really just chattering IIUC
<Wizzup>
the one thing my above suggestion requires is if we pick 2 or 3 cdoe styles, we also apply them to a repo, so that subsequent runs do not generate daditional noise
<Wizzup>
ok
<Wizzup>
then keep going :P
<freemangordon>
:)
<bencoh>
:]
<uvos>
bencoh: indent -linux -l 120 had some consus on the bug above
<bencoh>
yeah, having a few reference styles would be a good idea (and I'm all with "stick-to-the-original-repo-choice" thing)
<freemangordon>
Wizzup: but, seriously, what we *must* have as a rule is - do PRs in coding style of the repo you're working with
<Wizzup>
freemangordon: yes, but I want the style to be strictly defined
<freemangordon>
ah, I see
<uvos>
sometimes the codeing style the repo works with is hard to decern
<Wizzup>
so if you can find a set of indent(1) flags for your style, that would be nice
<uvos>
we need to fix that too
<uvos>
h-d is an offender
<freemangordon>
h-d is...
<freemangordon>
Wizzup: I am using QtCreator, not really sure how to extract the style from there
<Wizzup>
so my suggestion was, let's try to define 2 or 3 sets of indent flags
<Wizzup>
freemangordon: maybe try running indent with some flags until it matches
<Wizzup>
it doesn't have to *now*, but it would make our lives easier
<freemangordon>
ok
<bencoh>
freemangordon: I didn't think you would use it, interesting (actually I think you told me once already, but still surprised)
<freemangordon>
that's the best C/C++ editor IMO
<freemangordon>
Wizzup: I can export its settings in some qt3.xml file
<bencoh>
and yeah, we might not run the full project through indent, but at least people pushing commits would have a way to fix indent in some automatic manner before commiting
<Wizzup>
bencoh: yes
<Wizzup>
also we can fix the entire project ina single commit and make git blame ignore it
<bencoh>
how so? git log/blame/whatever read some config file stored in repository?