10:09 <tolszak> chewitt: Thank you for explanation, narmstrong: So should we only add axg-sound-card.conf as separate SRC_URI? Or both?

10:16 <narmstrong> tolszak: add both

13:22 <tolszak> narmstrong: regarding my PR - what if an update will appear in upstream? Having copy of *.conf will not allow easily to update axg, gx cards. Why not to have 9999-adjust-axg-for-odroid-n2.patch and add it to odroidn2 src_uri?

13:23 <narmstrong> tolszak: I don't think any xg or axg generic conf will ever appear on upstream alsa-lib

13:24 <narmstrong> if this happens I'll adapt the audio support accordingly

13:24 <tolszak> What if LibreElec patch will appear?

13:25 <tolszak> I mean wouldn't it be easier to introduce new patches if there is "the last patch" that removes the hint for axg?

13:26 <tolszak> If new patch appears in libreelec you then need to modify files in meta-meson and it will be harder to find the source of modification (original patch)

13:26 <tolszak> Anyways just my 2c

13:26 <tolszak> if it doesn't change you mind I have some time to finish it today

13:29 <narmstrong> handling patches is painful makes it hard to add changes, here the patches are 99,9999% adding raw files, it would be much simpler to add the .conf file directly. You can even drop the Makefile.am patch and install them directly in the /usr/share/alsac/conf dir with do_install_append()

13:58 <tolszak> narmstrong: understood, The do_install_append seems like more consistent way - either patches or no patches. Doing it right now

14:16 <narmstrong> thx !

14:55 <tolszak> narmstrong: Testing, and double checking. axg-sound-card.conf should have removed everything from "axg-sound-card.pcm.iec958.0 {" till end of file, effectively whole "axg-sound-card.pcm.iec958.0" block right?

14:55 <narmstrong> tolszak: yep !

14:56 <tolszak> Works, although I see now the hdmi speakers warning you've also noticed

14:56 <tolszak> I think it was not there before or was polluted by other warnings from deleted part of conf

14:56 <tolszak> Works here though! uploading the change

14:57 <narmstrong> nice, thanks for working on this !

15:01 <tolszak> narmstrong: Ah I've forgot to remove copyright comments, OTOH shouldn't they stay there?

15:01 <chewitt> tolszak this is probably the speaker map warning https://mailman.alsa-project.org/pipermail/alsa-devel/2021-December/193696.html

15:02 <narmstrong> tolszak: from LibreELEC ? yes keep them

15:02 <tolszak> tolszak: So that's it, thanks

15:02 <chewitt> I'm not fussed if the attribution is removed (as the original author)

15:03 <chewitt> I was thinking to send the gx conf upstream as the hint works on AIU

15:03 <chewitt> no plans to send AXG as that's a can 'o worms

15:04 <tolszak> chewitt: Thanks for help

15:05 <chewitt> I've love to get the speaker placement issue resolved, even if it's an out of tree hack until something more permanent comes along

15:08 <tolszak> chewitt: Unfortunately I don't have any experise to help you with that, although I'm sure might be interesting to learn