<enebo[m]>
[INFO] No sources in project. Archive not created.
<headius>
hmm
<enebo[m]>
so share uses jar provided which is jruby-base so it doesn't really have source
<enebo[m]>
but when jruby-complete is marked as using jruby-core it expects it will have source jar? Seems wrong to me
<headius>
I see the provided scope in complete config includes jruby-core excludes jruby-base
<headius>
not sure why it excludes base but perhaps removing that would have an impact
<headius>
might need to dig up mkristian otherwise, the new structure is peculiar
<enebo[m]>
exclusion "org.jruby:jruby-base"
<headius>
right
<enebo[m]>
I can remove it and run it to see what happens I guess
<enebo[m]>
it seems pretty obvious that the things we use which were shaded should excluded
<headius>
yeah
<enebo[m]>
but the shade will change consumers too
<enebo[m]>
so we really don't want jruby-base here
<enebo[m]>
but I am just guessing at what this line means. I will try it
<enebo[m]>
It is a weird line in the context of jruby-core but I suppose this it to let Maven know it should not look at this artifact for resolution
<enebo[m]>
headius: here is a weird one. I removed the exclusion and re-ran maven. That exclusion is not even being put into pom.xml
<enebo[m]>
headius: sent an email to kristian with you cc'd
<headius>
He was responding to another issue late last week
<headius>
We may need to consider the possibility of changing the build sooner than later
<headius>
Something we can maintain better
<enebo[m]>
I find maven to be pretty opaque in how to fix problems
<enebo[m]>
I can read the log and realize it decided not to build -sources.jar but why jruby-complete needs it as part of release
<enebo[m]>
Just don't know why...and this may not really purely be maven but just standards established by sonatype but it is it's own domain which requires some level of expertise
<headius>
I don't know the sonatype rules on that... It shades the dependent libraries but does that count as a transitive thing or a new library that aggregates to others and still needs sources?
<headius>
When we shaded libraries in core we didn't include the source of those other libraries so I am a bit confused as well
<enebo[m]>
jruby-base is not listed in the resulting pom.xml even if you remove that exclusion
<enebo[m]>
so I feel like it only lists immediate transitive deps?
<enebo[m]>
although does jruby-complete say it is direct trans dep to asm?
<headius>
And I assume removing the exclude did not help?
<enebo[m]>
I love to just dismiss maven altogether since I have never liked it but I feel like we just lack some knowledge in how this is supposed to work when pushing
<enebo[m]>
headius: that line does not do anything to the xml file
<headius>
Maybe check on sonatype pages for push requirements? I have some errands to run but back in a bit
<headius>
This has to be caused by the new artifact, probably some minor config tweak needed
<enebo[m]>
yeah I am guessing worst case there is an empty source jar which would just solve it too