Arnavion has quit [Remote host closed the connection]
Arnavion has joined #foot
themainman has quit [Quit: WeeChat 3.1]
<lanodan>
I guess that should also be possible on distros like alpine
<lilblacky>
A day's worth of testing tells me the issue can be locally reproduced with consistency on sway 1.6.1 wlroots 0.14.1. The delay is noticeable, particularly with fast coders around the office. However, it has resolved one of the standing issues we had with Alacrity: Bind kill would sometimes leave processes in the background = race condition = rising CPU temps = process kill hunting. Apps with many open files/sockets at the time of kill
<lilblacky>
(e.g. torrent apps) were notorious for this. Even top on occasion. So far, so good. Patched foot has resolved that as far as we have noticed.
<lilblacky>
Current master has been more stable than release as far as footclient is concerned. Whereas release might cause an occasional artifact, master has not.
<lilblacky>
Foot standalone has been solid across both release and master. -N (footclient) is a nice touch! Our default is to call -N from sway (unless a term needs to be held open).
sosodank has joined #foot
novakane has joined #foot
ollysmith has quit [Quit: ZNC 1.8.2+deb2+b1 - https://znc.in]
ollysmith has joined #foot
<dnkl>
lilblacky: when closing the window one of those really slow applications (like torrent), how long time does it take? 4s?
<lilblacky>
Lemme load up an instance and check in a moment...
<dnkl>
lilblacky: make sure it's really up and running, with lots of connections, before closing the window...
novakane has quit [Quit: WeeChat 3.2]
novakane has joined #foot
<lilblacky>
Rtorrent (foot and not footclient) with 852 sockets and 1022 files open with modest raise of ulimit -n 2048 closed immediately. I would consider that medium-high desktop torrent usage versus dedicated sandbox as rtorrent suggested settings for modern PCs stands at 600 sockets and 300 files assuming the standard ulimit -n of 1024. Will check again Mon at the office where we have a small, dedicated sandbox running.
<lilblacky>
Sandbox = seedbox.
<dnkl>
lilblacky: hmm, was expecting that to take longer... in my own experience, rtorrent can take a very long time to shutdown, easily 30s
<dnkl>
anyway, your comment made me realize the current fix isn't good enough
<dnkl>
while we're no longer blocking the server process right when the window has been unmapped, we _are_ still blocking everything
<dnkl>
the correct solution is to make it asynchronous
<dnkl>
and then we revert back to terminating the application after unmapping the window again
<dnkl>
thus removing the delay before the window is closed, while still allowing other footclients to continue processing events
<dnkl>
I have a POC that appears to work. Will test it a bit more, clean it up, and then open a new PR, that will *replace*https://codeberg.org/dnkl/foot/pulls/661
themainman has joined #foot
novakane has quit [Read error: Connection reset by peer]
novakane has joined #foot
sosodank has quit [Remote host closed the connection]
novakane has quit [Quit: WeeChat 3.2]
novakane has joined #foot
<dnkl>
lilblacky: can I bother you again? If you have some free time, would you mind testing https://codeberg.org/dnkl/foot/pulls/662 ? It supersedes the PR from yesterday, making the whole shutdown process asynchronous.
<dnkl>
with it, the window now closes immediately again
<dnkl>
while foot is waiting in the background for the application to terminate
<dnkl>
but unlike before, this is now asynchronous, and other footclient instances will continue to run undisturbed
<dnkl>
I've also raised foot's internal timeout before it sends SIGKILL from 4 seconds to 60 seconds
<dnkl>
thus, you might see lingering foot(client) processes for up to 1min after you've closed the window
<dnkl>
(most applications will terminate immediately though)
sosodank has joined #foot
sosodank has quit [Remote host closed the connection]
sosodank has joined #foot
Amanieu has quit [Quit: Amanieu]
Amanieu has joined #foot
sosodank has quit [Remote host closed the connection]
novakane has quit [Quit: WeeChat 3.2]
ericonr has quit [Quit: WeeChat 3.1]
ericonr has joined #foot
<lilblacky>
662 patched 35041cd. Foot(client) do close windows immediately. Closing a window in the middle of building gcc 11.2 is immediate: Processes as seen through top are cleaned up within 1-2 seconds. Firefox called by foot with with 15 open tabs and media playing is more of the same: Immediate window closure and processes closed within 1-2 seconds.
<lilblacky>
Will continue to test apps (including your example bad client) run concurrently across multiple windows. For now, foot(client) gets out of the way and allows for uninterrupted workflow: Mind and PC are one again ;)
<lilblacky>
Fyi outstanding documentation. Like bearssl, it's a good read to learn about how things work!
<lilblacky>
Top (toybox) is set to poll every 1 second for lack of a better benchmarking tool.