ChanServ changed the topic of #armlinux to: ARM kernel talk [Upstream kernel, find your vendor forums for questions about their kernels] | https://libera.irclog.whitequark.org/armlinux
CrashTestDummy2 has joined #armlinux
CrashTestDummy3 has quit [Ping timeout: 245 seconds]
CrashTestDummy3 has joined #armlinux
CrashTestDummy2 has quit [Ping timeout: 245 seconds]
sakman has joined #armlinux
guillaume_g has joined #armlinux
ardb has joined #armlinux
frieder has joined #armlinux
iivanov has quit [Quit: Leaving...]
iivanov has joined #armlinux
sszy has joined #armlinux
matthias_bgg has joined #armlinux
Xogium has quit [Quit: Leaving.]
sakman_ has joined #armlinux
Xogium has joined #armlinux
sakman has quit [Remote host closed the connection]
milkylainen has quit [Quit: Ping timeout (120 seconds)]
milkylainen_ has quit [Quit: Ping timeout (120 seconds)]
Pali has joined #armlinux
milkylainen has joined #armlinux
ardb has quit [Quit: Leaving.]
Pali has quit [Ping timeout: 245 seconds]
CrashTestDummy3 has quit [Quit: Leaving]
Amit_T has joined #armlinux
eballetbo has joined #armlinux
tudorel has joined #armlinux
eballetbo has quit [Quit: Ping timeout (120 seconds)]
milkylainen has quit [Quit: Ping timeout (120 seconds)]
milkylainen has joined #armlinux
tlwoerner has quit [*.net *.split]
Sledge_ has quit [*.net *.split]
TheCoffeMaker has quit [*.net *.split]
biot has quit [*.net *.split]
gclement has quit [*.net *.split]
mrutland- has quit [*.net *.split]
tmlind has quit [*.net *.split]
apritzel has joined #armlinux
biot has joined #armlinux
Sledge_ has joined #armlinux
mrutland- has joined #armlinux
TheCoffeMaker has joined #armlinux
tlwoerner has joined #armlinux
tmlind has joined #armlinux
gclement has joined #armlinux
CrashTestDummy has joined #armlinux
CrashTestDummy has quit [Read error: Connection reset by peer]
CrashTestDummy has joined #armlinux
ardb has joined #armlinux
sudeepholla has joined #armlinux
djrscally has joined #armlinux
apritzel has quit [Remote host closed the connection]
apritzel has joined #armlinux
djrscally has quit [Ping timeout: 268 seconds]
djrscally has joined #armlinux
unmanbearpig has joined #armlinux
djrscally has quit [Quit: Konversation terminated!]
djrscally has joined #armlinux
iivanov__ has joined #armlinux
Turingtoast has joined #armlinux
iivanov has quit [Ping timeout: 260 seconds]
iivanov__ has quit [Client Quit]
iivanov has joined #armlinux
ardb has quit [Ping timeout: 252 seconds]
ardb has joined #armlinux
headless has joined #armlinux
torez has joined #armlinux
jlinton has quit [Quit: Client closed]
jlinton has joined #armlinux
tudorel has quit [Quit: tudorel]
headless has quit [Quit: Konversation terminated!]
macromorgan has quit [Killed (platinum.libera.chat (Nickname regained by services))]
<ukleinek>
broonie: can you point me to the problem that is mentioned in spi_add_device(), i.e. "We need to make sure there's no other device with this chipselect **BEFORE** we call setup(), else we'll trash its configuration."?
<broonie>
That predates me but it seems obvious that we'd have issues if we reconfigured an existing device to have a different setup by mistake?
<ukleinek>
broonie: I wonder if the explicit check (bus_for_each_dev(&spi_bus_type, NULL, spi, spi_dev_check)) can be dropped because a second device for the same bus+chipselect fails when /sys/bus/spi/devices/spiX.Y is to be created.
<broonie>
Yes, I was just wondering that myself.
<broonie>
OTOH is it causing issues?
<ukleinek>
broonie: yes, there is a problem with spi-mux, because the device_add in spi_add_device() is called under &spi_add_lock and might trigger another spi_add_device() and so a deadlock
matthias_bgg has quit [Ping timeout: 246 seconds]
<broonie>
Ah. Then yeah, I've not really heard of that check going off a lot and it seems in the general basket of people shooting themselves in the foot off the top of my head.
<ukleinek>
So the only problem in reverting ddf75be47ca748f8b12d28ac64d624354fddf189 is: Can a controller really disappear (if yes, a device_get() should be good enough) and that config trashing mentioned in that comment.
<broonie>
Hotplug is a thing.
* ukleinek
wonders why spi_add_device is exported, there are no callers apart from drivers/spi/spi.c
<ukleinek>
broonie: agreed, hotplug is a thing, but the callers of spi_add_device seem to hold a reference on the controller, so at least the struct device doesn't go away?!
<broonie>
If the driver isn't there then cleaning up the client we just added is going to get messy.
<ukleinek>
(spi_alloc_device -> spi_controller_get takes a reference)
* ukleinek
doesn't understand which driver broonie is talking about
<broonie>
The controller driver.
* ukleinek
considers what happens if spi_add_device() is called for a device on a bus without driver
* broonie
is in the middle of stuff and not fully working through all the cases here, but some care is going to be needed.
<ukleinek>
broonie: ok, I will think some more about this tomorrow and then hopefully present a fix by mail.
matthias_bgg has joined #armlinux
apritzel has quit [Ping timeout: 268 seconds]
frieder has quit [Remote host closed the connection]
ardb has quit [Read error: Connection reset by peer]
sudeepholla has joined #armlinux
tudorel has quit [Quit: tudorel]
Amit_T has quit [Quit: Leaving]
jlinton has quit [Quit: Client closed]
ardb has joined #armlinux
guillaume_g has quit [Quit: Konversation terminated!]
Nact has joined #armlinux
Nact has quit [Quit: Konversation terminated!]
torez has quit [Ping timeout: 268 seconds]
Turingtoast has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
torez has joined #armlinux
headless_ has joined #armlinux
headless is now known as Guest1430
headless_ is now known as headless
Guest1430 has quit [Killed (sodium.libera.chat (Nickname regained by services))]
Amit_T has joined #armlinux
Amit_T has quit [Client Quit]
Turingtoast has joined #armlinux
amitk_ has quit [Ping timeout: 245 seconds]
matthias_bgg has quit [Ping timeout: 268 seconds]
torez has quit [Ping timeout: 250 seconds]
iivanov__ has joined #armlinux
iivanov__ has quit [Remote host closed the connection]
iivanov__ has joined #armlinux
iivanov has quit [Ping timeout: 268 seconds]
iivanov__ has quit [Client Quit]
torez has joined #armlinux
headless has quit [Quit: Konversation terminated!]
djrscally has quit [Quit: Konversation terminated!]
djrscally has joined #armlinux
torez has quit [Remote host closed the connection]
ardb has quit [Ping timeout: 252 seconds]
Turingtoast has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
rbutler1728 has quit [Read error: Connection reset by peer]