<_whitenotifier-e>
[scopehal-apps] azonenberg 41e7e1f - Digital and spectrum analyzer channels are now only shown at startup if they were already enabled on the instrument. Fixes #245.
<d1b2>
<louis> @azonenberg I see your change to only enable digital channels if already on; any reason to do that for only digital and not all channels?
<azonenberg>
@louis: i need to improve on this, this was a short term bandaid
<azonenberg>
in particular, i need to consider the case of no channels at all enabled
<d1b2>
<louis> 👍
<azonenberg>
and figure out a logical set of channels to enable in that case
<azonenberg>
right now it enables all analog and any spectrum/digital that were already active
<d1b2>
<louis> I would much prefer deferring to the scope for all channels, so that we can preserve UI state. Then maybe enabling the first analog channel if none are enabled.
<d1b2>
<louis> Bikeshed-worthy 😛
<azonenberg>
Yes, i thin kthat is the best long term solution
<azonenberg>
the other thing to consider is how this plays with e.g. logic analyzers and specans
<azonenberg>
which have no regular analog channels
<azonenberg>
we do not support any pure LA or specan devices yet afaik
<azonenberg>
unless you have the dslogic
<azonenberg>
but it's somethign to consider
<d1b2>
<louis> oh, that's a good point
<d1b2>
<louis> two thorns there of both no-analog devices, and of no-ui devices
<d1b2>
<louis> yes i do have a dslogic and it plays nice with the dsl driver
<d1b2>
<louis> i think the enable-everything behaviour is much less objectionable for LAs
<d1b2>
<louis> or for headless devices in general
<d1b2>
<louis> the major pain point for me with the enable-everything behavior is when i'm probing something on the tek and decide i want to break out glscope, and connecting to it clobbers the set of enabled channels i was using
<d1b2>
<louis> one of the patches in that PR preserves that state at least for analog. need to look at doing that for digital (annoying!!) another day.
<azonenberg>
Yeah makes sense
<azonenberg>
that is best to do globally i think
<azonenberg>
snapshot enabled channels when you connect and restore when you disconnect
<azonenberg>
lots of this stuff is straightforward to implement from a coding perspective
<azonenberg>
but very not straightforward from a UX perspective