08:19 <Shinyzenith> Hi I was redirected to the IRC room for any development questions.

08:19 <Shinyzenith> I am trying to submit a patch for a xwayland bug fix, https://github.com/riverwm/river/issues/455 to be specific

08:19 <Shinyzenith> I have added an if block with overrideRedirectWantsFocus to check if the surface wants focus, I have also called wlr.XdgSurface.fromWlrSurface on the xwayland surface

08:19 <Shinyzenith> the only puzzle piece that I'm stuck on, is how do i set the focus to said surface via the current seat?

08:23 <Shinyzenith> ```zig

08:23 <Shinyzenith>     const surface = wlr.XdgSurface.fromWlrSurface(xwayland_surface.surface orelse return);

08:23 <Shinyzenith>     if (wlr.XwaylandSurface.overrideRedirectWantsFocus(self.xwayland_surface)) {

08:23 <Shinyzenith>         // Focus the surface on the current seat.

08:23 <Shinyzenith> ```

09:03 <novakane> Shinyzenith: you probably want to use the focus() function in Seat.zig

09:03 <novakane> also IIRC you have a fromWlrSurface() in View.zig to get a view from the surface

09:05 <Shinyzenith> Yes I noticed that focusView exists

09:05 <Shinyzenith> I'll try that.

09:11 <Shinyzenith> One last question, how to get the current seat which is in use? I don't notice a seat field in the server struct

09:18 <novakane> what's the function you're trying to add those lines?

09:19 <Shinyzenith> fn handleMap in XwaylandUnmanaged.zig

09:19 <Shinyzenith> I tried server.input_manager.seats.first.?.focus but that threw some node error

09:20 <Shinyzenith> no member named focus in struct std.linked_list.Node

09:22 <novakane> maybe ` const seat = @intToPtr(*Seat, event.seat.data);

09:24 <Shinyzenith> There is no event parameter on the callback?

09:25 <novakane> if you want to use input_manager you need something like this I guess https://github.com/riverwm/river/blob/master/river/View.zig#L528

09:25 <Shinyzenith> I already tried that as stated above

09:26 <Shinyzenith> I guess I did something wrong, I'll keep trying

09:26 <novakane> yeah but server.input_manager.seats.first.?.focus doesn't works because it's a node not a Seat

09:27 <novakane> you need to use node.data

09:27 <Shinyzenith> server.input_manager.defaultSeat().focus(xwayland_view) worked.

09:27 <Shinyzenith> is that alright^ ?

09:27 <Shinyzenith> or should I use the node.data approach

09:28 <novakane> well it would works right now because river can only have one seat right now but ideally you should already write this like if river would handle multiple seats

09:30 <Shinyzenith> alright I'll switch it out for the node approach

09:30 <Shinyzenith> and speaking of seats, I'm trying to write my own compositor and just had a question, are multiple seats really needed?

09:30 <Shinyzenith>     var buf: [11]u8 = undefined;

09:30 <Shinyzenith> and what does the following line do in tinywl.zig?

09:32 <novakane> really needed, I don't know, I mean it doesn't bother me on river but it depends of your setup I guess

09:34 <novakane> I guess that it is used to write a string for something

09:35 <Shinyzenith> Not sure if I understand it's application

09:38 <tiosgz`> Shinyzenith: from the moment you were disconnected [about seats]: <novakane> really needed, I don't know, I mean it doesn't bother me on river but it depends of your setup I guess

09:40 <Shinyzenith> Thank you! I read the irc logs :D

09:40 <Shinyzenith> novakane So the patch didn't work

09:40 <Shinyzenith> it straight up crashes river

09:40 <tiosgz`> ah, ok then :)

09:40 <Shinyzenith> Not sure as to what I did wrong but I'll keep investigating

09:42 <novakane> probably because it's xwayland :P

09:45 <Shinyzenith> XD

09:46 <Shinyzenith>   wlr_xwayland_set_seat(xwayland, seat->wlr_seat);

09:46 <Shinyzenith>   seat_set_focus_surface(seat, xsurface->surface, false);

09:46 <Shinyzenith> this seems to be sways implementation

09:46 <Shinyzenith> and we already set the seat for Xwayland in InputManager

09:46 <Shinyzenith> and in XwaylandUnmanaged I'm just setting the focus

09:46 <Shinyzenith> So I'm not sure what's going wrong

20:08 <vipulogmx> Ifreund: ahmedraniri1994: I'll wait. Just as i waited two years to try it sway just to hate it at last. I'll wait for river to be included in debian stable and to shift to it completely from bspwm. 👍

20:12 <vipulogmx> NickH: you are AMAZING 👍 in trying river in few weeks now thanks to you.

20:14 <vipulogmx> <NickH>:" I also have up to date packages for things like....."<- i definitely will.

22:50 <NickH> vipulogmx: glad to hear it's of use to you. Let me know what other packages you'd like to see.

22:59 <NickH> Two that you may find useful are not in Debian at all are fuzzel and wlopm