<uvos> can some one think of a hildon application with stackable windows thats also fullscreen?
<Wizzup> freemangordon: I will look at this tomorrow but something seems to bring tp into off state oe so
<Wizzup> when I enable mobile data but set ui presence to offline, tpring appears in sphone
<Wizzup> if I turn off mobile data it is gone
Daanct12 has joined #maemo-leste
k1r1t0_N900 has joined #maemo-leste
Langoor has quit [Ping timeout: 246 seconds]
Langoor has joined #maemo-leste
slep has quit [Quit: Gateway shutdown]
shOkEy has quit [Ping timeout: 264 seconds]
xmn has quit [Ping timeout: 255 seconds]
shOkEy has joined #maemo-leste
joerg has quit [Ping timeout: 268 seconds]
joerg has joined #maemo-leste
<freemangordon> what ui presence? IIRC tpring should not appear in accounts ui
* freemangordon checks
ceene has joined #maemo-leste
<freemangordon> so, if tpring appears in presence ui, that's a bug
<freemangordon> also, please provide result of mc-tool show ring/tel/account0
arno11 has joined #maemo-leste
<arno11> the new release works fine on n900: boost freq are ok, we have overclock ootb now, nice
arno11 has left #maemo-leste [#maemo-leste]
<freemangordon> arno11: nice
<freemangordon> Wizzup: also, ring supports neither TP_IFACE_CONNECTION_INTERFACE_PRESENCE nor TP_IFACE_CONNECTION_INTERFACE_SIMPLE_PRESENCE
<freemangordon> so you should not try to check the presence on ring account
<freemangordon> it is either enabled or disabled
elastic_dog has quit [Ping timeout: 246 seconds]
elastic_dog has joined #maemo-leste
DFP has joined #maemo-leste
pere has quit [Ping timeout: 256 seconds]
<Wizzup> freemangordon: will check
pere has joined #maemo-leste
<Wizzup> freemangordon: could be that voicecall program doesn't deal with this properly
<Wizzup> freemangordon: lol so this is a tp-ring special path:
<Wizzup> if (d->shouldForceReconnect()) {
<Wizzup> WARNING_T("Forcing account %s back online immediately", qPrintable(d->account.data()->uniqueIdentifier()));
<Wizzup> d->account->setRequestedPresence(Tp::Presence::available());
<Wizzup> }
<Wizzup> I think I have an idea what is going on
<Wizzup> freemangordon: looks like tp-ring reports presence on dbus
<Wizzup> it looks like voicecall things that it's not even 'online'
<Wizzup> thinks*
<Wizzup> but why would tp-ring even act on things like connecting to wifi, feels like something else is instructing it
<freemangordon> Wizzup: I see nothing like that here
<freemangordon> do you have empathy or something installed?
<freemangordon> also, you *cannot* request presence for tpring
<freemangordon> it does not implement the required interface
<freemangordon> maybe they have that patched in SF
<Wizzup> what causes the tp accounts to connect when connected to the network
<Wizzup> freemangordon: it seems happen to change presence in our repo
<Wizzup> s/happen/happy/
<freemangordon> what presence?
<Wizzup> signal time=1702550119.441680 sender=:1.39 -> destination=(null destination) serial=998 path=/org/freedesktop/Telepathy/Account/ring/tel/account0; interface=org.freedesktop.Telepathy.Account; member=AccountPropertyChanged
<Wizzup> string "CurrentPresence"
<Wizzup> variant struct {
<Wizzup> string "offline"
<Wizzup> uint32 1
<Wizzup> string ""
<Wizzup> }
<freemangordon> no
<freemangordon> wait
<freemangordon> please give me 'mc-tool show ring/tel/account0'
<freemangordon> forget about dbus
<freemangordon> use mc-tool
<freemangordon> "Connects: automatically"
<freemangordon> thats what brings it online
<freemangordon> we should not request online status
<Wizzup> so you want auto-connect off?
<freemangordon> no
<freemangordon> it is ok
<freemangordon> my question is - what exactly the code you pasted ^^^ is supposed to do?
<freemangordon> if (d->shouldForceReconnect()) {
<freemangordon> etc
<freemangordon> tp already does that for us
<Wizzup> that checks if the account is tp
<Wizzup> as
<Wizzup> er
<Wizzup> check if it is tp-ring
<Wizzup> and then it 'forces' it online again
<Wizzup> but that still doesn't have the proper effect
<Wizzup> so, my question is
<Wizzup> what would cause tp-ring to change it's presence or not be online
<Wizzup> what *software* tells it to do that
<freemangordon> tp-ring *cannot* be online, offline, not available, etc
<freemangordon> because it does not support presence :)
<Wizzup> ok, but in dbus it reports that it is 'connecting' and not 'connected'
<freemangordon> connected has nothign to do with being online
<freemangordon> those are orthogonal
<Wizzup> and this tracks having wifi or gprs
<freemangordon> wait
<freemangordon> 'connected' is TpConnection preoperty
<freemangordon> 'online' is TpAccount property
<Wizzup> this yes
<Wizzup> yes
<freemangordon> so, what is the issue? conneciton is not 'connected' or account is not 'online'?
<Wizzup> so I think I know how to 'fix' voicecall, but still I would like to what *what* in maemo triggers presence
<Wizzup> freemangordon: voicecall sees it as not available and unregisters it with sphone
<Wizzup> but this happens only when not on wifi or gprs somehow
<freemangordon> based on the presence?
<freemangordon> where is that code, link please
<Wizzup> ok, but there's still my question ^^ : D
<freemangordon> nothing in maemo triggers presence in general
<freemangordon> each protocol either supports presence or not
<Wizzup> what makes it *act* on wifi/gprs change
<sicelo> layman explanation ... tp-ring is offline when we're in Flight Mode ... maybe it's the answer to the question?
<Wizzup> because they start to connect immediately
<sicelo> so it does support some 'primitive' presence
<Wizzup> and the status applet also knows immediately
<freemangordon> sicelo: what is 'it'?
<Wizzup> it checks for status connected
<sicelo> i mean, tp-ring has a basic type of presence. it can be offline when we're in flight mode for example
<freemangordon> so, which one is false there?
<Wizzup> freemangordon: from dbus-monitor, the last one
<Wizzup> d->account.data()->connectionStatus()
<Wizzup> but I haven't added any debug logging yet
<freemangordon> this is not presence
<freemangordon> so lets stop talking about 'online', ok? because we're mixing the things and that doesn't make it any easier :)
<freemangordon> sicelo: no, tp-ring does not have any concept of presence
<Wizzup> freemangordon: I'm not talking about 'online'
<freemangordon> sicelo: "also, ring supports neither TP_IFACE_CONNECTION_INTERFACE_PRESENCE nor TP_IFACE_CONNECTION_INTERFACE_SIMPLE_PRESENCE"
<Wizzup> I'm just asking what piece of software in maemo makes it so that tp knows when to reconnect, regardless of this issue
<freemangordon> this is mc related
<Wizzup> because it directly correlates with tp-ring saying it's no longer 'connected'
<Wizzup> so tp-mc is icd2 aware?
<freemangordon> maybe
<freemangordon> I dunno
<freemangordon> there might be some remnants
<Wizzup> I always assumed we have something icd2 aware that restarts things
<Wizzup> it could just be netlink for network interfaces
<freemangordon> no
<freemangordon> is there is something, it is over dbus
<freemangordon> or, it could be ofono
<Wizzup> ok
<freemangordon> Wizzup: sorry, my blood sugar level is very low, bbl in 20 minutes
<freemangordon> :)
<Wizzup> take it easy
<Wizzup> so I will check again in a bit (outside atm), but it looks like tp-ring connection status goes into 'connecting' insteaf of 'connected'
<Wizzup> and this causes voicecall to say 'well, you're not ready then'
<Wizzup> god I wish there was a program that takes a dbus-monitor log and makes it easily to filter it
<freemangordon> afaik there is something
<freemangordon> some gnome tool
<Wizzup> I know of the one to explore interfaces
<Wizzup> not one to monitor
<freemangordon> ah, could be
<sicelo> what do you want to filter?
<freemangordon> wait, I'll check what's going on in tp-ring code
* sicelo uses busctl nowadays ... seems versatile
<Wizzup> sicelo: like, I want to see all messages related to ring, but grep won't help since it's all multi line and indented
<Wizzup> sicelo: and 'ring' matches 'string' too, so in general it's pretty stupid
<freemangordon> Wizzup: it seems it changes the status to "connected" when a modem is bound
<Wizzup> I can navigate in vi with seaching for 'ring/' but then there is still a lot of clutter
<sicelo> busctl can probably help ... even has json output, so you can use jq and similar stuff
<Wizzup> freemangordon: well the modem doesn't go anywhere
<Wizzup> sicelo: will check
<freemangordon> see ring_connection_bind_modem()
<Wizzup> freemangordon: when does it change to 'connecting' ?
<freemangordon> on the constructor :)
<freemangordon> *in
<Wizzup> that would mean somethings sets it offline then
<Wizzup> maybe auto-reconnect is exactly the opposite of what we want
<freemangordon> I'd recommend to start tpring from cmdline with logs enabled
<freemangordon> could be
<Wizzup> to me it seems like tp cm just turns it off
<sicelo> only shortcoming of busctl is that you need to be root in order to monitor. otherwise it's flexible
<Wizzup> (but I didn't see that on dbus)
<Wizzup> sicelo: even for non system bus?
<sicelo> no, only system :-)
<Wizzup> yeah none of the tp stuff is on system bus
<Wizzup> lol yep, tp-ring has a new pid now that I reconnect to wifi
akossh has quit [Ping timeout: 256 seconds]
<Wizzup> ok, I will look at this later
<Wizzup> tp-ring logs tp_base_connection_change_status: was 0, now 2, for reason 1'
akossh has joined #maemo-leste
<Wizzup> 'mcd_account_connection_proceed_with_reason: ring/tel/account0 wants to connect, but we're offline, queuing it up'
<Wizzup> yeah it uses GNetworkMonitor to see if we're 'at least partially online'
<Wizzup> ok, so the problem is in mission control
<Wizzup> not in voicecall manager or ring
akossh has quit [Ping timeout: 256 seconds]
<freemangordon> yep, I was about to say that maybe tp/mc oversmarts itself
<freemangordon> we shal check what SF are doing
* Wizzup debugged all of that on the screen+keyboard of the d4 btw
<freemangordon> why?
<Wizzup> because it was sunny out :)
<freemangordon> heh
<Wizzup> also having to debug a problem that only shows up when ssh doesn't work is tricky
<freemangordon> ah
<freemangordon> yeah
<freemangordon> Wizzup: which file is that?
<Wizzup> ./src/mcd-account-connection.c
<Wizzup> function mcd_account_connection_proceed_with_reason
<freemangordon> ok
<Wizzup> my bet is that this code was never in nokia ;)
<freemangordon> "...use GNetworkMonitor (which is also pluggable),"
<Wizzup> we don't want to fake a network connection for cm
<Wizzup> then it will try to online others
<Wizzup> we want a property to let some cm's connect anyway
<freemangordon> we shall check how do they overcome that in SF
<Wizzup> I don't think they use tp-ring, but ok :)
<Wizzup> voicecall manager has an ofono backend
<freemangordon> ah
<Wizzup> see 957795838715b3b95f2bf8bc116b2328bf6a2881,
<Wizzup> A possible refinement in future Tp versions would be a way for a CM
<Wizzup> to tell MC "this connection does its own connectivity-monitoring,
<Wizzup> so don't kick it when we get disconnected". For now, we assume that
<Wizzup> everything needs the Internet, unless it's one of the accounts that
<Wizzup> wouldn't previously have been bound to a connection (i.e.
<Wizzup> _mcd_account_needs_dispatch() returns FALSE).
<freemangordon> yeah, I was about to look in the code
<freemangordon> to see if we can workaround that
<Wizzup> in ring maybe?
<freemangordon> lemme see
<Wizzup> seems to be 'always_dispatch'
<Wizzup> /* In addition to affecting dispatching, this flag also makes this
<Wizzup> * account bypass connectivity checks. */
<Wizzup> gboolean always_dispatch;
<Wizzup> ./src/mcd-account-config.h:#define MC_ACCOUNTS_KEY_ALWAYS_DISPATCH "always_dispatch"
<freemangordon> is that some account property?
<Wizzup> trying now
<Wizzup> and yes
<Wizzup> there is also an 'always on' property
<Wizzup> not sure if that's also helpful
<Wizzup> looks like now
<Wizzup> not
<Wizzup> either I did something wrong or it did not work
<Wizzup> I set always_dispatch=false
<freemangordon> no, it should be true
<Wizzup> but then needs_dispatch will be true
<freemangordon> ah
<freemangordon> /* special case flag (for ring accounts, so far) */
<Wizzup> which one is this
<freemangordon> p, li { white-space: pre-wrap; } always_dispatch
<Wizzup> right
<Wizzup> let me try again
<freemangordon> but you shall set it to true
<freemangordon> it defaults to false
<freemangordon> see p, li { white-space: pre-wrap; } mcd_connection_need_dispatch
<Wizzup> ah
<Wizzup> if (mcd_connectivity_monitor_is_online (
<Wizzup> mcd_account_get_connectivity_monitor (account)) || _mcd_account_needs_dispatch (account))
<Wizzup> ok
<freemangordon> mhm
<Wizzup> ok, just called myself with wifi off, we're good, but we'll need to set this
<freemangordon> this should be part of ring account creation, no?
<Wizzup> yeah
<freemangordon> like, who created ring/tel/account0?
<Wizzup> we don't have a 'ring account creation' process atm :)
<freemangordon> mhm
<Wizzup> well, this is progress, I'm going to take a break for a moment
<freemangordon> mhm
<Wizzup> so where would we want to make the account?
parazyd has quit [Ping timeout: 268 seconds]
parazyd has joined #maemo-leste
<uvos> would make sense if the sphone plugin did this OR?
xmn has joined #maemo-leste
<freemangordon> uvos: no, I don;t think sphone should deal with tp accounts
<freemangordon> Wizzup: who will depend on tp-ring?
<freemangordon> BTW, IIRC, back then tp-ring was creating the account on installation
<freemangordon> Wizzup: wait...
<freemangordon> look at mcp_account_manager_ring_init()
<freemangordon> why is that not called?
<sicelo> arno11 - when you have a chance, please checkout https://github.com/sicelo/libcmtspeechdata/commits/compile-fixes/ and see if it works fine. if so, i will make an MR
<sicelo> basically tries to fix the numerous (annoying) compile errors for cmtspeech
Daanct12 has quit [Quit: WeeChat 4.1.2]
<sicelo> and of course, anyone else is free to look at the commits. tbf, that code can do with some serious refactoring :p
<freemangordon> Wizzup: I think I found what's going on
<freemangordon> ring mc plugin is not installed, IIUC
<freemangordon> that's why we shall create the account by hand
<freemangordon> while rpm installs %{_libdir}/mission-control-plugins.0/mcp-account-manager-ring.so :)
<freemangordon> dh_missing: warning: usr/lib/x86_64-linux-gnu/mission-control-plugins.0/mcp-account-manager-ring.so exists in debian/tmp but is not installed to anywhere
<freemangordon> dh_missing: warning: usr/share/man/man8/telepathy-ring.8 exists in debian/tmp but is not installed to anywhere
<freemangordon> :)
<freemangordon> shall I fork?
<uvos> freemangordon: i agree sphone should not deal with tp accounts
<uvos> but ring is special since its not a "real" account, and simply has to exist any where sphone runs
<freemangordon> uvos: anyway, I found what the issue is
<freemangordon> yes, but tp-ring debian packaging is broken
<uvos> ok
<freemangordon> that's why no account is created
<uvos> ok
<freemangordon> going to fix that
<uvos> thats fine then
<uvos> i just want to ensure it works if only tp sphone (and vcm) is installe
<uvos> d
<uvos> since imo it should
<freemangordon> it will
<freemangordon> well, you need telepathy as well :)
<freemangordon> ah, 'tp'
<freemangordon> yeah
<uvos> you need ofono too
<uvos> but you know what i mean
<freemangordon> well
<freemangordon> yeah
<freemangordon> I just installed empathy(and friends) from my d4
<freemangordon> *uninstalleds
pere has quit [Ping timeout: 264 seconds]
arno11 has joined #maemo-leste
<arno11> sicelo: currently looking @cmtspeech
<arno11> wooo, indeed lot of errors fixed
<arno11> let me try it
<Wizzup> freemangordon: what does this mc ring plugin do? set this property?
<Wizzup> freemangordon: but yes, we can fork if we have to
<freemangordon> I already did
<freemangordon> but it fails to build :)
<freemangordon> see ci
<freemangordon> I don;t get what's wrong with it
<Wizzup> let me take a quick look
<freemangordon> fails to find the tag, but it is there
<Wizzup> I am pretty sure I knpw
<Wizzup> just a sec
<Wizzup> freemangordon:
<Wizzup> maemo/chimaera != chimaera
<Wizzup> :)
<freemangordon> oh
<freemangordon> :)
<freemangordon> thanks
<freemangordon> will fix it
<freemangordon> Wizzup: I think you shall delete ring account before upgrade
<freemangordon> also, we shall start tp-ring from xsession, mlocked etc. see RING_REALTIME and RING_MEMLOCK
<Wizzup> mhm
<freemangordon> RING_PERSIST=1 as well
<Wizzup> I need to go do some other things first, I'll be back in an hour or so
<Wizzup> feel free to hack away
<freemangordon> well, I don;t see what more I can do now
<Wizzup> maybe write an xsession file, but not sure where it would go
<freemangordon> we shall decide first who depends on tp-ring
<freemangordon> connectivity mp?
<Wizzup> yeah, I don't know if we need another maemo-telephony pkg, or if the existing one works
<freemangordon> to me connectivity is ok
<freemangordon> so xsession file belongs there
<Wizzup> sounds good
<arno11> sicelo: works fine and commit 51a6f6c fixed the random weird tone issue apparently :) well done man
<freemangordon> the fuck, account is still not created :(
<Wizzup> are you sure that should make the account?
<Wizzup> freemangordon: I think you can just do mc-tool add ring/tel account0 -p always_dispatch=true or so (note I didn't test this and maybe even got the var name wrong)
<Wizzup> actually ignore the '-p' too
<freemangordon> ugh:
<freemangordon> could not load plugins from /usr/lib/mission-control-plugins.0: Error opening directory ?/usr/lib/mission-control-plugins.0?: No such file or directory
<freemangordon> that's wrong dir
<freemangordon> it should be /usr/lib/$arch/mission-control-plugins.0
arno11 has left #maemo-leste [#maemo-leste]
<sicelo> arno11, wow! i only compile-tested this. actually i'm surprised there's a positive 'visible' effect. i was only hoping that i didn't break anything or introduce problems.
<sicelo> Wizzup: so there's a PR for cmtspeech - https://github.com/maemo-leste/libcmtspeechdata/pull/3
pere has joined #maemo-leste
<Wizzup> will checl later tonight ty
<freemangordon> Wizzup: tp-ring creation is fixed
ceene has quit [Ping timeout: 268 seconds]
k1r1t0_N900 has quit [Ping timeout: 256 seconds]
k1r1t0_N900 has joined #maemo-leste
k1r1t0_N900 has quit [Ping timeout: 276 seconds]
k1r1t0_N900 has joined #maemo-leste
Zorrot has joined #maemo-leste
Zorrot has quit [Client Quit]
<sicelo> Wizzup: please hold off merging. seems there's a compilation error that only shows up on armhf, but not amd64. i want to fix that one too
<Wizzup> okay, sure
<Wizzup> freemangordon: so I delete the account and apt update / upgrade ?
elastic_dog has quit [Remote host closed the connection]
elastic_dog has joined #maemo-leste
elastic_dog has quit [Client Quit]
<Wizzup> freemangordon: btw, if tp-ring autostarts in -devel it means calls will no longer work
elastic_dog has joined #maemo-leste
<Wizzup> (tp-ring will just hang up if there is no tp client, and sphone uses ofono directly in -devel)
xmn has quit [Read error: Connection reset by peer]
arno11 has joined #maemo-leste
<uvos> so new sphone has /usr/share/sphone/sphone.ini.d and should update the combobox when a backend is added or removed without needing to reopen the window
<uvos> the latter is untested
<Wizzup> great, I'll rebase
xmn has joined #maemo-leste
xmn has quit [Read error: Connection reset by peer]
<sicelo> Wizzup: https://github.com/maemo-leste/libcmtspeechdata/pull/4 ... this one has better fixes for the compilation errors (compiles equally well with both amd64 and armv7)
DFP has quit [Quit: Leaving]
arno11 has left #maemo-leste [#maemo-leste]
<freemangordon> Wizzup: well, one shall install tp-ring by hand
<freemangordon> nothing depends on it still
<freemangordon> sicelo: next time you'd better force-push, instead of creating new PR
<freemangordon> it is easier to review that way
Juest has quit [Ping timeout: 276 seconds]
elastic_dog has quit [Ping timeout: 260 seconds]