rvalue has quit [Read error: Connection reset by peer]
rvalue has joined #u-boot
<sng>
sjg1: tbh, i do not remember if i attempted to build initially without a toolchain present. but even if i did, fwiw, when i did discover this directory, it had a complete build per board. but now that i remove it before a build, things work as expected.
monstr has joined #u-boot
monstr has quit [Ping timeout: 252 seconds]
goliath has joined #u-boot
xypron has quit [Server closed connection]
xypron has joined #u-boot
monstr has joined #u-boot
monstr has quit [Read error: Connection reset by peer]
<sjg1>
sng: Probably you didn't then, since without a toolchain you would not see a full build. I'm actually not sure what is going on, but -m clears out the dir if you need to. If it happens again, could you send a bug report with the steps to repro, if possible?
mckoan|away is now known as mckoan
<sng>
sjg1: okay. let me try to reproduce this by not deleting the .bm-work and then checking what happens. will get back on this in a day or two
ldevulder has joined #u-boot
<sjg1>
sng: OK thank you...BTW one thing I did notice is that building before the config.h removal (e.g. v2024.04) and then building -master today, can cause a problem (the deps files stick around and even make defconfig doesn't fix it). But in that case buildman would (should?) report an error
mmu_man has joined #u-boot
enok has joined #u-boot
redbrain has quit [Server closed connection]
redbrain has joined #u-boot
enok has quit [Quit: enok]
enok71 has joined #u-boot
enok71 is now known as enok
sszy has joined #u-boot
stefanro has quit [Remote host closed the connection]
stefanro has joined #u-boot
stefanro has quit [Client Quit]
stefanro has joined #u-boot
stefanro has quit [Client Quit]
prabhakalad has quit [Quit: Konversation terminated!]
prabhakalad has joined #u-boot
stefanro has joined #u-boot
enok has quit [Ping timeout: 256 seconds]
mmu_man has quit [Ping timeout: 272 seconds]
mmu_man has joined #u-boot
enok has joined #u-boot
mmu_man has quit [Ping timeout: 264 seconds]
greyltc has quit [Server closed connection]
greyltc has joined #u-boot
enok has quit [Ping timeout: 268 seconds]
naoki has quit [Quit: naoki]
cottsay has quit [Server closed connection]
cottsay has joined #u-boot
alan_o has quit [Remote host closed the connection]
alan_o has joined #u-boot
Jones42 has joined #u-boot
wak has quit [Server closed connection]
wak has joined #u-boot
monstr has joined #u-boot
monstr has quit [Ping timeout: 252 seconds]
cbmuser has quit [Server closed connection]
cbmuser has joined #u-boot
pivi has quit [Ping timeout: 268 seconds]
Stat_headcrabed has joined #u-boot
pivi has joined #u-boot
eballetbo has quit [Quit: Connection closed for inactivity]
shoragan has quit [Quit: quit]
shoragan has joined #u-boot
monstr has joined #u-boot
enok has joined #u-boot
<Tartarus>
sjg1: apalos promised me comments on the fdt one and then went on vacation :|
slobodan has joined #u-boot
enok has quit [Remote host closed the connection]
dsimic has quit [Ping timeout: 252 seconds]
dsimic has joined #u-boot
tgamblin has quit [Ping timeout: 252 seconds]
goliath has quit [Quit: SIGSEGV]
<cambrian_invader>
quinq: sorry, "constant" was the wrong word to use; I meant stuff that goes in .bss
tgamblin has joined #u-boot
<kabel>
Tartarus: I've sent R-b tags to lixkel's patch series, finally adding Turris 1.x support (https://patchwork.ozlabs.org/project/uboot/list/?series=409894). I was actually reviewing his work while he was doing it, but forgot to send the tags...
monstr has quit [Ping timeout: 252 seconds]
<Tartarus>
kabel: OK. I don't want to have them get lost, so I'll go ping Sinan Akman again if he has time to test things yet
<kabel>
Tartarus: thx
vagrantc has joined #u-boot
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
mckoan is now known as mckoan|away
<sjg1>
Tartarus: Oh dear...sounds like approval to me
<derRichard>
Tartarus: regarding "ext4: Fix zalloc()", do you have an idea why memalign() crashes for lage sizes? that's why i added the check against CONFIG_SYS_MALLOC_LEN.
<Tartarus>
derRichard: I don't, sorry
<Tartarus>
sjg1: I mean, we had a super long discussion about this ages ago, I know you know, so I'm not in a hurry to change this yet again unless everyone is clear on what's being changed / why.
goliath has joined #u-boot
<derRichard>
Tartarus: i fear it's another integer overflow, but in u-boot's malloc() implementation
qsx has quit [Server closed connection]
qsx has joined #u-boot
<Tartarus>
Could be? But moving over to the common allocation wrapper will help :)
<derRichard>
also with kzalloc() it crashes upon super large sizes. as i said, i think it's a bug in u-boot's malloc itself
<Tartarus>
RIght, two things. First thing move to common allocation wrapper, second deal with malloc itself
<derRichard>
ok
<derRichard>
i'll anyway send another round of patches soon. found more exploitable bugs in filesystem code.
<Tartarus>
OK. If possible, please expand the fs tests to catch these once fixed
<derRichard>
Tartarus: i can try but the filesystem images as usually hand crafted
<Tartarus>
derRichard: In those cases we may need to something-something about how to make those images, yes. If it's not also easily scriptable.
<derRichard>
Tartarus: i'll wrap my head around. :)
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
tgamblin has joined #u-boot
manchaw has quit [Server closed connection]
manchaw has joined #u-boot
grs has joined #u-boot
persmule has quit [Remote host closed the connection]
edwinistrator23 has quit [Ping timeout: 246 seconds]
frieder has quit [Remote host closed the connection]
persmule has joined #u-boot
naoki has joined #u-boot
mmu_man has quit [Remote host closed the connection]
Stat_headcrabed has quit [Quit: Stat_headcrabed]
alperak has quit [Quit: Connection closed for inactivity]
Jones42 has quit [Ping timeout: 272 seconds]
LeSpocky has quit [Server closed connection]
LeSpocky has joined #u-boot
ldevulder has quit [Quit: Leaving]
<derRichard>
Tartarus: so, i found the malloc issue. wenn you try to allocate a lot of memory. e.g. 2^32 bytes. malloc_extend_top() will calculate sbrk_size and calls sbrk(sbrk_size)
<derRichard>
but type increment parameter of sbrk is ptrdiff_t
<derRichard>
-> integer overflow, we allocate less than requested but do not fail -> boom
<derRichard>
when i change the type to e.g. ssize_t, it works as expected (malloc() returns NULL)
<derRichard>
i think it is also safe to let malloc always fail if the requsted size is more than PTRDIFF_MAX
<derRichard>
*requested
eballetbo has quit [Quit: Connection closed for inactivity]
<Tartarus>
OK, thanks for digging
<derRichard>
looks like barebox has the very same bug.
<derRichard>
their sbrk() takes also a ptrdiff_t type. and they also use dlmalloc
<Tartarus>
I haven't replied to the ML yet since the CI run +- just finished
* derRichard
looks
<derRichard>
Tartarus: can i fetch from somewhere the fs image?
<derRichard>
i bet mkfs.ext4 set more feature flags than the u-boot implementation supports
<derRichard>
E AssertionError: assert '1048576 bytes written' in '1048576 bytes read in 1 ms (1000 MiB/s)Unsupported RO compat features found 00000010, not writing.\r\r\n** Error ext4fs_write() **\r\r\n** Unable to write file /1MB.file.w **'
<derRichard>
ah here
goliath has quit [Quit: SIGSEGV]
<derRichard>
so, it hates EXT4_FEATURE_RO_COMPAT_GDT_CSUM
<derRichard>
hm, u-boot's ext4 has no meta data checksum support, but block group checksum, really?
* cambrian_invader
should really implement metadata checksums at some point
sakman has joined #u-boot
<derRichard>
speaking of ext4, are you aware that ext4fs_write() is not atomic? i.e. when you overwrite a file, it first unlinks the old one. you can end up with no file at all.
<derRichard>
i'm not sure whether all users of that api know this