18:32 <jonasschwoebel[m> digetx: Hi i submitted a pullrequest to grate today.

18:32 <jonasschwoebel[m> e.g.

18:32 <jonasschwoebel[m> But i don't understand some output from Github CI checkpatch.

18:34 <jonasschwoebel[m> I have no idea hot to make a this struct const

18:39 <jonasschwoebel[m> running

18:39 <jonasschwoebel[m> ./scripts/checkpatch.pl --no-tree --strict drivers/power/supply/surface-rt-battery.c

18:39 <jonasschwoebel[m> on my computer doesn't show this error.

18:47 <DavidHeidelberg> try running it as ./scripts/checkpatch.pl --no-tree --strict -g HEAD~NUMBER_OF_YOUR_COMMITS

18:47 <DavidHeidelberg> (commits inside your MR)

19:10 <jonasschwoebel[m> Thanks for the idea but it only shows easy fixable errors.

19:18 <jonasschwoebel[m> "WARNING: struct should normally be const" triggers 15 times.

19:18 <jonasschwoebel[m> I have 15 structs which aren't const. -> everywhere it can find the word "struct" it will throw an error

19:30 <digetx> jonasschwoebel[m: hi, you can ignore those warning, I'll fix them and other minor things after the merge

19:40 <jonasschwoebel[m> o.k. thx, Do you know why it shows this warnings?

19:40 <jonasschwoebel[m> What about "WARNING: line over 80 characters" is it a rule or a recommendation?

19:40 <jonasschwoebel[m> Right now i think it a checkpatch bug but if that isn't the case I want to know how to write "correct" code ;)

19:40 <jonasschwoebel[m> Looking at other drivers you will find some that strictly cut before 80 and others go up to 110

19:50 <DavidHeidelberg> jonasschwoebel recent decision was 120 chars max?

19:50 <DavidHeidelberg> but I guess most of kernel devs sticking up with 80 chars :D

19:50 <DavidHeidelberg> plus, of course, code which has been written before the 120 chars rule

19:52 <jonasschwoebel[m> 120 would be nice.

19:52 <jonasschwoebel[m> https://www.kernel.org/doc/html/latest/process/coding-style.html#breaking-long-lines-and-strings

19:52 <jonasschwoebel[m> Also checkpatch says 80 too

19:53 <jonasschwoebel[m> * 120 would be nice.

19:53 <jonasschwoebel[m> "The preferred limit on the length of a single line is 80 columns." -

19:53 <jonasschwoebel[m> Also checkpatch says 80 too

19:53 <jonasschwoebel[m> https://www.kernel.org/doc/html/latest/process/coding-style.html#breaking-long-lines-and-strings

19:59 <DavidHeidelberg> https://www.phoronix.com/scan.php?page=news_item&px=Linux-Kernel-Deprecates-80-Col

19:59 <DavidHeidelberg> and my bad, not 120 chars, just 100 :)

20:00 <digetx> you can always check what other drivers do for a similar code, the main rule is that the code must be readable, the 80 chars is the default limit, the limit was relaxed recently because the warning was too noisy for the code that doesn't fit into the limit without hurting readability

20:01 <jonasschwoebel[m> my local checkpatch has already 100 columns as limit.

20:01 <jonasschwoebel[m> Does Github use an older/bugged version?

20:02 <digetx> it uses strict rules

20:02 <digetx> --strict option

20:03 <DavidHeidelberg> digetx he did too...

20:03 <DavidHeidelberg> it's possible, I took the script from the GIthub action market... it was suggesting to think, it'll be me maintained :/

20:07 <DavidHeidelberg> btw. clang is ready, compile tested :)

20:14 <digetx> cool, thank you

20:56 <DavidHeidelberg> btw. as I see all these ugly wrappers around checkpatch, maybe it could have option --json and just dump json file for IDE or CI

20:57 <DavidHeidelberg> but I'm very afraid to ask about it on ML, because I feel stones flying in the air :D