<d1b2>
<fredzo_72653> Hi @azonenberg , I'm starting to work on TinySA driver and I was thinking: should there be a dedicated entry in the "Add" menu for specans only instruments?
laminar-oss has quit [Quit: laminar-oss]
laminar-oss has joined #scopehal
laminar-oss has quit [Changing host]
laminar-oss has joined #scopehal
laminar-oss has quit [Quit: laminar-oss]
laminar-oss has joined #scopehal
laminar-oss has joined #scopehal
laminar-oss has quit [Changing host]
laminar-oss has quit [Quit: laminar-oss]
<d1b2>
<azonenberg> Probably long term, but near term just make it treated as an oscilloscope
<d1b2>
<azonenberg> We have a lot of duplicated code for different instrument drivers that i am trying to unify
<d1b2>
<azonenberg> e.g. in file load/save
<d1b2>
<azonenberg> i don't want to make the problem worse right now
<d1b2>
<azonenberg> the oscilloscope class already has methods for a frequency-domain timebase
<d1b2>
<azonenberg> realistically a SA is just a scope that outputs amplitude vs frequency instead of amplitude vs time waveforms
<d1b2>
<azonenberg> and a RTSA doesn't even always do that
<d1b2>
<azonenberg> it makes sense for them to share most of the code
benishor has quit [Quit: tah tah!]
benishor has joined #scopehal
<d1b2>
<fredzo_72653> OK no problem, I'll stick to that and may be just create a base class for SCPISA that can be used later if we create an dedicated entry.
<d1b2>
<azonenberg> yeah you can make a base class derived from scpioscilloscope if that makes sharing functionality easier
laminar-oss has joined #scopehal
laminar-oss is now known as Guest4758
Guest4758 has quit [Quit: Guest4758]
Guest4758 has joined #scopehal
Guest4758 has quit [Client Quit]
Guest4758 has joined #scopehal
Guest4758 has quit [Remote host closed the connection]