<d1b2>
<josHua> looks neat! two thoughts: 1) I am not sure that badges should be used as buttons? 2) I wonder if measured voltage should be a badge, so that you can see it even when the supply is collapsed
<d1b2>
<azonenberg> Yeah these are things i'm going to play with once i merge. I was going to be doing major rework of the power supply channel dialog anyway
<d1b2>
<azonenberg> this is a good time to do it
<d1b2>
<azonenberg> I'm just busy setting up my new router right now and will be busy with dad stuff most of tomorrow
<d1b2>
<azonenberg> so might not have time to look at the code until tomorrow after the little one goes to bed
<d1b2>
<fredzo_72653> Thanks @josHua 🙂 1/ Yes the on/off buttons are both very practical and dangerous in case of a miss-click... I think we should make that configurable 2/ That was the purpose of the CV/CC badge with CC being red like in PSU dialog. But we could also have the the color of measured value change when it is too far from set value. I wouldn't make it a badge though to keep it consistent with set value, IDK 🤷♂️
pirate has quit [Ping timeout: 252 seconds]
pirate has joined #scopehal
<d1b2>
<azonenberg> Yeah I like on/off buttons but i wouldnt make them badges
<d1b2>
<azonenberg> i'd use a dedicated switch widget
<d1b2>
<azonenberg> The potential for misclicks/mistypes is also why, if you look at the existing PSU dialog, you need to click confirm after changing a value for voltage/current
<d1b2>
<azonenberg> rather than auto applying like most other widgets
<d1b2>
<azonenberg> that was an explicit speed bump to reduce the chances of frying stuff
<d1b2>
<fredzo_72653> Oh yes nice, I didn't realize that! Yes a toggle on/off button would be nice, but I could not find such a widget in imgui 😕 Maybe that?: https://github.com/cmdwtf/imgui_toggle
<d1b2>
<josHua> right click and “on” could be better
<d1b2>
<josHua> or a drop down box of on/off
<d1b2>
<josHua> if right click becomes idiomatic in the stream browser then you could also put other things there. like switching between supply and load mode for supplies that are 1Q-but-you-get-to-choose-which-one (like ch1 and ch2 on my gpp4323)
<d1b2>
<fredzo_72653> I like the idea of the drop down for that we could make it look like a badge and keep the overall aspect more consistent + it's easier to find out.
<d1b2>
<fredzo_72653> I'll give it a try
<d1b2>
<aleksorsist> Just tried cloning scopehal-apps master branch w/ command git clone --recursive https://github.com/ngscopeclient/scopehal-apps.git and got this error: Cloning into '/home/eevengers-dev0/scopehal-apps/lib/canvas_ity'... git@github.com: Permission denied (publickey). fatal: Could not read from remote repository. Is there some issue with pulling canvas_ity that I'm not aware of?
<d1b2>
<aleksorsist> I just cloned it into the libs directory just fine, maybe a submodule issue?
<d1b2>
<azonenberg> Let me have a look. canvas_ity is a recent addition, i wonder if something is off with the submodule path there