<azonenberg>
joshua_: It is a useful vna client. Settings for controlling things like sweep range and RBW may need a bit of work but should be similar to the APIs used on specans. i have to check what i've implemented so far
<azonenberg>
I found and fixed the bug with parallel downloads, i was sending bogus channel indexes
<azonenberg>
You can use S-parameters coming off a VNA in all the usual filters that work with s-params like channel emulation/de-embed, measuring group delay, displaying unwrapped phase, and most recently 2-port shunt through PDN measurements
Degi has quit [Ping timeout: 252 seconds]
<Darius>
it's OK, the NanoVNA doesn't have any selectable filters so that part is easy ;)
<azonenberg>
the most notable missing feature right now is that the touchstone export filter does not support saving .s1p files
<azonenberg>
or anything other than s2p
<azonenberg>
i need to revamp the export logic to support arbitrary port counts
<d1b2>
<azonenberg> Quick update: We've just received the previously promised $5000 donation from the ThunderScope project! Thanks @aleksorsist
<d1b2>
<azonenberg> as of now, $3812 has been paid to hired artists and GUI design consultants (work that I funded out of pocket in anticipation of eventually getting outside funding) and $1187 is available to sponsor future work
<d1b2>
<azonenberg> My current intention is for the remainder of the donation to also go to graphical-type work including remaining filter graph icons, additional iterations on existing icons, revamping the toolbar, and creating an application logo/icon
<d1b2>
<azonenberg> Longer term, if we start to get more donations, we can start thinking about sponsoring developers as well. So far there's not enough funding to allow that but I'd certainly love to be able to in the future
d1b22 has joined #scopehal
d1b2 has quit [Read error: Connection reset by peer]
d1b22 is now known as d1b2
<d1b2>
<aleksorsist> Really glad to be able to help move ngscopeclient forward and will continue to help in every way that I can!
<d1b2>
<azonenberg> Totally unrelated, something seems to have failed in my Digilent analog discovery pro. I had an ADP3450 that digilent sent me years ago as a dev unit, i wrote a scopehal driver for it that worked as a basic scope but i dont think i ever implemented the other features
<d1b2>
<azonenberg> recently it start making a lot of clicking noises, like relays constantly toggling. makes me think power supply issue but i have not had time to investigate
<d1b2>
<azonenberg> for now its unplugged on the bench
<d1b2>
<azonenberg> (i had been using it as a slow scope for $dayjob stuff to sniff uarts and such without burning channels on any of the fancier scopes)
<_whitenotifier-4>
[scopehal] azonenberg 3c2650f - Added Doxygen comments to DCAEdgeTrigger, refactored to new parameter model
<_whitenotifier-4>
[scopehal] azonenberg def53bf - Added more doxygen comments
<d1b2>
<azonenberg> progress! only three and a half screens full of tabs of files to go through
<d1b2>
<azonenberg> until all of libscopehal (not scopeprotocols or ngscopeclient) will have a reasonable level of doxygen coverage
<d1b2>
<azonenberg> @fredzo_72653 ok reviewing your modbus PR now
<d1b2>
<azonenberg> i don't see a matching PR for scopehal-docs for those drivers?
<d1b2>
<azonenberg> (also, the alientek driver in the docs is out of alphabetical order please fix at the same time)
<d1b2>
<fredzo_72653> OK will do 👍
<d1b2>
<azonenberg> @fredzo_72653 Also other feedback (I'm fixing in the merge, but keep in mind for the future)
<d1b2>
<azonenberg> Use %zu when printing a size_t, %llu assumes "unsigned long long" is size_t which is not the case on all platforms. %zu is guaranteed to be whatever type size_t is
<d1b2>
<azonenberg> and when copying an old file to make a new driver update the copyright year to reflect the current year
<d1b2>
<azonenberg> (also we're removing the library version number from the file header moving forward to avoid it getting out of date, i've been slowly taking them out as i go make other changes across the code)
<d1b2>
<azonenberg> also curly braces go on their own line, if you have a comment at the beginning of a block then it should be indented and on the next line rather than the same line as the opening brace
<d1b2>
<azonenberg> e.g. c++ if(foo) { //foo not if(foo) { // foo
<_whitenotifier-4>
[scopehal] fredzo 6c986b9 - Added ModbusInstrupent base class for instruments using modbus communication protocol. Added support for Rident RD power supplied (tested with RD6006).
<_whitenotifier-4>
[scopehal] fredzo f89443a - Made register adresses an enum.