<lain>
azonenberg: correct @ QueueHandle is tied to a specific family even on Metal
<lain>
d'oh @ spaces for indent, I need to update my vscode indent settings for the scopehal workspace lol
<lain>
azonenberg: or more specifically a QueueHandle is tied to a specific queue within a specific family
<lain>
azonenberg: I agree we should be more choosy about queue allocation, I should be able to patch that tomorrow. I'll poke you first to make sure we're on the same page as to how it should behave
<darthrake>
azonenberg: for me ${SPIRV_SHADERS} is empty.
<darthrake>
(m1 macos 12.6 cmake 3.24.1)
<darthrake>
at least for me on a clean build the shaders don't exist yet, so the glob is empty. rerunning cmake apter the shaders are build fixes this (not a cmake guru). replacing the glob by a explicit list solves this for me.
<darthrake>
azonenberg: all in all: congratulations, so far ngscopeclient does actually run quite well on macos.
<darthrake>
nitpick: hidpi /retina doesn't seem to be supported. setting io.FontGlobalScale = 0.5f and introducing a scale to the FontManager does seem to help quite a bit though. the glfw implementation does set the window scale already for you.
<tnt>
huh ... isn't it _worse_ in the second case ?
<d1b2>
<Darius> I think that's what they mean in that the fonts need to be scaled by 50%
<darthrake>
I haven't touched the scales yet.. have a look at the rest of the interface fonts..
<d1b2>
<ehntoo> looks like I've been beaten to looking at the macos issues. we can probably tweak the cmake setup so that the shaders in scopeprotocols are a custom target that we can add as a dependency or something, but an explicit list is a good solution for now.
<d1b2>
<ehntoo> an alternate solution I tested quick locally, but I think there's a better solution leaning on cmake more to make the compiled shaders a library target of some sort over in the protocolshaders CMake file. I'll play with it some more after work tonight. For now the list in #537 is fine by me.
massi has quit [Remote host closed the connection]
<azonenberg>
hmmm
<azonenberg>
yeah for now i want to get it building
<azonenberg>
as far as hidpi goes, imgui is aware of scaling but we might be missing it in a few spots. i think font sizes are in pixels not scaled units so that is probably a good starting point
<azonenberg>
if anyone wants to send a PR for better hidpi i'll merge if it doesnt break things on my system. Can't test as i don't have any hidpi hardware here myself
<azonenberg>
i have a bunch of 24" 1080p displays, a 15" 1080p, and my 43" 4K
<_whitenotifier-2>
[scopehal-apps] Felix Schneider 1cedf96 - ngscopeclient: change SPIRV_SHADERS to be an explicit list instead of a cmake glob
<_whitenotifier-2>
[scopehal-apps] azonenberg bd1a84e - Merge pull request #537 from schneider-engineering/feature/fix_SPIRV_SHADERS_path ngscopeclient: change SPIRV_SHADERS to be an explicit list
<azonenberg>
the way it's built our whole event loop in the main thread will freeze up if we call it from the main thread
<azonenberg>
which is why i'm looking at the potential for maybe just shoving that library into a separate process we can talk to via pipes or something
<azonenberg>
also we need to consider how any/all such things will interact w/ the app in fullscreen state
<azonenberg>
We dont want file browser dialogs to be hidden because they're not using the same window library we are and are thus not recognized as part of the same fullscreen platform