azonenberg changed the topic of #scopehal to: libscopehal, libscopeprotocols, and glscopeclient development and testing | https://github.com/glscopeclient/scopehal-apps | Logs: https://libera.irclog.whitequark.org/scopehal
Degi_ has joined #scopehal
Degi has quit [Ping timeout: 268 seconds]
Degi_ is now known as Degi
azonenberg has joined #scopehal
<azonenberg> Welp, i'm back
<azonenberg> Still bringing services online
<azonenberg> As part of the CI revamp I am converting my VM server from vanilla Xen on Debian to xcp-ng
<azonenberg> it's a fair bit of work to do each VM one at a time because the Ceph setup I have, while technically compatible, requires a lot of manual CLI work to link each ceph RBD to a storage pool object xcp-ng can see
<azonenberg> (for CI-created VMs we will probably use a different provisioning strategy, I already have that kinda in progress)
massi has joined #scopehal
<azonenberg> @johnsel: also apparently i'm down 64GB of RAM
<azonenberg> one of the dimms was an RDIMM not a LRDIMM, which explains some of the errors and weirdness i saw in the past
<azonenberg> another one seems to have gone bad, the new mobo doesnt like it
<azonenberg> it wasnt even detected
<azonenberg> So i'm still at 192 GB. Buying two more dimms to add next maintenance outage but no immediate plans to shut down to install them
<azonenberg> also still working on trying to get pcie passthrough to work in xcp-ng. In my initial test the device gave errors about firmware loading failed etc
<azonenberg> it's possible the three GPUs is too much for my 500W power supply, so i'm thinking of getting a beefier one when i add the additional RAM
<azonenberg> but i'd be surprised if these 50W TDP cards burn that much juice when idle
<azonenberg> So it's probably something else
<azonenberg> anyway, we're a ways from needing the GPUs
<d1b2> <johnsel> Hmm well 500 watt is bit on the very low end so that might very well be it
<d1b2> <johnsel> Though it could be a number of other things too
<d1b2> <Darius> 3 GPUs is definitely going to push a 500W PSU..
<d1b2> <Darius> unless you really baby them
<d1b2> <johnsel> Given the tdp of a server cpu and that much memory that might even explain all issues, though you’d expect the motherboard to complain about it over it’s management interfaces
<d1b2> <johnsel> And forced shutdown eventually
<d1b2> <johnsel> Though the GPU might disable itself nowadays, I don’t know tbh
<d1b2> <johnsel> Anyway one or two big storage pool(s) probably is what we want for CI. Should also keep the ACLs simpler
<_whitenotifier-7> [scopehal-apps] Johnsel opened pull request #528: CI: Windows CI runner out of disk space - https://github.com/glscopeclient/scopehal-apps/pull/528
<d1b2> <johnsel> brought the Windows CI down to ~1hr
<d1b2> <johnsel> from 2.5, that is
<azonenberg> johnsel: yeah i will make one big storage pool that you can allocate from as you see fit. under the hood it will be a ceph RBD but you dont have to worry about that detail
<azonenberg> and my thought was that i might have problems if we maxed out all 3
<azonenberg> but that idling they should be ok
<azonenberg> and using one at a time should be ok
<azonenberg> anyway i have a 700W on order and will install along with the new ram when i get back
<azonenberg> darius: for reference these are single slot gpus without a dedicated power connection
<azonenberg> not like rtx 4090s
<d1b2> <Darius> ahh
<d1b2> <Darius> still..
<_whitenotifier-7> [scopehal-apps] Johnsel edited pull request #528: CI: Windows CI runner out of disk space - https://github.com/glscopeclient/scopehal-apps/pull/528
<_whitenotifier-7> [scopehal-apps] azonenberg closed pull request #528: CI: Windows CI runner out of disk space - https://github.com/glscopeclient/scopehal-apps/pull/528
<_whitenotifier-7> [scopehal-apps] azonenberg pushed 5 commits to master [+0/-0/±7] https://github.com/glscopeclient/scopehal-apps/compare/0554c95f5af8...4f08193c3d88
<_whitenotifier-7> [scopehal-apps] Johnsel 21f2ebe - Added WIX env var to PKGBUILD script to combine both builds into a single step
<_whitenotifier-7> [scopehal-apps] Johnsel ce084c5 - Update PKGBUILD
<_whitenotifier-7> [scopehal-apps] Johnsel 6e22190 - Update build-windows.yml
<_whitenotifier-7> [scopehal-apps] ... and 2 more commits.
<azonenberg> johnsel: related: we seem to upload tarballs for each platform
<azonenberg> is that redundant too?
<azonenberg> we probably only need to do that once not 3x
<d1b2> <johnsel> Yes, and we have cronjobs for builds when nothing can change unless you commit a change so that’s redundant
<azonenberg> we have cronjobs where?
<azonenberg> i thought everything was ust triggered on push
<d1b2> <johnsel> that sets up a cronjob to do that same build every week I believe or something like that
<azonenberg> interesting. i didnt even notice that because i commit so often i assumed the builds were all triggered
<azonenberg> that can be removed
<d1b2> <johnsel> it's what causes the random in between builds
<d1b2> <johnsel> 14 hours ago
<d1b2> <johnsel> 14/14/12hrs ago
<d1b2> <johnsel> those are just scheduled re-runs
<azonenberg> ok yeah we definitely dont need that
<azonenberg> i assumed all of the delayed CI failure emails were just the build taking that long since my last commit :p
<d1b2> <johnsel> hah!
<d1b2> <johnsel> I'll take them out
<d1b2> <johnsel> @ehntoo it looks like your macos runner addition didn't get PR-ed or applied correctly?
<d1b2> <johnsel> github.com/glscopeclient/scopehal-apps/blob/master/.github/workflows/build-macos.yml#L13
<d1b2> <johnsel> oh no nevermind
<d1b2> <johnsel> I see it now
<d1b2> <ehntoo> Yeah, that's just for the source tarball, you can nuke it.
<d1b2> <johnsel> actually azonenberg, that whole tarball is unnecessary because you can download a zip from github directly
<d1b2> <johnsel> unless you like it for the format
<d1b2> <johnsel> https://github.com/glscopeclient/scopehal-apps/archive/refs/heads/master.zip and such are auto-generated for every commit
<azonenberg> i like having prebuilt tarballs as artifacts. we just dont need one for each platform
<d1b2> <johnsel> well it's not built, and the only difference is the zip vs tar.gz, but if you want it still then sure
<d1b2> <johnsel> in fact
<azonenberg> but sure if you think its redundant get rid of it
<azonenberg> i'm all for cleaning up the CI, we can re-add if needed
<d1b2> <johnsel> alright, also once we start promoting CI artifacts to releases the first link under the release will be the auto-generated zip/tarball links
<_whitenotifier-7> [scopehal-apps] Johnsel opened pull request #529: CI: Removed tarball uploads and cron schedule from CI workflows - https://github.com/glscopeclient/scopehal-apps/pull/529
<_whitenotifier-7> [scopehal-apps] azonenberg closed pull request #529: CI: Removed tarball uploads and cron schedule from CI workflows - https://github.com/glscopeclient/scopehal-apps/pull/529
<_whitenotifier-7> [scopehal-apps] azonenberg pushed 2 commits to master [+0/-0/±6] https://github.com/glscopeclient/scopehal-apps/compare/4f08193c3d88...d9c38224a888
<_whitenotifier-7> [scopehal-apps] Johnsel 1694019 - CI: Removed tarball uploads and cron schedule from CI workflows to clean up the process some more.
<_whitenotifier-7> [scopehal-apps] azonenberg d9c3822 - Merge pull request #529 from Johnsel/windows-ci-out-of-diskspace CI: Removed tarball uploads and cron schedule from CI workflows
bvernoux has joined #scopehal
massi has quit [Remote host closed the connection]
<d1b2> <ehntoo> Found another GTK/Cairo dependency in scopehal that I wasn't quite while working on a branch that removes the gtk dependency from scopehal. I may leave my initial PR at just removing Gdk::Color.
<d1b2> <ehntoo> *wasn't quite expecting
<azonenberg> ah yes, EyeMask does its own software rendering. I'll work on fixing that at some point
<azonenberg> let's do one thing at a time, Gdk::Color removal is a nice starting point
<azonenberg> we'll have to fix EyeMask to get good eye patterns in ngscopeclient
<_whitenotifier-7> [scopehal-apps] 602p opened pull request #530: Refactor to use new helpers from scopehal for getting values - https://github.com/glscopeclient/scopehal-apps/pull/530
<_whitenotifier-7> [scopehal] 602p opened pull request #709: Centralized helpers for getting indecies and values from waveform - https://github.com/glscopeclient/scopehal/pull/709
<_whitenotifier-7> [scopehal] 602p edited pull request #709: Centralized helpers for getting indecies and values from waveform - https://github.com/glscopeclient/scopehal/pull/709
<d1b2> <louis> There are the PRs moving those helpers around
<d1b2> <louis> Also fixes longstanding bug where you had to place cursor to left of a bar on a histogram to see it's value
<d1b2> <louis> (and if you did place it on the bar you didn't get anything)
<azonenberg> interesting. i'm used to looking at jitter histograms where the bars are like one pixel wide
<azonenberg> so i likely never zoomed in enough to notice
<azonenberg> Will look and merge shortly
<d1b2> <louis> I think generally there was an off-by-one in the logic for getting the value to display when cursoring-over a sample but it wasn't noticeable in the presence of interpolation
<azonenberg> ah interesting
<azonenberg> did you verify it also works correctly w/ interpolated waveforms?
<d1b2> <louis> oh hm let me look
<_whitenotifier-7> [scopehal] 602p synchronize pull request #709: Centralized helpers for getting indecies and values from waveform - https://github.com/glscopeclient/scopehal/pull/709
<d1b2> <louis> OK, that should work fine now. Actually simplifies it slightly :p
<azonenberg> Reviewing...
<azonenberg> louis: line 590 you misspelled "guaranteed"
<azonenberg> For GetIndexNearestAtOrBeforeTimestamp, use Doxygen-style comments like the other stuff does
<azonenberg> brief description at top, then the existing text below it
<azonenberg> We also use US-style spellings of "color" and "behavior" in the code regardless of what the King may say about of it
<azonenberg> i'm from the US, it's my project, we use american spellings :p
<azonenberg> looks otherwise good and ready to merge once you make those changes
<d1b2> <louis> RR. Will fix in a moment. I've gotta get spellcheck working again in my editor...
<azonenberg> (I didn't see any colours, but I did see some behaviour)
<_whitenotifier-7> [scopehal] 602p synchronize pull request #709: Centralized helpers for getting indecies and values from waveform - https://github.com/glscopeclient/scopehal/pull/709
<d1b2> <louis> OK, fixed. I moved the note about step-back logic to above the implementation.
<_whitenotifier-7> [scopehal] azonenberg pushed 5 commits to master [+2/-0/±9] https://github.com/glscopeclient/scopehal/compare/475fb187f980...079da742b3b7
<_whitenotifier-7> [scopehal] 602p 5144a5a - Refactor helpers into shared scopehal for value-getting and index-getting
<_whitenotifier-7> [scopehal] 602p 63ef75f - Have the window filter use helpers
<_whitenotifier-7> [scopehal] 602p 4da4d04 - Correct intepolation logic for new index-finding behaviour
<_whitenotifier-7> [scopehal] ... and 2 more commits.
<_whitenotifier-7> [scopehal] azonenberg closed pull request #709: Centralized helpers for getting indecies and values from waveform - https://github.com/glscopeclient/scopehal/pull/709
<_whitenotifier-7> [scopehal] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/glscopeclient/scopehal/compare/079da742b3b7...e807bfb4efb7
<_whitenotifier-7> [scopehal] azonenberg e807bfb - Removed redundant log indenter
<_whitenotifier-7> [scopehal-apps] azonenberg closed pull request #530: Refactor to use new helpers from scopehal for getting values - https://github.com/glscopeclient/scopehal-apps/pull/530
<_whitenotifier-7> [scopehal-apps] azonenberg pushed 2 commits to master [+0/-0/±6] https://github.com/glscopeclient/scopehal-apps/compare/d9c38224a888...40ab86da75ca
<_whitenotifier-7> [scopehal-apps] 602p 3abbc0f - Refactor to use new helpers from scopehal for getting values
<_whitenotifier-7> [scopehal-apps] azonenberg 40ab86d - Merge pull request #530 from 602p/getvalue_cleanup Refactor to use new helpers from scopehal for getting values
<_whitenotifier-7> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/glscopeclient/scopehal-apps/compare/40ab86da75ca...a9f2bea67dc8
<_whitenotifier-7> [scopehal-apps] azonenberg a9f2bea - Updated to latest scopehal
bvernoux has quit [Quit: Leaving]
<azonenberg> AKL-PT5 v0.9 boards shipped. Already obsolete but i may assemble one just to compare the discrete filter to the distributed v0.10
<azonenberg> woop
<azonenberg> Just did a WAN test of ngscopeclient
<azonenberg> Laptop physically in my lab, but tethered off of my phone using LTE and a VPN back into the lab
<azonenberg> (vs the usual thunderbolt to 10Gbase-SR pipe I use)
<azonenberg> connected to a couple of scopes and the siglent SSG to generate test waveforms and stream live
<azonenberg> UI was very responsive despite the ~100ms latency
<d1b2> <ehntoo> @azonenberg - for PRs that touch both scopehal and scopehal-apps, do you have a preference on whether or not the -apps PR bumps the submodule pointer? I've been leaving it untouched so far to avoid a nearly-inevitable merge conflict, but it's definitely easier to inspect CI results with the submodule update in there.
<_whitenotifier-7> [scopehal] ehntoo opened pull request #710: Initial GTK Refactor - https://github.com/glscopeclient/scopehal/pull/710
<_whitenotifier-7> [scopehal-apps] ehntoo opened pull request #531: Migrate from Gdk::Color to HTML color strings - https://github.com/glscopeclient/scopehal-apps/pull/531
<_whitenotifier-7> [scopehal-apps] ehntoo edited pull request #531: Migrate from Gdk::Color to HTML color strings - https://github.com/glscopeclient/scopehal-apps/pull/531
<_whitenotifier-7> [scopehal] ehntoo synchronize pull request #710: Initial GTK Refactor - https://github.com/glscopeclient/scopehal/pull/710
<azonenberg> Preferable to not include the pointer
<azonenberg> Because of exactly that reason
<d1b2> <david.rysk> Anything worth testing at this time?
<d1b2> <ehntoo> 👍 I'll include links to CI from my fork in PRs then for quick reference. looks like the windows CI in my fork for #531/#710 failed... fixed the immediate reason and kicked off a new build. I'll update the link in the PR to the new build, hopefully that one succeeds.
<_whitenotifier-7> [scopehal-apps] ehntoo edited pull request #531: Migrate from Gdk::Color to HTML color strings - https://github.com/glscopeclient/scopehal-apps/pull/531
<azonenberg> david.rysk: still waiting for lain's queue fixes to land in master
<azonenberg> once those are in, that's probably something you should play with
<d1b2> <david.rysk> ok...