02:54 <Bird|otherbox> azonenberg: yeah, I reckon highlighting errors would be more useful than correcting them silently "behind the user's back"

03:09 <azonenberg> i mean, you can still correct the header but display the checksum in red to indicate an error occurred

03:11 <Bird|otherbox> yeah, I was thinking more of highlighting the erroneous bits themselves

03:12 <azonenberg> Hmm, yeah that would be a bit trickier UI wise

03:13 <azonenberg> I think to start just displaying valid/invalid is sufficient

03:13 <azonenberg> this is what i do for checksums in most other protocols

03:13 <azonenberg> DSI is unique in that it actually has FEC on the header, but the pixel data is merely checksummed

03:19 <_whitenotifier-e> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±2] https://github.com/glscopeclient/scopehal-apps/compare/543f24c90757...5eb6cdbd1839

03:19 <_whitenotifier-e> [scopehal-apps] azonenberg 5eb6cdb - Improved algorithm for choosing which area to use for a newly created filter

03:21 <azonenberg> Ok, so now i have to implement a few more property types for filter parameter

03:21 <azonenberg> but the graph editor is becoming very usable

03:21 <azonenberg> i'd say it's already better than glscopeclient's was

04:46 <d1b2> <azonenberg> https://cdn.discordapp.com/attachments/776941750291267595/1034327083352064031/filter-demo2.mp4

04:47 <d1b2> <azonenberg> how's this look? note how it now spawns filters on top of the source trace if it makes sense, but if the data type is incompatible (like the frequency measurement vs a voltage channel) it spawns a new plot

04:47 <azonenberg> lain: ^

04:52 <lain> I like it

04:54 <d1b2> <azonenberg> it's to the point that i think it will become the main way i interact with the filter graph

04:54 <azonenberg> (vs right clicking on waveform buttons)

04:55 <azonenberg> like, that will still be supported

04:55 <azonenberg> but i think i will create most experimental setups in the graph editor because it's so much better than the glscopeclient one which was nice for showing off a setup after exhaustive dragging of blocks within very restrictive placement rules

04:55 <azonenberg> but not good for actually creating a setup

05:50 <_whitenotifier-e> [scopehal] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/glscopeclient/scopehal/compare/f459ea95d052...1ebbb2534ca1

05:50 <_whitenotifier-e> [scopehal] azonenberg 1ebbb25 - TestWaveformSource: fixed bug where PRBS-31 example waveform used wrong polynomial (not actually standard PRBS-31)

05:50 <_whitenotifier-e> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±2] https://github.com/glscopeclient/scopehal-apps/compare/5eb6cdbd1839...b7ccd12289f6

05:50 <_whitenotifier-e> [scopehal-apps] azonenberg b7ccd12 - FilterPropertiesDialog: added support for enum and bool parameter types

05:51 <azonenberg> ok so now i have to figure out which of several imgui file browser libraries to use

11:47 <d1b2> <WillSlim95> done, you can deletemit

14:22 <_whitenotifier-e> [scopehal-apps] NP95 forked the repository - https://github.com/NP95

14:38 <_whitenotifier-e> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±2] https://github.com/glscopeclient/scopehal-apps/compare/b7ccd12289f6...97ad3ab4baa8

14:38 <_whitenotifier-e> [scopehal-apps] azonenberg 97ad3ab - FilterPropertiesDialog: move filter type to filter info pane vs crowding title bar

17:13 <azonenberg> Ok so i have to add support for filename filter parameter still. that means integrating a file browser, which i'll be working on after work today probably

17:17 <azonenberg> then probably integrating trigger support, and making triggers show up in the graph editor

23:33 <azonenberg> Assembling a new AKL-AV1 now

23:33 <azonenberg> this is the hopefully final version with the better filter and new power/opamp stages that have been tested on other boards/rewoprked