17:45 <azonenberg> Still on the road so not doing as much coding as I'd like

17:45 <azonenberg> But making some progress at least

17:45 <_whitenotifier-7> [scopehal-apps] azonenberg pushed 2 commits to master [+0/-0/±4] https://github.com/glscopeclient/scopehal-apps/compare/303bb32dfbf8...eb98dae8a844

17:45 <_whitenotifier-7> [scopehal-apps] azonenberg d2b3e05 - Markers can now be selected in history independent of the parent waveform. See #511.

17:45 <_whitenotifier-7> [scopehal-apps] azonenberg eb98dae - Implemented marker deletion from history window. See #511.

18:26 <_whitenotifier-7> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/glscopeclient/scopehal-apps/compare/eb98dae8a844...2f1ed78c5b93

18:26 <_whitenotifier-7> [scopehal-apps] azonenberg 2f1ed78 - Markers can now be deleted via context menu from WaveformArea's. See #511.

18:40 <azonenberg> ok so... we have a bug in ngscopeclient where waveforms seem to not always be added to the history

18:40 <azonenberg> This is going to be a fun one to troubleshoot

18:41 <azonenberg> seems to only happen in normal trigger, not single shot

19:37 <azonenberg> Hmmm, seems like somehow we have a situation where CheckForWaveforms() is not being called but DownloadWaveforms() is?

19:39 <azonenberg> aha,, CheckForWaveforms runs in the gui thread

19:39 <azonenberg> and has an early out if the trigger isnt armed

19:44 <azonenberg> So i think it's a race condition if we stop the trigger before the gui thread has added it to history

19:45 <azonenberg> aha, i think that the code in question is actually a workaround for a driver bug i fixed a while back

19:48 <_whitenotifier-7> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/glscopeclient/scopehal-apps/compare/2f1ed78c5b93...688d518c4e9d

19:48 <_whitenotifier-7> [scopehal-apps] azonenberg 688d518 - Fixed bug causing last waveform after clicking "stop" in normal trigger mode to not be added to history. Offending code was a workaround for a driver bug fixed in https://github.com/glscopeclient/scopehal-pico-bridge/commit/1baf71050ca4edcc3797f5ececbeb9bea22505c1

19:53 <azonenberg> ok so i think the only thing left to do for me to be happy with markers in ngscopeclient is to make clicking on them in the history view actually do something

19:53 <azonenberg> i.e. select the parent waveform as well as scrolling any group containing that timestamp to it

20:37 <_whitenotifier-7> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±7] https://github.com/glscopeclient/scopehal-apps/compare/688d518c4e9d...9c8dbcde58c3

20:38 <_whitenotifier-7> [scopehal-apps] azonenberg 9c8dbcd - Clicking on markers now navigates to them. Fixes #511.

20:38 <_whitenotifier-7> [scopehal-apps] azonenberg closed issue #511: ngscopeclient: marker support - https://github.com/glscopeclient/scopehal-apps/issues/511

21:27 <_whitenotifier-7> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/glscopeclient/scopehal-apps/compare/9c8dbcde58c3...e928f3afb0d3

21:27 <_whitenotifier-7> [scopehal-apps] azonenberg e928f3a - Session: detach waveforms from scopes before terminating to avoid double free when history is cleared

21:33 <azonenberg> Thinking about how to configure persistence settings in ngscopeclient

21:33 <azonenberg> Ideally i'd like to support both global on/off and per channel

21:34 <azonenberg> We also have no way to set properties for a DisplayedChannel, only the channel

21:59 <_whitenotifier-7> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±6] https://github.com/glscopeclient/scopehal-apps/compare/e928f3afb0d3...2e8444d00d17

21:59 <_whitenotifier-7> [scopehal-apps] azonenberg 2e8444d - Added persistence option (via right click on channel infobox). See #519. Cannot yet adjust decay rate.