13:45 <gbruno> [github] tiredtait opened issue #4662 (error while compiling with cgal) https://github.com/openscad/openscad/issues/4662

16:46 <lf94> https://www.leocad.org/

17:46 <gbruno> [github] thehans edited issue #4662 (error while compiling with cgal) https://github.com/openscad/openscad/issues/4662

21:34 <gbruno> [github] craftmaster1231 review_requested pull request #4637 (For QtCreator to show files. ) https://github.com/openscad/openscad/pull/4637

22:18 <gbruno> [github] kintel pushed 1 modifications (For QtCreator to show files. (#4637)) https://github.com/openscad/openscad/commit/48f159d739fcb8c536b9961acc92f3fbc4c87b63

22:18 <gbruno> [github] kintel closed pull request #4637 (For QtCreator to show files. ) https://github.com/openscad/openscad/pull/4637

23:17 <joseph_> teepee kintel: I've been tracing the rendering code and have consolidated some questions that will guide my refactoring. I'll send them below.

23:17 <joseph_> 1. I'm a little unclear on the overall purpose/effect of the ENABLE_OPENCSG macro. If it's disabled, then most of OpenCSGRenderer is not implemented.

23:17 <joseph_> 2. CGALRenderer handles a lot of data types for the input geometry. Is there a source summarizing when all of these are encountered? It can get confusing because there could be a PolySet, or multiple types of polyhedrons: CGAL_Nef, OGL, or OGL_VBO. Plus, 2D and 3D are rendered differently. I might need to figure this out on my own from the code that's there, because it seems to have been written by obliviand.

23:19 <joseph_> 3. How does the following top-level proposal sound? Two new classes are created called something like PreviewRenderer and FinalRenderer, as drop-in replacements for OpenCSGRenderer and CGALRenderer, respectively. I would move all the existing VBO rendering code into the new classes, leaving only the fixed-function calls behind in OpenCSGRenderer and CGALRenderer. Then the process of choosing legacy or modern OpenGL will just be a

23:19 <joseph_> matter of changing which class is instantiated (and for the time being this could happen at runtime). A preprocessor macro called something like DISABLE_LEGACY_RENDERING could fully deactivate OpenCSGRenderer and CGALRenderer, allowing the use of newer OpenGL versions in the future.

23:49 <peeps[zen]> joseph_: regarding ENABLE_OPENCSG, most dependencies have a way to disable in the build process, so for example you could create a headless version which only spits out stl etc. and no graphics capabilities

23:50 <peeps[zen]> it allows for greater flexibility of use-cases. like I'm pretty sure the recent WASM projects aren't including it