<JordanBrown[m]>
InPhase: I can't say that I have looked super carefully at the Viewport-Control panel, but it doesn't seem to let you control how big the viewport is, which in turn (I think) controls the size of the exported images.
<JordanBrown[m]>
The "Aspect Ratio" controls do not seem to control the size, but only the aspect ratio. Setting them to 1:1 seems to be the same as setting them to 1000:1000.
<JordanBrown[m]>
And I don't know what "Lock" means.
<teepee>
it's just related work, the change is that the animation export uses an offscreen buffer now, not the viewport
<teepee>
the viewport control is mostly there to get the same aspect ratio so the export matches
<teepee>
well, the actual offscreen buffer code is still in a PR
pah has joined #openscad
<JordanBrown[m]>
So what controls the animation size?
<teepee>
which had some strange issue that may have been fixed by your context bugfix
<JordanBrown[m]>
Nor, for that matter, does Hide Animation Toolbar/Window or Hide Viewport Control.
rvt has joined #openscad
<JordanBrown[m]>
Ah, they all work if docked, but not if free-floating as their own windows.
oldlaptop has joined #openscad
<teepee>
:(
<JordanBrown[m]>
Hide customizer, console, editor all work as expected.
<teepee>
yeah that is all way too much copy&paste code
<JordanBrown[m]>
Also closing Error Log, Animate, Viewport Control using the [X] is not reflected in the menu. (But is for customizer, editor, console.)
<JordanBrown[m]>
So somebody got it wrong for Error Log and that got copied for the other two.
<InPhase>
JordanBrown[m]: I assumed export from animation would use the values there in that viewport window, but I didn't test.
<InPhase>
JordanBrown[m]: Regardless, if it doesn't currently, that would be the place to update behavior so that it does. :)
<JordanBrown[m]>
I did not check whether animation used those values, but I did look at how they affected the main view window, where they affected the aspect ratio but not the size.
<JordanBrown[m]>
But if you look at the video associated with the PR that teepee pointed at, you can see some size parameters added to the animation pane.
<JordanBrown[m]>
And really that is more right - the viewport control should control the viewport, and the animation should not be tied to the viewport.
<JordanBrown[m]>
(Except maybe for defaults.)
ur5us has joined #openscad
LordOfBikes has quit [Ping timeout: 252 seconds]
snaked has joined #openscad
GNUmoon has quit [Quit: Leaving]
GNUmoon has joined #openscad
LordOfBikes has joined #openscad
ToAruShiroiNeko has quit []
ToAruShiroiNeko has joined #openscad
rogeliodh has quit [Quit: Ping timeout (120 seconds)]
<InPhase>
JordanBrown[m]: Well, I took the novel step of actually trying it. :)
<InPhase>
JordanBrown[m]: And yeah, it does not take the values, but only dumps the window following that ratio.
<JordanBrown[m]>
Is that allowed?
<JordanBrown[m]>
Trying it, that is.
<InPhase>
But it would be a sensible update to change the words "Aspect Ratio" to "Image Dimensions" or similar, and use that for the animation dump.
<InPhase>
Well, "trying it" is obviously intended as a last resort after exhausting all possible theorizing. ;)
<JordanBrown[m]>
Maybe. Since it's in the Viewport Control pane, and the other things in that pane control and are controlled by the window and the camera, you might (and probably should) expect changing the sizes there to change the preview size on the screen.
<JordanBrown[m]>
That would be OK for making the sizes small, but not so good for making them large.
<InPhase>
Well, "Image Size" does not always mean display size, because of zoom. I think "zoom to fit" is a reasonable default anyway.
<JordanBrown[m]>
Er, *which* zoom?
<InPhase>
I mean zoom is a tradition in other programs, so there's an existing expectation.
<InPhase>
People are used to things just fitting onto the screen by default.
<InPhase>
Movies, image editors, etc.
<JordanBrown[m]>
Yeah, but we already have a different notion of zoom.
<JordanBrown[m]>
Zoom-to-fit is an interesting option, but shouldn't be required... and seems orthogonal to the question of how many pixels you'll get in your image.
<JordanBrown[m]>
But yes, in a word processor or in most image editors, there's a notion of a page, and the display is just a view of that page.
<JordanBrown[m]>
Unfortunately, we don't have a notion of a page.
<JordanBrown[m]>
(Inkscape has pages, but I'd say they should be optional.)
<JordanBrown[m]>
(Scratch that, it shouldn't have pages as anything other than a kind of guide line.)
<JordanBrown[m]>
You might think that "resolution" would play a part, and it does, but the part that it plays is so obscure that I don't immediately think it would be useful as a user-visible parameter.
<JordanBrown[m]>
You could have a 1000x1000 view of a particular scene, or a 100x100 view of the same scene, and you could maybe describe those in somethings per something, but I don't know what either something would be.
<JordanBrown[m]>
(Pixels per unit line at unit distance from the camera, I think.)
<JordanBrown[m]>
Maybe the animation render (or other export-to-image renders?) should be at the same *aspect ratio* as the display viewport, just with a different pixel dimension.
<JordanBrown[m]>
So that what you get "looks" the same, just at a different size.
rogeliodh has joined #openscad
<JordanBrown[m]>
Technically I think that would mean changing both the size of the viewport and the distance from the camera to the viewport, so that the view ... pyramids? ... would be the same volume of space.
<JordanBrown[m]>
But I expect that whoever did the offscreen-buffer stuff thought about most of these things (and probably more) and has a reasonable answer.
aiyion1 has quit [Ping timeout: 258 seconds]
aiyion1 has joined #openscad
qeed_ has joined #openscad
qeed has quit [Ping timeout: 268 seconds]
J1A8491 has joined #openscad
J1A84 has quit [Ping timeout: 244 seconds]
ur5us has quit [Ping timeout: 250 seconds]
ur5us has joined #openscad
guerd871 has joined #openscad
guerd87 has quit [Read error: Connection reset by peer]
ur5us has quit [Ping timeout: 250 seconds]
Junxter has joined #openscad
ur5us has joined #openscad
pah is now known as pa
ur5us has quit [Ping timeout: 248 seconds]
SamantazFox has quit [*.net *.split]
rvt has quit [*.net *.split]
guerd871 has quit [*.net *.split]
othx has quit [*.net *.split]
Xeha has quit [*.net *.split]
berndj has quit [*.net *.split]
zauberfisch has quit [*.net *.split]
TheCoffeMaker has quit [*.net *.split]
othx has joined #openscad
guerd871 has joined #openscad
rvt has joined #openscad
rvt has joined #openscad
rvt has quit [Changing host]
berndj has joined #openscad
Xeha has joined #openscad
TheCoffeMaker has joined #openscad
TheCoffeMaker has joined #openscad
TheCoffeMaker has quit [Changing host]
SamantazFox has joined #openscad
zauberfisch has joined #openscad
Guest273 has joined #openscad
Guest273 has quit [Quit: Client closed]
teepee_ has joined #openscad
teepee has quit [Ping timeout: 258 seconds]
teepee_ is now known as teepee
castaway has joined #openscad
ur5us has joined #openscad
teepee_ has joined #openscad
teepee has quit [Ping timeout: 258 seconds]
teepee_ is now known as teepee
ur5us has quit [Ping timeout: 268 seconds]
jonasbits has quit [Ping timeout: 268 seconds]
jonasbits has joined #openscad
califax has quit [Remote host closed the connection]
califax has joined #openscad
cbmuser has quit [Quit: WeeChat 3.0]
cbmuser has joined #openscad
ccox_ has joined #openscad
ccox has quit [Ping timeout: 260 seconds]
Junxter has quit [Read error: Connection reset by peer]