<InPhase>
teepee: Do you know off the top of your head if we have comment parsing test cases in the testing suite?
<InPhase>
teepee: Or is that basically impossible as it's unused from command line?
<InPhase>
teepee: I was engaged in the fool's errand of cleaning up the last warnings from the build process, and the final one is this yacc shift/reduce warning from comment_parser.y, but it seems easy to mess up (in part from me not being skilled at .y) and I don't know what the full correct behavior is supposed to be.
ferdna has joined #openscad
califax- has joined #openscad
califax has quit [Ping timeout: 276 seconds]
califax- is now known as califax
To_Aru_Shiroi_Ne has quit [Remote host closed the connection]
ToAruShiroiNeko has joined #openscad
teepee has quit [Remote host closed the connection]
teepee has joined #openscad
ur5us has quit [Ping timeout: 260 seconds]
ferdna has quit [Quit: Leaving]
<peepsalot>
InPhase: iirc that warning is because there's an ambiguity between a slider range (with no step) [X:Y] , and a labeled drop-down with a single item
gunnbr__ has joined #openscad
peeps[zen] has joined #openscad
juri_ has quit [*.net *.split]
gunnbr_ has quit [*.net *.split]
peepsalot has quit [*.net *.split]
rvt has quit [*.net *.split]
rvt_ has joined #openscad
la1yv_b has joined #openscad
juri_ has joined #openscad
la1yv_a has quit [Read error: Connection reset by peer]
lkr has joined #openscad
little_blossom has quit [Quit: little_blossom]
knielsen has quit [Quit: leaving]
knielsen has joined #openscad
L29Ah has quit [Ping timeout: 252 seconds]
berndj has quit [Remote host closed the connection]
pie_ has quit [Ping timeout: 252 seconds]
pie_ has joined #openscad
berndj has joined #openscad
dalias_ has joined #openscad
dalias has quit [Ping timeout: 252 seconds]
ali1234[m]1 has joined #openscad
redlizard has joined #openscad
ali1234[m] has quit [Ping timeout: 252 seconds]
redlizard_ has quit [Ping timeout: 252 seconds]
mhroncok has joined #openscad
lkr1 has joined #openscad
Azelphur_ has joined #openscad
milkandtang has joined #openscad
Azelphur has quit [Ping timeout: 252 seconds]
fardog has quit [Ping timeout: 252 seconds]
rogeliodh has quit [Ping timeout: 252 seconds]
rogeliodh3 has joined #openscad
lkr has quit [Ping timeout: 252 seconds]
snaked has quit [Read error: Connection reset by peer]
Polsaker has quit [Ping timeout: 252 seconds]
kanzure has quit [Ping timeout: 252 seconds]
noonien7 has joined #openscad
noonien has quit [Ping timeout: 252 seconds]
noonien7 is now known as noonien
Polsaker has joined #openscad
kanzure has joined #openscad
peepsalot has joined #openscad
peeps[zen] has quit [Ping timeout: 250 seconds]
lastrodamo has joined #openscad
peeps[zen] has joined #openscad
peepsalot has quit [Ping timeout: 252 seconds]
pie_ has quit [Ping timeout: 252 seconds]
redlizard_ has joined #openscad
pie_ has joined #openscad
lkr has joined #openscad
Azelphur has joined #openscad
berndj-blackout has joined #openscad
kanzure_ has joined #openscad
fardog has joined #openscad
knielsen_ has joined #openscad
knielsen has quit [Ping timeout: 252 seconds]
redlizard has quit [Ping timeout: 252 seconds]
Azelphur_ has quit [Ping timeout: 252 seconds]
kanzure has quit [Ping timeout: 252 seconds]
milkandtang has quit [Ping timeout: 252 seconds]
lkr1 has quit [Ping timeout: 252 seconds]
berndj has quit [Ping timeout: 252 seconds]
berndj-blackout is now known as berndj
ABSHK has quit [Ping timeout: 252 seconds]
ABSHK has joined #openscad
peeps[zen] is now known as peepsalot
<peepsalot>
InPhase: btw i blame thingiverse for the original customizer spec not requiring quotes on dropdown strings
L29Ah has joined #openscad
arebil has joined #openscad
Junxter has joined #openscad
<InPhase>
peepsalot: That was 1 of the 3 warnings. The other 2 appear to be the part of the comment grammar that unrolls adjacent WORD and NUM elements in a manner that is ambiguous.
<InPhase>
Unfortunately I don't understand this part's semantic goals, which is why I was looking for a test suite. It's easy to disable by declaring WORD and NUM events nonassoc, restricting their adjacency. But I don't know what that breaks, because I don't know what it was for in the first place.
<InPhase>
I struggled last night to establish a precedence for the [X:Y] parse last night, but wasn't successful in large part because I don't understand what I'm doing, and the bison rules for establishing a precedence at the exact right spot appear to be a mysterious dark art. It is one of those problems which appears to be very common for people to have with their grammars, but for which zero of the
<InPhase>
discussion threads leading to a resolution are sufficiently helpful.
<InPhase>
I recall having some course content on this many many years ago, but alas, we did not cover tool use. And bison has a hefty processing delta between the input file and the state machines at which it reports errors, leaving it hard to discern where the ambiguity actually arises in the input. I tossed precedence markers at my top dozen or so guesses, but this did not seem to help.
<InPhase>
I may have to just PR the other warnings away if I can't validate correctness of the comment parsing changes. My %nonassoc didn't break anything I could think of testing, but again, I'm not sure what that was for.
arebil has quit [Quit: My keyboard has gone to sleep. ZZZzzz…]
dalias_ is now known as dalias
snaked has joined #openscad
arebil has joined #openscad
lkr has quit [Ping timeout: 252 seconds]
snaked has quit [Quit: Leaving]
lastrodamo has quit [Quit: Leaving]
SamantazFox_ is now known as SamantazFox
mhroncok has quit [Quit: Leaving.]
arebil has quit [Quit: My keyboard has gone to sleep. ZZZzzz…]