baracurda has quit [Remote host closed the connection]
aakashi2001 has joined #mlpack
aakashi2001 has quit [Changing host]
aakashi2001 has joined #mlpack
aakashi2001 has quit [Quit: Leaving]
aakashi2001 has joined #mlpack
aakashi2001 has quit [Changing host]
aakashi2001 has joined #mlpack
aakashi2001 has quit [Max SendQ exceeded]
aakashi2001 has joined #mlpack
aakashi2001 has quit [Changing host]
aakashi2001 has joined #mlpack
aakashi2001 has quit [Quit: Leaving]
aakashi2001 has joined #mlpack
aakashi2001 has quit [Changing host]
aakashi2001 has joined #mlpack
aakashi2009 has joined #mlpack
aakashi2009 has quit [Remote host closed the connection]
<EshaanAgarwal[m]>
I was working on my pr https://github.com/mlpack/mlpack/pull/3164 when i noticed that some tests were failing. So I tried to make some changes and build the library again but it seems like the "make command" did not build new changes.
<EshaanAgarwal[m]>
I am certain that my changes should not give same error as last. I have saved the changes and tried to build library a couple of times now.
<ShubhamAgrawal[4>
> <@eshaanagarwal:matrix.org> I was working on my pr https://github.com/mlpack/mlpack/pull/3164 when i noticed that some tests were failing. So I tried to make some changes and build the library again but it seems like the "make command" did not build new changes.
<ShubhamAgrawal[4>
>
<ShubhamAgrawal[4>
Try to make a clean build again
<ShubhamAgrawal[4>
> I am certain that my changes should not give same error as last. I have saved the changes and tried to build library a couple of times now.
<NabanitaDash[m]>
<zoq[m]> "Let me know if you run into..." <- I bumped up the versions as a version mismatch error popped up for matplotlib and python. It needs to be approved so that I can test if the code file is working.
<EshaanAgarwal[m]>
<ShubhamAgrawal[4> "> <@eshaanagarwal:matrix.org..." <- ok ! will i have to make a clean build every time for a change or just in cases like this ?
<ShubhamAgrawal[4>
EshaanAgarwal[m]: Ig not every time as cmake should be able to build new changes
aakashi2001 has quit [Quit: Leaving]
baracurda has joined #mlpack
baracurda has quit [Remote host closed the connection]
baracurda has joined #mlpack
<zoq[m]>
<ShubhamAgrawal[4> "Ig not every time as cmake..." <- Maybe you updated a header file?
<EshaanAgarwal[m]>
<zoq[m]> "Maybe you updated a header file?" <- yeah it had .hpp extension.
<EshaanAgarwal[m]>
<zoq[m]> "Maybe you updated a header file?" <- but i also changed matrix_completion.cpp too
<zoq[m]>
<EshaanAgarwal[m]> "but i also changed matrix_comple..." <- And you used `cmake ..` and not `cmake -DBUILD_CLI_EXECUTABLES=OFF`?
<EshaanAgarwal[m]>
I have very silly question here. Suppose i have built my library and then make couple of changes. So do i need to start from cmake ../ again or simply make and so on ?
<EshaanAgarwal[m]>
zoq[m]: nope !
<zoq[m]>
> <@eshaanagarwal:matrix.org> nope !
<zoq[m]>
Just make, just trying to figure out why it wasn't picked up. perhaps you can reproduce the situation?
<zoq[m]>
> I have very silly question here. Suppose i have built my library and then make couple of changes. So do i need to start from cmake ../ again or simply make and so on ?
<EshaanAgarwal[m]>
<zoq[m]> "> <@eshaanagarwal:matrix.org..." <- I think I did some mistakes here and there. I will check again and let you know if it persists.
baracurda has quit [Remote host closed the connection]