verne.freenode.net changed the topic of #mlpack to: http://www.mlpack.org/ -- We don't respond instantly... but we will respond. Give it a few minutes. Or hours. -- Channel logs: http://www.mlpack.org/irc/
lezorich has joined #mlpack
< zoq> Not sure if we can remove backtrace.hpp from git entirely, if CMake generates the file it would be recognized by git as new file, which results in kind of the same problem
< zoq> Another solution would be to add 'add_definitions(-D__MLPACK_BACKTRACE)' to the CMakeLists.txt and use #ifdef MLPACK_BACKTRACE in log.cpp, I'm not sure if this is a clean way and if we can export the right header file?
< zoq> Perhaps .gitignore is the best solution.
< naywhayare> I thought about add_definitions, but what if the include file isn't execinfo.h?
< naywhayare> unless we can do something like add_definitions(-DBACKTRACE_INCLUDE=${Backtrace_INCLUDE_FILE}) or something
< naywhayare> I didn't test that idea
< zoq> add_definitions(-DBACKTRACE_INCLUDE="${Backtrace_HEADER}") works
< zoq> at least with CMake 3.1
< naywhayare> ah, cool
< naywhayare> then maybe that is a better way to do it and we can avoid backtrace.hpp entirely
< naywhayare> I'll do the same sort of thing for the version.hpp code (which I am finally adapting to use git)
trapz has joined #mlpack
govg has quit [Ping timeout: 255 seconds]
witness has joined #mlpack
lezorich has quit [Quit: Ex-Chat]
edlinde has joined #mlpack
edlinde has quit [Quit: edlinde]
witness has quit [Quit: Connection closed for inactivity]
< zoq> naywhayare: I'll commit the necessary changes tonight.
witness has joined #mlpack
edlinde has joined #mlpack
vedhu63w has joined #mlpack
edlinde has quit [Quit: edlinde]
edlinde has joined #mlpack
< naywhayare> zoq: I was hoping to do the same changes to the version info, but I think that will actually be really difficult because I'd have to call add_definitions() every time 'make' was run, and it doesn't seem like I can easily do that
< naywhayare> it might be possible, but I think I'm going to focus on other things in the library for now instead
govg has joined #mlpack
govg is now known as Guest7419
< zoq> naywhayare: yeah, I see what you mean
trapz has quit [Quit: trapz]
< stephentu> naywhayare: the travis CI builds for mlpack are failing
< stephentu> something about gitversion.hpp
< stephentu> sorry if you are alreayd aware
< zoq> yeah, it's weird
< zoq> I think we don't need 'include(CMake/CreateGitVersionHeader.cmake)' at least on my system this works without including CreateGitVersionHeader because we already include everthing at the begining.
< zoq> ah never mind, travis doesn't build every commit
< naywhayare> stephentu: I don't get notified when travis is broken... do we want to set up an IRC bot / have it mail mlpack-git@cc.gatech.edu?
< zoq> The error message is great ...
edlinde has quit [Quit: edlinde]
< zoq> the jenkins build runs longer than normal
< naywhayare> let me see if I can figure out what test it's hung up on
< naywhayare> heh, and just as I'm looking it finishes
< naywhayare> I see that SVDBatchTest and SVDIncrementalTest took a very long time (42m and 12m)
< naywhayare> so I'll have to keep working with those tests to make them faster
< zoq> hm, okay
trapz has joined #mlpack
trapz has quit [Quit: trapz]