11:11 <f_> oh

11:11 <f_> Can U-Boot SPL netboot?

11:21 <narmstrong> Yes it seems

11:22 <f_> nice

14:41 <djrscally> narmstrong: Testing results from your set (https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/amlogic/upstream/isp-pmdomain?ref_type=heads). With d2aaa03f the kernel refuses to boot. I simply commented the registration of those clocks out for now, as I don't know what rate we'd need to set out of it anyway. For the remaining clocks and the pm domain things "worked" following some changes in that the

14:41 <djrscally> kernel instantiates those things and I can see that they're active when I consume them in a skeleton driver for the ISP, but reading from the ISP's base still hangs

14:42 <narmstrong> djrscally: which clock did you comment ?

14:43 <djrscally> This is the CLKID_MIPI_ISP/CLKID_MIPI_ISP_DIV/CLKID_MIPI_ISP_SEL

14:44 <djrscally> The things that I changed were adding the new clocks to g12a_clk_regmaps[], and then in 16c20c5a the new g12a_pwrc_mem_isp doesn't reference the macros that were added in that commit - I assume that was a copy paste hangover

14:47 <narmstrong> damn indeed I forgot the g12a_clk_regmaps

14:48 <narmstrong> indeed the reg addr are not used, let me fix that

14:52 <djrscally> I say "still hangs", but that is a change of behaviour from before actually. It used to panic when reading from 0xff140000, now it hangs

14:54 <narmstrong> it does something different, nice :-)

14:55 <narmstrong> did you enable CLKID_MIPI_ISP_GATE & CLKID_MIPI_ISP clocks ?

14:55 <narmstrong> CLKID_MIPI_ISP should be in xtal by default, slow but functional enough to read registers

14:56 <djrscally> ISP_GATE, yes. The CLKID_MIPI_ISP, when registered, stops the kernel from booting

14:56 <djrscally> Which I am just trying to get to the bottom of now

14:57 <narmstrong> I fixed what you reported in my branch

14:57 <djrscally> ty

14:57 <narmstrong> indeed none of the clock were in g12a_clk_regmaps.... my bad

15:32 <djrscally> No bother

16:29 <djrscally> narmstrong: OK so the boot failure was also the clocks missing from the regmap table - so I'm testing the updated branch

16:30 <djrscally> I also tried enabling the CLKID_MIPI_ISP via rwmem, and with the power domains active it works! I can read from the ISP's register space

16:30 <f_> nice!

16:41 <djrscally> And now it works just using that updated branch, awesome

17:02 <narmstrong> Nice !

17:03 <narmstrong> I’ll probably send the patches on the list next week

17:13 <f_> A311D sure is exciting

17:17 <djrscally> narmstrong: perfect, thank you

17:17 <djrscally> And thanks also for the help getting it working :)