<headius>
yeah I don't get why the intermediate env vars when you can just put the secrets in the setup-java part
<mattpatt[m]>
where does the maven settings.xml get generated?
<mattpatt[m]>
right. do not have enough coffee in system for this, will circle back to it later on
<mattpatt[m]>
sorry, i don't have any experience doing maven deploys, so my mental model for what's going on is non existent and i have no intuition for what might be the problem...
<mattpatt[m]>
best i have so far is that maybe GHA is generating a maven settings.xml and so is something else?
<mattpatt[m]>
i have a vague recollection of that being how GHA maven deploy works
<headius>
I think I got it
<mattpatt[m]>
Is this line wrong? server-id: sonatype-nexus-snapshots
<headius>
I did not notice the "New Repository Secret" button so I added them to an environment, which must not have been activating right
<headius>
Why is the "New Repository Secret" button at the top of the page but the list of repository secrets is halfway down
<headius>
that's just dumb
<headius>
aha it needs to run with 8
<headius>
but otherwise it worked
<mattpatt[m]>
sweet
<headius>
so what's the last switch I need to throw
<headius>
not sure how to trigger this only after other actions succeed... seems like docs only show how to have it in the same workflow as whatever you want to trigger from
<headius>
but it depends on a workflow step that waits for another workflow to finish, and if we have a step waiting for the 20-30min we need it will probably get killed
<headius>
it might be simplest to move this to the main workflow or create a deploy workflow that runs a smaller set of sanity checks
<headius>
let me know if you have another idea when you've got your coffee ☕️
<mattpatt[m]>
oh, it's simple
<mattpatt[m]>
it's a reusable workflow, so we just reuse it in the CI with a dependency on whatever passing we need
<mattpatt[m]>
will send you a PR later]
<mattpatt[m]>
well, it's straightforward anyway
<mattpatt[m]>
maybe not totally simple. the dependency stuff is a bit verbose
<headius>
yeah cool
<headius>
I am playing with some speedups like caching maven stuff better and will PR this branch when I'm happy with it
<headius>
I think we can also cache the compiled base sources which should cut a minute or so off every job
<headius>
wow ok uploading the build output is way slower than just rebuilding for each job
<headius>
uploading core/target after a clean package took 4.5 minutes... I assume downloading would cost the same so that's way slower than rebuilding
<enebo[m]>
This reported issue is interesting to me in that it is doing arity checking which made me wonder how we behave if that raise line is missing. It really feels like if we had reasonable error messages someone would not put that there.
<enebo[m]>
But the second thing I wanted was some agreement that what I wrote in that comment is reasonable. I believe raise requires this.
<headius>
mattpatt: I get it now... you use `needs` and call the snapshot-publish workflow at the end of the main workflow
<enebo[m]>
I did other fixes too but this one was weird. It did not occur to me flattening a recursive array will partially flatten it but leave the recursion behind
<enebo[m]>
It is when I work on bug fixes for stuff like this I am entertained at how strange Ruby can be (and tbh this behavior does make sense)
subbu has joined #jruby
<headius>
yeah I suppose it does
<headius>
ok I cleaned up the failures and simplified the aggregate job names so you can see the matrix elements easier
<enebo[m]>
GHA really needs to show times in the left hand side summary
<headius>
Yeah that would be nice
<headius>
the mvn targets are usually the fastest runs, they should probably move down so the longer rake tasks get queued earlier
<headius>
I'm going to try to reenable the snapshot build
<byteit101[m]>
enebo: oh those 3 issues are fun. I don't think I tested re-opened classes. Will look at it more after work. Though I am glad I changed the error to `Java proxy not initialized. Did you call super() yet?` from a generic NPE
<enebo[m]>
byteit101: yeah it is helpful as a message
<byteit101[m]>
enebo: unsure how much time I'll have to dig into that before the holidays, I'm trying to finish some stuff up before then, but will definitely try to look at it before the new year