00:32
rebelwarrior[m] has quit [Remote host closed the connection]
00:32
JulesIvanicGitte has quit [Remote host closed the connection]
00:32
MarcinMielyskiGi has quit [Remote host closed the connection]
00:32
FlorianDoubletGi has quit [Remote host closed the connection]
00:32
CharlesOliverNut has quit [Remote host closed the connection]
00:32
TestAccount[m] has quit [Remote host closed the connection]
00:32
kalenp[m] has quit [Remote host closed the connection]
00:32
basshelal[m] has quit [Read error: Connection reset by peer]
00:32
RomainManni-Buca has quit [Remote host closed the connection]
00:32
liamwhiteGitter[ has quit [Remote host closed the connection]
00:32
Hao[m] has quit [Remote host closed the connection]
00:32
TimGitter[m]1 has quit [Remote host closed the connection]
00:32
olleolleolle[m] has quit [Remote host closed the connection]
00:32
edipofederle[m] has quit [Remote host closed the connection]
00:32
TimGitter[m] has quit [Remote host closed the connection]
00:32
lopex[m] has quit [Read error: Connection reset by peer]
00:32
RobertNicholas[m has quit [Remote host closed the connection]
00:32
fzakaria[m] has quit [Remote host closed the connection]
00:32
MattPattersonGit has quit [Remote host closed the connection]
00:32
BlaneDabneyGitte has quit [Remote host closed the connection]
00:32
KarolBucekGitter has quit [Remote host closed the connection]
00:32
MatrixTravelerbo has quit [Read error: Connection reset by peer]
00:32
XavierNoriaGitte has quit [Remote host closed the connection]
00:32
architecture[m] has quit [Remote host closed the connection]
00:32
wagyourtail[m] has quit [Remote host closed the connection]
00:32
dan64[m] has quit [Remote host closed the connection]
00:32
donv[m] has quit [Remote host closed the connection]
00:32
enebo[m] has quit [Read error: Connection reset by peer]
00:32
rtyler[m] has quit [Remote host closed the connection]
00:32
JesseChavezGitte has quit [Remote host closed the connection]
00:32
mrtommy[m] has quit [Read error: Connection reset by peer]
00:32
GGibson[m] has quit [Remote host closed the connection]
00:32
mattpatt[m] has quit [Remote host closed the connection]
00:32
UweKuboschGitter has quit [Remote host closed the connection]
00:32
ahorek[m] has quit [Read error: Connection reset by peer]
00:32
byteit101[m] has quit [Remote host closed the connection]
00:32
worldnamer[m] has quit [Remote host closed the connection]
00:32
kares[m] has quit [Remote host closed the connection]
00:32
onghu[m] has quit [Remote host closed the connection]
00:32
ChrisSeatonGitte has quit [Remote host closed the connection]
00:32
OlleJonssonGitte has quit [Remote host closed the connection]
00:32
headius has quit [Remote host closed the connection]
00:32
kai[m]1 has quit [Write error: Connection reset by peer]
00:34
ahorek[m] has joined #jruby
00:45
enebo[m] has joined #jruby
00:45
kai[m]1 has joined #jruby
00:45
lopex[m] has joined #jruby
00:45
MatrixTravelerbo has joined #jruby
00:45
CharlesOliverNut has joined #jruby
00:45
JesseChavezGitte has joined #jruby
00:45
kares[m] has joined #jruby
00:45
TimGitter[m] has joined #jruby
00:45
MarcinMielyskiGi has joined #jruby
00:45
BlaneDabneyGitte has joined #jruby
00:45
TimGitter[m]1 has joined #jruby
00:45
XavierNoriaGitte has joined #jruby
00:45
RobertNicholas[m has joined #jruby
00:45
ChrisSeatonGitte has joined #jruby
00:45
UweKuboschGitter has joined #jruby
00:45
KarolBucekGitter has joined #jruby
00:45
mattpatt[m] has joined #jruby
00:45
FlorianDoubletGi has joined #jruby
00:45
RomainManni-Buca has joined #jruby
00:45
kalenp[m] has joined #jruby
00:45
MattPattersonGit has joined #jruby
00:45
basshelal[m] has joined #jruby
00:45
byteit101[m] has joined #jruby
00:45
liamwhiteGitter[ has joined #jruby
00:45
mrtommy[m] has joined #jruby
00:45
JulesIvanicGitte has joined #jruby
00:45
edipofederle[m] has joined #jruby
00:45
fzakaria[m] has joined #jruby
00:45
olleolleolle[m] has joined #jruby
00:45
onghu[m] has joined #jruby
00:45
Hao[m] has joined #jruby
00:45
architecture[m] has joined #jruby
00:45
rtyler[m] has joined #jruby
00:45
TestAccount[m] has joined #jruby
00:45
dan64[m] has joined #jruby
00:45
GGibson[m] has joined #jruby
00:45
rebelwarrior[m] has joined #jruby
00:45
donv[m] has joined #jruby
00:45
OlleJonssonGitte has joined #jruby
00:45
worldnamer[m] has joined #jruby
00:45
wagyourtail[m] has joined #jruby
00:45
headius has joined #jruby
05:06
fidothe has quit [*.net *.split]
05:07
fidothe has joined #jruby
08:14
drbobbeaty has quit [Ping timeout: 258 seconds]
10:45
drbobbeaty has joined #jruby
16:48
<
headius >
enebo: maybe you can point edipo.federle in the right direction on that bug
16:48
<
headius >
oh you just did
16:53
<
enebo[m] >
ahorek pretty much pointed us to the fact this is not canonicalized but I am confused about basic identity
16:53
<
enebo[m] >
isn't 10/10 == 1/1 for a rational?
16:54
<
enebo[m] >
even in MRI?
16:54
<
headius >
yeah I am looking at that
16:54
<
headius >
so it is an issue that we are not reducing it
16:54
<
headius >
it literally does equals on numerator and denominator and they have to match
16:55
<
enebo[m] >
We clearly have a bug I am just wondering if we have two
16:56
<
enebo[m] >
mri26 -e 'p(Rational(1, 1) == Rational(10, 10))'
16:56
<
headius >
$ ruby26 -e 'p Rational(10, 10)'
16:56
<
enebo[m] >
I just checked and we do pass what I typed
16:56
<
enebo[m] >
haha ok so it gets canonicalized
16:56
<
headius >
we match that behavior
16:56
<
headius >
but we do not canonicalize this in AST or after
16:57
<
enebo[m] >
so the solution is we need to canonicalize the values somewhere
16:57
<
enebo[m] >
Doing it in the AST would prevent possibly having it happen more than once but doing it however we construct the actual object arguably is no duplicated code and will future proof this happening later
17:18
<
headius >
fix in jit too 😀
17:21
<
ahorek[m] >
good catch :)
17:45
<
enebo[m] >
ahorek: you got a cast mismatch error in IRRuntimeHelpers
17:53
<
enebo[m] >
lol ok I think I was looking at previous commit.
18:36
<
ahorek[m] >
yeah, it should be ready now
18:38
<
enebo[m] >
ahorek: coolio. Just merged it.