michaelni changed the topic of #ffmpeg-devel to: Welcome to the FFmpeg development channel | Questions about using FFmpeg or developing with libav* libs should be asked in #ffmpeg | This channel is publicly logged | FFmpeg 6.1.1 has been released! | Please read ffmpeg.org/developer.html#Code-of-conduct
mkver has quit [Ping timeout: 260 seconds]
rvalue has quit [Ping timeout: 252 seconds]
elastic_dog has joined #ffmpeg-devel
cone-597 has quit [Quit: transmission timeout]
jafa has joined #ffmpeg-devel
rvalue has joined #ffmpeg-devel
hamzah has quit [Ping timeout: 250 seconds]
iive has quit [Quit: They came for me...]
thilo has quit [Ping timeout: 260 seconds]
thilo has joined #ffmpeg-devel
agrosant has quit [Ping timeout: 264 seconds]
MrZeus_ has joined #ffmpeg-devel
lexano has quit [Ping timeout: 255 seconds]
agrosant has joined #ffmpeg-devel
MrZeus has quit [Ping timeout: 255 seconds]
AbleBacon has joined #ffmpeg-devel
qeed has joined #ffmpeg-devel
agrosant has quit [Ping timeout: 264 seconds]
darkstardevx has quit [Quit: Leaving]
jamrial has quit []
AbleBacon has quit [Read error: Connection reset by peer]
<Lynne>
I was having trouble with my adding
<Lynne>
108 KIB!
<Lynne>
MINUS!
<Lynne>
no LTO either, vanilla build
<Lynne>
updated my repo with a few more cleanup commits, it looks ready for review
MrZeus_ has quit [Ping timeout: 260 seconds]
Martchus_ has quit [Ping timeout: 264 seconds]
Martchus has joined #ffmpeg-devel
tufei__ has joined #ffmpeg-devel
tufei_ has quit [Remote host closed the connection]
tufei__ has quit [Remote host closed the connection]
tufei__ has joined #ffmpeg-devel
stevenliu has quit [Remote host closed the connection]
stevenliu has joined #ffmpeg-devel
MisterMinister has quit [Ping timeout: 260 seconds]
SystemError has quit [Ping timeout: 260 seconds]
SystemError has joined #ffmpeg-devel
MisterMinister has joined #ffmpeg-devel
MisterMinister has quit [Ping timeout: 260 seconds]
qeed has quit [Quit: Leaving]
Livio has joined #ffmpeg-devel
j45 has quit [Ping timeout: 240 seconds]
kepstin has quit [Remote host closed the connection]
kepstin has joined #ffmpeg-devel
j45 has joined #ffmpeg-devel
j45 has quit [Changing host]
j45 has joined #ffmpeg-devel
kurosu has joined #ffmpeg-devel
j45_ has joined #ffmpeg-devel
j45 has quit [Ping timeout: 268 seconds]
j45_ is now known as j45
j45 has quit [Changing host]
j45 has joined #ffmpeg-devel
elenril has quit [Ping timeout: 272 seconds]
elenril has joined #ffmpeg-devel
Krowl has joined #ffmpeg-devel
Krowl has quit [Ping timeout: 264 seconds]
Krowl has joined #ffmpeg-devel
Livio has quit [Ping timeout: 256 seconds]
jamrial has joined #ffmpeg-devel
tufei__ has quit [Remote host closed the connection]
tufei__ has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
<sdc>
Not at my computer right now those were the videos that didn’t pass. I recloned ffvvc main when I did that.
<frankplow>
sdc: Those are all IBC bitstreams. What revision are you using — perhaps one from before the IBC patchset?
<sdc>
Oo I think that might be it…
<sdc>
Is the up branch the most up to date branch?
<sdc>
I normally use perforce so I’m a bit confused by git still haha
<frankplow>
sdc: The ffvvc repository is where we staged changes before the decoder was merged into FFmpeg Git master. Since it's been merged, we've primarily been working off FFmpeg master Git.
<frankplow>
sdc: It's a bit of a mess that repo, it was rebased onto the main master branch for sending the main patchset out.
Krowl has joined #ffmpeg-devel
tufei__ has quit [Remote host closed the connection]
tufei__ has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
rvalue has quit [Ping timeout: 252 seconds]
agrosant has joined #ffmpeg-devel
rvalue has joined #ffmpeg-devel
tufei_ has joined #ffmpeg-devel
tufei__ has quit [Ping timeout: 260 seconds]
Somebody3456 has joined #ffmpeg-devel
SystemError has quit [Ping timeout: 260 seconds]
agrosant has quit [Ping timeout: 264 seconds]
qeed has quit [Quit: Leaving]
cone-252 has quit [Quit: transmission timeout]
Traneptora has quit [Quit: Quit]
<Lynne>
jkqxz: the currently decoded frame is included in the list of references for av1, right?
<Lynne>
what is the current frame's ref_frame_idx in that case? what slot (LAST/GOLDEN etc) does it use?
Traneptora has joined #ffmpeg-devel
<BBB>
refresh_mask indicates the bits that will be replaced with the current frame once it finishes decoding
<BBB>
so it can be more than one, and it's only at the end of decoding
<BBB>
during decoding, all 8 are one or more other frames
<jkqxz>
INTRA, 0. (That gets used for e.g. compound interintra.)
<Lynne>
also, does ref_frame_idx[] match the order of AV1DecContext.ref[]?
<BBB>
isn't ref_frame_idx the one you have 7 of, and ref[] the one you have 8 of?
<BBB>
so then the value of ref_frame_idx[i] is indeed the index in ref[]
Marth64 has quit [Remote host closed the connection]
<jkqxz>
I think ref is indexed by the refresh_frame_flags slot? So no.
<jkqxz>
ref_frame_idx is indexed by FUNNY_NAME - LAST_FRAME, and contains the slot index.
<BBB>
ref[] contains the (up to) 8 "alive" references, ref_frame_idx is the "active" references (up to 7, selected from the previously-mentioned 8)
<BBB>
e.g. ref_hint = s->ref[header->ref_frame_idx[i]].raw_frame_header->order_hint
<Lynne>
ref_frame_idx contains FUNNY_NAMEs for all frames
<Lynne>
but hold on, if it's 7-sized, does that mean that the current frame isn't contained in it?
zsoltiv_ has joined #ffmpeg-devel
<BBB>
correct
<BBB>
ref_frame_idx is previously coded references. the current frame is not in it
<Lynne>
it doesn't sound like the current frame has a FUNNY_NAME then?
<BBB>
in some arrays it does, and in some it doesn't
<BBB>
so it's tricky
<BBB>
like jkqxz said, INTRA = 0, LAST_FRAME = 1, and some arrays have a size of 8 not to signify indexing similar to ref[], but rather similar to ref_frame_idx[1+..]
<BBB>
where [0] = INTRA and [1] = LAST_FRAME
<BBB>
as opposed to [0] being LAST_FRAME (like ref_frame_idx)
<BBB>
or a completely different order (like ref[8])
<BBB>
this is totally not confusing and doesn't make you regret that you asked the question, right?
<BBB>
there's also frame buffers (for annex E sorta stuff) which yet again use a different order, although that's implementation-specific
<BBB>
(so I could've not brought that up, but I figured it'd be fun and confusing so I might just as well)
<JEEB>
elenril: re the naming of the AVFrameSideData array, currently it's `frame_side_data` (which IIRC was suggested previously), and yes it matches nothing else than the type with that name. your suggestions were decoded_ or raw_. not sure if I like either of those :/ the decoded VS coded doesn't really give a meeting. I'd think of config_ since it's utilized for configuration, but dunno ┐(´д｀)┌
<JEEB>
jamrial: funny enough the allocation requirements for side data are not mentioned at all in avutil/frame.h for example :D
<JEEB>
I'm not against adding it where I'm adding code, but just noting that state of affairs currently :)
<jamrial>
JEEB: maybe encoder_side_data. frame_ does not feel right and does not really say what the field is for in avctx
<jamrial>
JEEB: for that matter, you can push the first few patches, since those have no objections
<jamrial>
if anything to make rebasing simpler for the rest in case the tree changes
Somebody3456 is now known as SystemError
<JEEB>
yea the problem is that coded_side_data did get inserted by encoders as well. but yea, could be something like that. will I guess name it like that for now
<JEEB>
which you mentioned I had not applied (probably since I was going through comments commit by commit and did a stop when I read one of elenril's comments which was opposite to what was told me in August-September or so)
<jamrial>
yeah, that looks good
MrZeus_ has joined #ffmpeg-devel
MrZeus_ has quit [Read error: Connection reset by peer]
MrZeus_ has joined #ffmpeg-devel
<JEEB>
alright. I'll then just post that as v9 since that way I make sure things are at least progressing :)
<JEEB>
re: pushing the initial patches, I /hope/ this set isn't going to take too much time :D and I don't like pushing APIs that don't yet have any usage :D
<JEEB>
there, v9 posted
<JEEB>
and I can go back to v4 (or whatever it was) _extend API for the side data array if that just gets me to a state where I can finally consider this patch set done. :V or if we can get an agreement on the current avcodec helper way. I just don't want to get any more flip-flopping in review.
* Sean_McG
peeks in
qeed has joined #ffmpeg-devel
<Lynne>
wtf, for the very first frame, ref_frame_idx is all INTRA
<Lynne>
it must be NONE, shouldn't it?
<Lynne>
oh... it means the output is splat'd amongst all references, doesn't it?
MrZeus_ has quit [Read error: Connection reset by peer]
MrZeus_ has joined #ffmpeg-devel
kurosu has joined #ffmpeg-devel
jnbek has quit [Ping timeout: 264 seconds]
MrZeus_ has quit [Read error: Connection reset by peer]
MrZeus_ has joined #ffmpeg-devel
MrZeus_ has quit [Read error: Connection reset by peer]
MrZeus_ has joined #ffmpeg-devel
psykose has joined #ffmpeg-devel
lexano has quit [Ping timeout: 272 seconds]
MrZeus_ has quit [Read error: Connection reset by peer]
MrZeus_ has joined #ffmpeg-devel
MrZeus_ has quit [Read error: Connection reset by peer]
MrZeus_ has joined #ffmpeg-devel
MrZeus_ has quit [Read error: Connection reset by peer]
MrZeus_ has joined #ffmpeg-devel
MrZeus_ has quit [Read error: Connection reset by peer]