michaelni changed the topic of #ffmpeg-devel to: Welcome to the FFmpeg development channel | Questions about using FFmpeg or developing with libav* libs should be asked in #ffmpeg | This channel is publicly logged | FFmpeg 6.1.1 has been released! | Please read ffmpeg.org/developer.html#Code-of-conduct
<Lynne> I'll update my second patch during the night on top of that branch then, thanks
<mkver> Lynne: I think I could ExtChannelElement from aacsbr.h (and move it into aacsbr_template.c). Do you prefer this?
cone-068 has joined #ffmpeg-devel
<cone-068> ffmpeg Andreas Rheinhardt master:bbeee3339fec: avcodec/libxevd: Remove FF_CODEC_CAP_SETS_PKT_DTS cap
<cone-068> ffmpeg Andreas Rheinhardt master:4e14a8e6be99: avcodec/libxevd: Set AV_CODEC_CAP_DR1
<cone-068> ffmpeg Andreas Rheinhardt master:5a4702cba91f: avcodec/Makefile: Add missing AV1 decoder->av1_parse.o dependency
<cone-068> ffmpeg Andreas Rheinhardt master:85fc5a0c3f39: avcodec/libxevd: Avoid cloning AVPacket
<cone-068> ffmpeg Andreas Rheinhardt master:cb9fb80c7fed: avcodec/libxevd: Deduplicate code
<cone-068> ffmpeg Andreas Rheinhardt master:c4dceb83542c: avcodec/libxevd: Reindent after the previous commit
<cone-068> ffmpeg Andreas Rheinhardt master:9209350f8d73: avcodec/libxevd: Remove useless AVClass
<cone-068> ffmpeg Andreas Rheinhardt master:ec0bd89297a1: avcodec/libxevd: Use CODEC_LONG_NAME()
<cone-068> ffmpeg Andreas Rheinhardt master:0c92c8e6e37c: avcodec/libxevd: Improve included headers a bit
<cone-068> ffmpeg Andreas Rheinhardt master:fbf1e5135298: avcodec/libxevd: Fix "if (ret = ff_foo() < 0)" precedence problem
<cone-068> ffmpeg Andreas Rheinhardt master:d36cb46681aa: avcodec/libxeve: Use av_dict_iterate()
<cone-068> ffmpeg Andreas Rheinhardt master:72becd0627c5: avcodec/refstruct: Don't use STRIDE_ALIGN for alignment
<cone-068> ffmpeg Andreas Rheinhardt master:22dda5615e8a: avutil/mem_internal: Remove unneeded headers
<cone-068> ffmpeg Andreas Rheinhardt master:80736531da54: avcodec/decode: Improve validity check a bit
<cone-068> ffmpeg Andreas Rheinhardt master:601bb6a739c5: avcodec/mss[12]: Cleanup generically on init failure
<Lynne> mkver: wdym?
<mkver> I could make the whole internals of ExtChannelElement internal to aacsbr_template.c and move it out of aacsbr.h.
<mkver> For this the ff_aac_sbr_* functions will have to be changed to accept ChannelElement* instead of SpectralBandReplication*.
<Lynne> I don't see ExtChannelElement mentioned anywhere?
hamzah has quit [Ping timeout: 250 seconds]
<mkver> It is the typical pattern of allocating a public+private context together; but this time, "public" is actually common.
unlord has quit [Changing host]
unlord has joined #ffmpeg-devel
<Lynne> why would you not keep it in ChannelElement?
<mkver> Because sizeof of the SBR context depends upon USE_FIXED.
<mkver> So it has to be removed from it.
<Lynne> ah, right
<mkver> And it is basically unused in aacdec_template.c anyway.
<Lynne> is it not possible to do the same as what you did with the rest of the buffers?
<mkver> 1. This context contains lots of buffers where sizeof really depends upon USE_FIXED.
<mkver> 2. This would actually be more complicated, as one would have to add AAC_RENAME to aacsbr_template.c etc.
<mkver> I do not rule out deduplicating the VLC reading code from aacsbr_template.c at a later time.
<Lynne> what about allocating it?
<Lynne> on heap?
<mkver> It will already be allocated on the heap (together with the ChannelElement it belongs to).
lexano has quit [Ping timeout: 264 seconds]
<Lynne> right, they were allocated on heap, they shouldn't be, there's 64 maximum possible channel elements
<mkver> Each ExtChannelElement has 598560B when USE_FIXED and 512800B otherwise here, so 64 of these would already be quite a lot.
<mkver> And it would bring back the problem that the decoder's main structure would then again depend upon USE_FIXED.
<Lynne> but all our decoder contexts are allocated on heap
<Lynne> half a meg wouldn't matter that much
<mkver> 64*598560B > 36.5MiB
<mkver> Allocating this stuff on-demand takes way less.
<Lynne> missed the "Each" part
<Lynne> I have no opinion on where it is, I would prefer for it to be in aacsbr_template.c because it's only used there
<mkver> Ok, then I will modify my patchset.
<Lynne> thanks
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
iive has quit [Quit: They came for me...]
thilo has quit [Ping timeout: 255 seconds]
thilo has joined #ffmpeg-devel
HarshK23 has joined #ffmpeg-devel
<philipl> Lynne: I suspect the av1 decoding not working on nvidia is because they only support the KHR extension - so the MESA names don't work
<Lynne> yyyeah
lemourin has quit [Quit: The Lounge - https://thelounge.chat]
lemourin has joined #ffmpeg-devel
<Lynne> nice, I'm guessing binary size didn't change much as it's just context management?
<mkver> I did not touch the big stuff yet; shall I do it or do you want to?
<Lynne> I'd like to, that's what I started doing
<mkver> Ok. Good night.
jamrial has quit []
cone-068 has quit [Quit: transmission timeout]
mkver has quit [Ping timeout: 260 seconds]
AbleBacon has quit [Read error: Connection reset by peer]
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
zsoltiv_ has quit [Ping timeout: 272 seconds]
kekePower has quit [Ping timeout: 255 seconds]
Martchus_ has quit [Ping timeout: 268 seconds]
Martchus has joined #ffmpeg-devel
Traneptora_ has quit [Ping timeout: 256 seconds]
Traneptora_ has joined #ffmpeg-devel
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
kekePower has joined #ffmpeg-devel
marcj has quit [Ping timeout: 264 seconds]
kurosu has joined #ffmpeg-devel
marcj has joined #ffmpeg-devel
Poorvagaikar2003 has joined #ffmpeg-devel
MisterMinister has quit [Ping timeout: 240 seconds]
Poorvagaikar2003 has quit [Ping timeout: 256 seconds]
BetweenUs has joined #ffmpeg-devel
ngaullier has joined #ffmpeg-devel
nevcairiel has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
cone-747 has joined #ffmpeg-devel
<cone-747> ffmpeg Zhao Zhili master:90bbe1e8e2d3: avutil/hwcontext: Don't assume device_uninit is reentrant
<cone-747> ffmpeg Zhao Zhili master:39a0c5534707: fftools/ffplay: Fix output color_spaces of filter
<cone-747> ffmpeg Zhao Zhili master:6f9730cb2847: avutil/hwcontext_vulkan: Fix leaks when semaphore creation fails
<cone-747> ffmpeg Zhao Zhili master:3bb00c0a420c: avutil/hwcontext: Don't assume frames_uninit is reentrant
<cone-747> ffmpeg Zhao Zhili master:03275b0f0932: avutil/hwcontext_vulkan: Fix leaks in map_from_drm
<cone-747> ffmpeg Zhao Zhili master:74e27d9e3182: avutil/hwcontext_vulkan: Fix memleaks when transfer to vulkan
<cone-747> ffmpeg Zhao Zhili master:f6f06fb42ade: avutil/vulkan: avoid overreads in ff_vk_count_images
<cone-747> ffmpeg Zhao Zhili master:ab8aab5e2f40: avfilter/vf_scale_vulkan: Fix typo
<cone-747> ffmpeg Zhao Zhili master:b56b343e43e5: avformat/mov: Update bits_per_coded_sample after read pcmC
<cone-747> ffmpeg Zhao Zhili master:35dc12994024: avcodec/encode: Fix default setting of bits_per_raw_sample
<cone-747> ffmpeg Zhao Zhili master:dcfc6089b1ea: avutil/hwcontext_opencl: Fix missing linesize when map from opencl
<cone-747> ffmpeg Zhao Zhili master:f7545e90dfda: avutil/hwcontext_opencl: Add map from Videotoolbox to OpenCL
nevcairiel has joined #ffmpeg-devel
rossy has quit [Quit: rossy]
rossy has joined #ffmpeg-devel
emersion has quit [Remote host closed the connection]
emersion has joined #ffmpeg-devel
mkver has joined #ffmpeg-devel
courmisch has quit [Ping timeout: 252 seconds]
courmisch has joined #ffmpeg-devel
<stevenliu> Good morning folks, pengfei zhu has sent a email to ffmpeg-sample, cloud you see that? or how should he do next step?
<mkver> stevenliu: What sample? How big is it?
<stevenliu> mkver, can very small, just used for test enhanced flv hdr functions.
<mkver> Do we really need a sample for that? I thought the flv muxer supports enhanced flv.
<stevenliu> need create an hevc file with hdr sidedata, remux to enhanced flv in fate.
<mkver> Don't we already have an hevc file with this side data in fate?
<JEEB> we have
<JEEB> otherwise the FATE tests I added in my encoder side data patch wouldn't work :)
<JEEB> $(TARGET_SAMPLES)/hevc/hdr10_plus_h265_sample.hevc
<JEEB> is the randon one I used
<JEEB> there are other ones with CLL and MDCV, but this does include them
<stevenliu> Ah, maybe i describe wrong, it cannot be get in format, but it can be get in avframe
jamrial has joined #ffmpeg-devel
<JEEB> also there's the recently uploaded sample that has MDCV and CLL in both container and codec
<JEEB> although the codecpar should have that info too, no?
<JEEB> since I'd expect the avformat probe of that file to expose it
<JEEB> but if not, that recent sample should work, too
<mkver> That recent sample which want to be replaced...
<stevenliu> Ah, maybe i describe wrong, it cannot be get in avpacket, yes can get in codecpar, but there have no masteringdisplaydata
<mkver> mxf/Meridian-Apple_ProResProxy-HDR10.mxf seems to be the only file with matstering display metadata atm. It is ProRes.
<mkver> (This does not account for mastering display metadata in the bitstream.)
<stevenliu> 1. The code needs to verify the logic of the new code (simplified AV_PKT_DATA_MASTERING_DISPLAY_METADATA)
<stevenliu> 2. First, you need to construct the hdr meta information (sidedata) containing #1
<stevenliu> 3. flv demuxer is obtained through VideoTag analysis, so theoretically it needs to be added to flv muxer
<stevenliu> 4. Complete #3 in flv muxer is to read the coded_side_data of AVCodecParameters and then write
<stevenliu> av_packet_side_data_get(par->coded_side_data, par->nb_coded_side_data,
<stevenliu> AV_PKT_DATA_MASTERING_DISPLAY_METADATA);
<stevenliu> 5. In the development stage, in order to implement #4, I am modifying the local code. The muxer for mov mkv is written to side_data to produce a flv file.
<stevenliu> Via the command line ./ffmpeg -i *** -metadata:s:v **.mkv
<stevenliu> 6. When implementing the fate use case, I found that if mov demuxer wants to write side_data, it reads and writes through mkv_parse_video_color; I temporarily did not find the data source with MasteringMeta in the sample on the official website, so the data of #5 was not constructed.
<stevenliu> The idea is to construct a data similar to #5, but it is not constructed with existing data.
<stevenliu> ~
<mkver> The mov demuxer surely does not use mkv_parse_video_color.
<stevenliu> :qa!
<stevenliu> s/mov/mkv/g
<Lynne> "libavcodec/aac/%.o: CPPFLAGS += -I$(SRC_PATH)/libavcodec/", that's a nice trick
<mkver> It unfortunately does not work for headers.
<mkver> Lynne: It does not work for file in libavcodec/ including headers from libavcodec/aac (because the -I in use is only for the files in the subfolder). If all files including aacdec_tab.h were to be moved into the subfolder, it would work (even when checking the header).
rvalue has joined #ffmpeg-devel
lexano has joined #ffmpeg-devel
kurosu has quit [Quit: Connection closed for inactivity]
<mkver> jamrial: https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/x86/vvc/vvcdsp_init.c#L39 Wouldn't it be better to modify the underlying ASM function to receive the parameter corresponding to 2 * MAX_PB_SIZE as last parameter (same for HEVC)?
kekePower has quit [Quit: The Lounge - https://thelounge.chat]
kekePower has joined #ffmpeg-devel
<jamrial> mkver: if it removes that wrapper, then sure
<mkver> No, I meant because inserting an argument in the middle of other arguments is more work than inserting it at the end.
<mkver> (HEVC and VVC use different values for the dst_stride parameter.)
cone-747 has quit [Quit: transmission timeout]
<Lynne> mkver: yeah, I figured, not sure if I like needing to address 2 include namespaces individuall than just splitting them up
<Lynne> the fact that channel element mapping is fixed/float specific now makes deduplication difficult, as everything tries to adjust element mapping at some point
BetweenUs has quit [Quit: Leaving]
Guest48 has joined #ffmpeg-devel
Guest48 is now known as zhupengfei
zhupengfei is now known as zhupengfei08
kurosu has joined #ffmpeg-devel
Traneptora_ has quit [Ping timeout: 240 seconds]
briano has joined #ffmpeg-devel
briano has quit [Remote host closed the connection]
microchip_ has quit [Quit: There is no spoon!]
microchip_ has joined #ffmpeg-devel
AbleBacon has joined #ffmpeg-devel
<zhupengfei08> Hi mkver,  stevenliu:  Please ignore #5 #6, there is something wrong with my description.
<zhupengfei08> I need a video file containing type AV_PKT_DATA_MASTERING_DISPLAY_METADATA(AVPacketSideData) to complete the lavf-container test case, but I did not find a suitable file in the fate suite, so I based on the "multimedia/ffmpeg/fate-suite/hevc/hdr10_plus_h265_sample.hevc" through mov_write_mdcv_tag fake ***.mp4 are used for testing.
<elenril> zhupengfei08: mkv/hdr10tags-both.mkv has it
<JEEB> right, that was the name of the sample I wanted to refer to :)
<elenril> but note that it's currently affected by https://trac.ffmpeg.org/ticket/10857
<JEEB> elenril: but mkver said that someone wanted to change that sample or something?
<JEEB> > < mkver> That recent sample which want to be replaced...
<elenril> why?
<JEEB> ok, then my understanding was correct :)
<JEEB> so there were no such plans to change that sample
<zhupengfei08> Thanks,  I don’t have this file locally. Is it the latest upload? I’ll try updating it.
<JEEB> yea, do a make fate-rsync SAMPLES=/path/to/fate-suite/
<elenril> it was added a few days ago
<mkver> elenril: In order to improve the sample (with e.g. container rotation metadata).
<elenril> for what purpose?
<mkver> To improve coverage.
<elenril> I mean why does it need to be the same sample?
<elenril> and don't we have a container rotation sample already?
<mkver> We have no sample with rotation+flip.
<JEEB> thankfully the cli can set that now
<JEEB> since Thilo I think merged one of the versions of my patch set
<mkver> With flip?
<JEEB> let me double check
<mkver> JEEB: Looking at add_display_matrix_to_stream, the answer seems to be yes.
<JEEB> yup
<JEEB> I recalled I added most of the stuff in display matrix
zhupengfei08 has quit [Quit: Client closed]
Poorvagaikar2003 has joined #ffmpeg-devel
<JEEB> elenril: can you check if https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=10958 offends you?
<JEEB> I think at this point jamrial is OK with it
<elenril> yes, I have that set in my inbox
<JEEB> (I will have to add minor bumps in avcodec and avutil when merging it)
<JEEB> alrighty
<elenril> just finished some work I was late on, so should have time to review soonish
<JEEB> cheers
hamzah has joined #ffmpeg-devel
cone-857 has joined #ffmpeg-devel
<cone-857> ffmpeg Anton Khirnov master:e48055fdcece: fftools/ffmpeg: remove options deprecated before 6.0
Poorvagaikar2003 has quit [Ping timeout: 268 seconds]
hamzah has quit [Ping timeout: 250 seconds]
<cone-857> ffmpeg Anton Khirnov master:105a1bc1502e: lavu/opt: cosmetics, change option flags to (1 << N) style
<cone-857> ffmpeg Anton Khirnov master:39a3a1c69bed: lavu/opt: cosmetics, move AV_OPT_FLAG_* out of AVOption
<cone-857> ffmpeg Anton Khirnov master:067fde49662c: lavu/opt: document AVOption.flags
<cone-857> ffmpeg Anton Khirnov master:cc0bd9da7084: lavu/opt: cosmetics, group (un)init and management functions together
<cone-857> ffmpeg Anton Khirnov master:2a3a33d04b75: lavu/opt: cosmetics, group option setting function together
<cone-857> ffmpeg Anton Khirnov master:6456dd50a688: lavu/opt: cosmetics, group option reading function together
<cone-857> ffmpeg Anton Khirnov master:8904f351332d: lavu/opt: simplify printing option type in opt_list()
<cone-857> ffmpeg Anton Khirnov master:333cc9bff846: lavu/opt: factor out printing option default from opt_list()
<cone-857> ffmpeg Anton Khirnov master:9fabdd64b2cd: lavu/opt: drop useless handling of NULL return from get_bool_name()
<cone-857> ffmpeg Anton Khirnov master:84ba46fa5ebc: lavu/opt: drop an always-NULL argument to get_number()
<cone-857> ffmpeg Anton Khirnov master:1ffa657a0347: lavu/opt: simplify error handling in get_number()
<cone-857> ffmpeg Anton Khirnov master:200f82e3f807: lavu/opt: get rid of useless read_number() calls
Poorvagaikar2003 has joined #ffmpeg-devel
hamzah has joined #ffmpeg-devel
<mkver> BtbN: Ping regarding testing https://github.com/mkver/FFmpeg/tree/hwcontextinternal
<BtbN> ah, will do now!
<BtbN> Anything specific to test, or just "it builds and I can still transcode"?
<mkver> (I rebased the branch on top of current master in light of Zhao's commits.)
<mkver> Nothing specific.
<mkver> I could only test VAAPI.
<BtbN> It builds without warnings and runs perfectly fine.
<mkver> Thanks. Then I'll push the cuda patches.
deus0ww has quit [Ping timeout: 260 seconds]
deus0ww has joined #ffmpeg-devel
hamzah has quit [Ping timeout: 250 seconds]
Poorvagaikar2003 has quit [Ping timeout: 256 seconds]
<Lynne> kierank: what other things do you not like in avtransport apart from the non-global FEC?
ngaullier has quit [Ping timeout: 264 seconds]
<cone-857> ffmpeg Andreas Rheinhardt master:cb92b4bd835c: avutil/hwcontext: Clarify documentation of AVHWFramesContext.hwctx
<cone-857> ffmpeg Andreas Rheinhardt master:8d277de009c1: avutil/hwcontext_cuda: Don't use AVHWFramesInternal.priv
<cone-857> ffmpeg Andreas Rheinhardt master:ac7e72972c4e: avutil/hwcontext_cuda: Allocate public and internal device ctx jointly
<elenril> JEEB: can we have less java in function names?
<elenril> super_long_names_in_natural_language_are_very_annoying_to_read
<JEEB> I don't even think of java
<JEEB> also I used stuff like from_sd etc IIRC
<elenril> very long names are a hallmark of java, in my impression at least
<JEEB> just sync up with jamrial so that I won't end up going here & back, and then just tell me what you want. at this point this patch set has been around for way too long :V
<JEEB> and thanks for taking a look at it
<elenril> I'll send something more specific to the ML once I've read through it
<JEEB> roger
<elenril> this is just something that annoys me in most of the patches
<elenril> I generally prefer <object>_<action> when possible/applicable
<JEEB> yea the last changes to names happened when I finally got the brain strength to rebase & rewrite it at all from the set struct to an array and length arguments which at point of v6 jamrial wanted
<JEEB> I am happy enough that I got to that point
<JEEB> but most of the naming style was from the previous iteration where IIRC you also voiced in
<jamrial> i don't find the names wrong
<jamrial> av_frame_side_data_ is the namespace. then from_{sd,buf} is as short as it gets
<elenril> I'm not talking about these
<elenril> but things like add_side_data_to_set_from_buf
<jamrial> ah
<jamrial> the "to_set" part is a remnant from previous versions it seems
<JEEB> yea, it'd be to_array now
<JEEB> (or if the context is clear, just without to_xyz
<elenril> side_data_add_from_buf()
<elenril> little endian naming is godly
<Sean_McG> javaUsuallyUsesCamelCaseMrElenril()
<cone-857> ffmpeg Andreas Rheinhardt master:2d63379cae59: avutil/hwcontext_vulkan: Allocate public and priv device hwctx together
<cone-857> ffmpeg Andreas Rheinhardt master:e70e9b655426: avutil/hwcontext_vulkan: Allocate pub and priv frames hwctx together
<elenril> mkver: do you remember why does mpegts.c need avcodec.h? (2b41463b8706638b9aaf967655f95ddc195c32eb)
<elenril> it seems to compile without it
<mkver> avcodec_is_open, removed in 0d54ae40123ef8dbf77210faf1edbeacc121854e
<elenril> ah
MisterMinister has joined #ffmpeg-devel
facefamousee has joined #ffmpeg-devel
microchip_ is now known as OfficerPendejo
marcj has quit [Ping timeout: 255 seconds]
hamzah has joined #ffmpeg-devel
microchip_ has joined #ffmpeg-devel
OfficerPendejo has quit [Ping timeout: 260 seconds]
microchip_ is now known as OfficerPendejo
OfficerPendejo has quit [Quit: There is no spoon!]
microchip_ has joined #ffmpeg-devel
hamzah has quit [Quit: Client closed]
dykai has joined #ffmpeg-devel
dionisis has quit [Ping timeout: 256 seconds]
dykai has quit [Ping timeout: 264 seconds]
hamzah has joined #ffmpeg-devel
Krowl has joined #ffmpeg-devel
loltweyz has joined #ffmpeg-devel
loltweyz has quit [Remote host closed the connection]
hamzah has quit [Quit: Client closed]
jamrial has left #ffmpeg-devel [#ffmpeg-devel]
jamrial has joined #ffmpeg-devel
<jamrial> JEEB: i like elenril's suggestion. _from_sd -> _clone(), and then you can do _from_buf() -> _add()
<JEEB> ok. I will soon take a look at the comments and attempt to apply them
facefamousee has quit [Quit: KVIrc 5.2.0 Quasar http://www.kvirc.net/]
<jdek> elenril: if c11 is a req now can we use _Generic
iive has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
<Lynne> yes, just not in public headers
cone-857 has quit [Quit: transmission timeout]
microchip_ has quit [Quit: There is no spoon!]
microchip_ has joined #ffmpeg-devel
darkapex has quit [Remote host closed the connection]
darkapex has joined #ffmpeg-devel
user23 has joined #ffmpeg-devel
elastic_dog has quit [Ping timeout: 268 seconds]
elastic_dog has joined #ffmpeg-devel
microchip_ has quit [Quit: There is no spoon!]
microchip_ has joined #ffmpeg-devel
microchip_ has quit [Client Quit]
microchip_ has joined #ffmpeg-devel
<JEEB> went through patch #5, I hope there are no comments going the opposite way for the same thing later in the set :P
<JEEB> elenril: > These extra blocks are ugly.
<JEEB> but you cannot do AVBufferRef *buf = av_buffer_ref(src->buf); after a sanity check without them
<JEEB> and defining a variable and initializing it to the final value should generally be the best way :P
<JEEB> also wtf @ removing by the pointer is ugly
<JEEB> this fucking went through how many revisions of the patch set >:|
<JEEB> ok, not reworking this at least tonight.
<JEEB> did the stuff noted in patch #5 at least
microchip_ has quit [Quit: There is no spoon!]
microchip_ has joined #ffmpeg-devel
<JEEB> (and don't get me wrong, I'm thankful for reviews but at the point of doing `git checkout -b avcodec_cll_mdcv_side_data_v8` I was kind of hoping that maybe some docstring updates and renames
<JEEB> but noope
<JEEB> because my next step would have been making the supported-by-module side data stuff listable and then visible via `ffmpeg -h encoder=libx264`
<jamrial> i only suggested renames
<JEEB> yea
<jamrial> the "Removing by the pointer is ugly" stuff is internal, so it could be changed later if you want to not deal with it now
microchip_ has quit [Quit: There is no spoon!]
microchip_ has joined #ffmpeg-devel
microchip_ has quit [Client Quit]
microchip_ has joined #ffmpeg-devel
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
jarthur has joined #ffmpeg-devel
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
mkver has quit [Ping timeout: 256 seconds]
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
Gramner has quit [Ping timeout: 246 seconds]