dustymabe changed the topic of #fedora-coreos to: Fedora CoreOS :: Find out more at https://getfedora.org/coreos/ :: Logs at https://libera.irclog.whitequark.org/fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
daMaestro has joined #fedora-coreos
plarsen has quit [Remote host closed the connection]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 244 seconds]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
<dustymabe> LakshmiRavichand: can you review https://github.com/coreos/fedora-coreos-config/pull/1766 when you're available?
jlebon has quit [Ping timeout: 244 seconds]
jlebon has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
jlebon has quit [Ping timeout: 258 seconds]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
cyberpear has quit [Quit: Connection closed for inactivity]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
jlebon has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
paragan has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
daMaestro has quit [Ping timeout: 244 seconds]
fdavidg has joined #fedora-coreos
daMaestro has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
saqali has quit [Quit: Leaving]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
jpn has joined #fedora-coreos
daMaestro has quit [Quit: Leaving]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
gursewak has quit [Ping timeout: 276 seconds]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
gursewak has joined #fedora-coreos
jpn has quit [Quit: leaving]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
ksinny has joined #fedora-coreos
Betal has quit [Quit: WeeChat 3.5]
gursewak has quit [Ping timeout: 256 seconds]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
tormath1 has joined #fedora-coreos
jcajka has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
mnguyen has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
mnguyen_ has quit [Ping timeout: 252 seconds]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
jpn has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
crobinso has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
jpn has quit [Ping timeout: 240 seconds]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 260 seconds]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 246 seconds]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
jpn has joined #fedora-coreos
mheon has joined #fedora-coreos
jpn has quit [Ping timeout: 246 seconds]
plarsen has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
<dustymabe> LakshmiRavichand: let me know if you have any questions about https://github.com/coreos/fedora-coreos-pipeline/pull/525/files#r887949129
fdavidg has joined #fedora-coreos
jpn has joined #fedora-coreos
plarsen has quit [Ping timeout: 246 seconds]
tormath1 has quit [Remote host closed the connection]
tormath1_ has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
nalind has joined #fedora-coreos
<dustymabe> jlebon: got a moment to chat about a preferred solution to a simple problem?
<jlebon> have a meeting in 12 mins, so if it's less than that, yes :)
<dustymabe> it is
<jlebon> sure
<dustymabe> jlebon: so NM started including a file in their RPM (text file explaining things) in /etc/sysconfig/network-scripts/readme-ifcfg-rh.txt
<dustymabe> but our logic breaks because we assume if anything exists in that directory someone provided net configuration via Ignition
<dustymabe> we have two options
<jlebon> right
<dustymabe> remove the file (it's cosmetic) in the manifest
<dustymabe> remove-from-packages:
<dustymabe> - [NetworkManager, /etc/sysconfig/network-scripts/readme-ifcfg-rh.txt]
mnguyen_ has joined #fedora-coreos
<dustymabe> or modify our logic to not look at that directory on FCOS (we already don't support it anyway)
<dustymabe> so we'd have to do some sort of if FCOS do this, if RHCOS do that
<dustymabe> also +1 for tests - which told us about this as soon as it entered rawhide and broke our assumptions
<jlebon> i guess it'd be making that -o become e.g. -o ( -n "$(ls -A ...)" -a -n "${ON_FEDORA}" or something
mnguyen has quit [Ping timeout: 246 seconds]
<jlebon> personally i'd prefer modifying our logic vs remove-from-packages
fdavidg has quit [Remote host closed the connection]
<jlebon> i think the barrier for resorting to remove-from-packages should be a bit higher
fdavidg has joined #fedora-coreos
<dustymabe> yeah
<jlebon> like, ideally i'd prefer we don't use remove-from-packages at all
<jlebon> and work with package maintainers if it's really something we can't work around
<dustymabe> I agree. the only thing that gives me pause is if they start shipping this file on RHEL
<dustymabe> in which case we'll be back in the same position
<dustymabe> because we DO support ifcfg files there
<jlebon> in that case, maybe instead of fedora vs rhcos, we filter out .txt files
<jlebon> we should probably do that anyway because of c9s
<lucab> `grep -v readme*.txt` maybe?
<dustymabe> yeah that could work
<dustymabe> ok cool. I have a direction to go anyway
<jlebon> +1
<jlebon> just in time for my meeting :)
<dustymabe> saqali - mind a review on https://github.com/coreos/coreos-assembler/pull/2894
saqali has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
<dustymabe> jlebon: lucab: per our discussion: https://github.com/coreos/fedora-coreos-config/pull/1767
<dustymabe> which should get rawhide building again
mnguyen has joined #fedora-coreos
mnguyen_ has quit [Ping timeout: 276 seconds]
<dustymabe> hey walters - do you think we could get a new ostree release soon - there are some s390x fixes that will enable us to test ostree operations again
<dustymabe> I guess another option is to backport the fixes
fdavidg has quit [Remote host closed the connection]
<dustymabe> jlebon: https://github.com/coreos/fedora-coreos-config/pull/1767#discussion_r888078964 - you have to convince me before the "auto merge" timer runs out :)
fdavidg has joined #fedora-coreos
paragan has quit [Quit: Leaving]
gursewak has joined #fedora-coreos
saqali_ has joined #fedora-coreos
<jlebon> dustymabe: don't feel strongly about it. just seems like we'd want to ignore all txt files anyway and it's shorter :)
saqali has quit [Ping timeout: 246 seconds]
<dustymabe> yeah. let's start with this and if they add more we can adjust
<dustymabe> the good news is it's easy to adjust
jcajka has quit [Quit: Leaving]
jpn has quit [Quit: Lost terminal]
saqali__ has joined #fedora-coreos
plarsen has joined #fedora-coreos
saqali_ has quit [Ping timeout: 256 seconds]
plarsen has quit [Remote host closed the connection]
plarsen has joined #fedora-coreos
tormath1_ has quit [Ping timeout: 240 seconds]
tormath1 has joined #fedora-coreos
tormath1 has quit [Ping timeout: 240 seconds]
mnguyen_ has joined #fedora-coreos
mnguyen has quit [Ping timeout: 255 seconds]
plarsen has quit [Remote host closed the connection]
tormath1 has joined #fedora-coreos
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 276 seconds]
tormath1 has quit [Quit: leaving]
jpn has joined #fedora-coreos
<dustymabe> jlebon: for https://github.com/coreos/coreos-assembler/pull/2898 did you test that? I tried the other day with a small script and the bash script always gave me a bad exit code with errexit
<dustymabe> I think I was testing something like `/bin/false && echo foo`
<dustymabe> jlebon: hmm. just wondering what I was doing wrong in the script that I wrote
<dustymabe> jlebon: did you happen to see https://github.com/coreos/coreos-assembler/issues/2884 :)
<jlebon> dustymabe: hah nice. hadn't seen it. i'll dig into this more later, currently in a mtg.
bgilbert has joined #fedora-coreos
<jlebon> dustymabe: try adding `true` in `foo()`
<jlebon> the return code for `foo` is of the last command
<jlebon> so the command did fail, but `-e` had no effect
<dustymabe> my script works as I expect - it gets to false and stops
<dustymabe> what I didn't understand is why the make && make_install wasn't doing the same
<jlebon> cosa has that `rm -rf` command which has the same function as `true` in my example
<dustymabe> thanks for that
<dustymabe> bgilbert: are we good on https://github.com/coreos/coreos-assembler/pull/2400#issuecomment-1143825700 ? If so I'll make sure my patch still applies and try to test it
<jlebon> +1 yeah, sometimes you just gotta RTFM :)
<dustymabe> saqali__: mind stamping https://github.com/coreos/coreos-assembler/pull/2894 again - I rebased
<saqali__> stamped
saqali__ is now known as saqali
jpn has quit [Ping timeout: 246 seconds]
ksinny has quit [Remote host closed the connection]
<bgilbert> dustymabe: yup, go for it!
<dustymabe> bgilbert: +1
Betal has joined #fedora-coreos
<dustymabe> if all is well do we want to merge that soon? from what I understand it should be innocuous without a platforms.yaml?
<dustymabe> i.e. we can merge it even without the notice + waiting period
<dustymabe> brb
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
jpn has joined #fedora-coreos
<dustymabe> does this frustrate anyone else about our initrd? https://paste.centos.org/view/1f7553dc]
<davdunc[m> should update it to nano 🙃
<dustymabe> na no
<dustymabe> :)
<dustymabe> nope
<dustymabe> this is just a bug in dracut TBH
<dustymabe> ahh found it
<davdunc[m> isn't that by design?
<dustymabe> davdunc[m: what?
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
jpn has quit [Ping timeout: 246 seconds]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
<davdunc[m> dustymabe: nano replacement, I meant.
<dustymabe> davdunc[m: yeah I don't think so.. it's because vi is a shell script that then executes /usr/libexec/vi (which dracut doesn't properly ID the dep for)
gursewak_ has joined #fedora-coreos
gursewak has quit [Ping timeout: 276 seconds]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 244 seconds]
cyberpear has joined #fedora-coreos
saqali has quit [Quit: Leaving]
<davdunc> Aha. Did not know that.
mheon has quit [Ping timeout: 246 seconds]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 255 seconds]
nalind has quit [Quit: bye]
gursewak_ has quit [Ping timeout: 255 seconds]
gursewak_ has joined #fedora-coreos
crobinso has quit [Ping timeout: 244 seconds]
fdavidg has quit [Remote host closed the connection]
fdavidg has joined #fedora-coreos