ikarso has quit [Quit: Connection closed for inactivity]
memset_ has joined #u-boot
memset has quit [Ping timeout: 260 seconds]
Jones42_ has joined #u-boot
Jones42 has quit [Ping timeout: 252 seconds]
alpernebbi has quit [Ping timeout: 252 seconds]
jclsn has quit [Ping timeout: 258 seconds]
jclsn has joined #u-boot
alpernebbi has joined #u-boot
memset has joined #u-boot
memset_ has quit [Ping timeout: 260 seconds]
joeskb7 has quit [Quit: Lost terminal]
memset has quit [Remote host closed the connection]
memset has joined #u-boot
joeskb7 has joined #u-boot
vagrantc has joined #u-boot
atka has joined #u-boot
gsz has joined #u-boot
naoki has joined #u-boot
Clamor has joined #u-boot
goliath has joined #u-boot
naoki has quit [Ping timeout: 260 seconds]
naoki1 has joined #u-boot
naoki1 is now known as naoki
sukrutb has quit [Ping timeout: 272 seconds]
naoki has quit [Ping timeout: 245 seconds]
gsz has quit [Ping timeout: 272 seconds]
mmu_man has joined #u-boot
atka has quit [Ping timeout: 264 seconds]
atka has joined #u-boot
alpernebbi has quit [Ping timeout: 252 seconds]
alpernebbi has joined #u-boot
enok has joined #u-boot
sukrutb has joined #u-boot
Clamor has quit [Ping timeout: 252 seconds]
Clamor has joined #u-boot
enok has quit [Ping timeout: 276 seconds]
Cityjohn_ has joined #u-boot
enok has joined #u-boot
enok has quit [Client Quit]
enok has joined #u-boot
vagrantc has quit [Quit: leaving]
enok has quit [Ping timeout: 258 seconds]
sukrutb has quit [Ping timeout: 252 seconds]
frieder has joined #u-boot
warpme has joined #u-boot
atka has quit [Ping timeout: 260 seconds]
atka has joined #u-boot
Cityjohn_ has quit [Ping timeout: 264 seconds]
ldevulder has joined #u-boot
Cityjohn_ has joined #u-boot
Cityjohn_ has quit [Ping timeout: 258 seconds]
Cityjohn_ has joined #u-boot
Cityjohn_ has quit [Ping timeout: 272 seconds]
warthog9 has quit [Remote host closed the connection]
warthog9 has joined #u-boot
Cityjohn_ has joined #u-boot
haritzondo is now known as haritz
haritz has quit [Changing host]
haritz has joined #u-boot
Perflosopher has quit [Ping timeout: 264 seconds]
Perflosopher has joined #u-boot
naoki has joined #u-boot
Cityjohn_ has quit [Ping timeout: 248 seconds]
atka has quit [Ping timeout: 276 seconds]
Cityjohn_ has joined #u-boot
naoki has quit [Quit: naoki]
<mwalle>
regarding USB gadget support, it seems that u-boot is grabbing the UDC during startup if the usb ether gadget is enabled. The fastboot command and the ums command won't work then until the user will unbind the ethernet device. Is that how it's supposed to be?
gsz has joined #u-boot
slobodan has quit [Read error: Connection reset by peer]
slobodan has joined #u-boot
slobodan has quit [Remote host closed the connection]
slobodan has joined #u-boot
Cityjohn_ has quit [Remote host closed the connection]
Cityjohn_ has joined #u-boot
frieder has quit [Remote host closed the connection]
Cityjohn_ has quit [Ping timeout: 260 seconds]
persmule has quit [Ping timeout: 260 seconds]
xypron has quit [Ping timeout: 255 seconds]
alpernebbi has quit [Ping timeout: 276 seconds]
Cityjohn_ has joined #u-boot
persmule has joined #u-boot
alpernebbi has joined #u-boot
warpme has quit [Ping timeout: 264 seconds]
ikarso has joined #u-boot
Cityjohn_ has quit [Ping timeout: 252 seconds]
warpme has joined #u-boot
warpme has quit [Read error: Connection reset by peer]
<marex>
mkorpershoek: they need to fix the controller driver, not undo valid progress forward to
<marex>
"
<marex>
this now behaves like running either 'ums' or 'dfu' or any other commands utilizing USB gadget functionality.
<marex>
"
<mkorpershoek>
urgh
<mkorpershoek>
do you have more specifics about "fix the controller driver" ? I would reproduce the described problem on VIM3 as well (so using a different controller)
<mkorpershoek>
marex: could you chime in on the patch thread ?
frieder has joined #u-boot
frieder has quit [Ping timeout: 252 seconds]
<marex>
mkorpershoek: I have it on my list of things ...
<marex>
mkorpershoek: I just didn't get to it yet
<marex>
mkorpershoek: regarding fixing the driver -- you are supposed to use 'bind' command to bind the g_ether to UDC controller, then it shows up in 'net list' too, and then you can use it
<marex>
the start callback simply starts the controller, but at that point it was already registered
<mkorpershoek>
ok
<mkorpershoek>
I'll look into it Thursday
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
frieder has joined #u-boot
Hypfer6 has quit [Ping timeout: 252 seconds]
Hypfer6 has joined #u-boot
Cityjohn_ has joined #u-boot
Clamor has joined #u-boot
Cityjohn_ has quit [Ping timeout: 252 seconds]
goliath has quit [Quit: SIGSEGV]
Cityjohn_ has joined #u-boot
dsimic has quit [Ping timeout: 260 seconds]
dsimic has joined #u-boot
Cityjohn_ has quit [Remote host closed the connection]
Cityjohn_ has joined #u-boot
Cityjohn_ has quit [Ping timeout: 258 seconds]
Cityjohn_ has joined #u-boot
Stat_headcrabed has joined #u-boot
frieder has quit [Remote host closed the connection]
<marex>
mkorpershoek: I believe the original code was correct and the Atmel UDC driver should be fixed instead
vagrantc has joined #u-boot
atka has joined #u-boot
Cityjohn_ has quit [Ping timeout: 260 seconds]
<mkorpershoek>
marex: and so does the dwc2 UDC driver? because I reproduced the issue on VIM3
<mkorpershoek>
or maybe that's because I tested usb_ether_init(); instead of running the 'bind' command
<marex>
mkorpershoek: usb_ether_init() is the board-file thing ?
<mkorpershoek>
yes
<marex>
mkorpershoek: that must be removed
<mkorpershoek>
(I added it for testing purposes, it's not in master)
<marex>
mkorpershoek: that does not work for multiple controllers , i.e. is not-really-DM
<marex>
mkorpershoek: bind command lets you select which controller to bind the g_ether to
<mkorpershoek>
Ok. so that's a deprecated, legacy way of testing usb ethernet gadget, which we should not support
<mkorpershoek>
Understood
<marex>
bind, while the interface is terrible, is the only way forward I think
<marex>
ums / dfu has nicer interface, but I don't think we want one command for each gadget
<marex>
that'd be horrid too
<marex>
so ... bind
<mwalle>
marex: I'm fixing the sunxi musb-new driver to be DM compatible at the moment. not sure where the bind of the ethernet happens though
<mkorpershoek>
do you happen to have a "bind" example for USB ethernet somewhere from your bash_history? I feel that we should document this (and I will do it)
<mkorpershoek>
The contributor that send this fix also updated the Atmel driver to be DM so he should probably be able to get his use-case working by using 'bind'
<mkorpershoek>
I agree, we don't want one command for each gadget
<marex>
that's for dwc2/stm32mp15xx
<mkorpershoek>
thank you!
rvalue- has joined #u-boot
rvalue has quit [Ping timeout: 248 seconds]
<mwalle>
marex: nvm, usb_ether_init()
rvalue- is now known as rvalue
warpme has joined #u-boot
kabel1 is now known as kabel
<marex>
mwalle: please do not add any more usb_ether_init , use the bind command
alpernebbi has quit [Ping timeout: 255 seconds]
goliath has joined #u-boot
alpernebbi has joined #u-boot
mmu_man has quit [Ping timeout: 252 seconds]
memset has quit [Remote host closed the connection]
memset has joined #u-boot
warpme has quit [Remote host closed the connection]
warpme has joined #u-boot
mckoan is now known as mckoan|away
<mwalle>
marex: yes i got that, I was just puzzled where the usb ethernet gadget was probed and that was in board_init_late() in the sunxi board (via usb_ether_init())
<mkorpershoek>
marex: thanks for catching this. I've contacted the contributor
ikarso has quit [Quit: Connection closed for inactivity]
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
warpme has joined #u-boot
<marex>
mkorpershoek: thanks
<marex>
mwalle: huh ... which should be switched I guess to some PREBOOT bind command use
warpme has quit [Client Quit]
warpme has joined #u-boot
rockosov has quit [Read error: Connection reset by peer]
warpme has quit [Client Quit]
warpme has joined #u-boot
warpme has quit [Client Quit]
slobodan has quit [Read error: Connection reset by peer]
warpme has joined #u-boot
warpme has quit [Client Quit]
slobodan has joined #u-boot
warpme has joined #u-boot
zli has joined #u-boot
slobodan has quit [Read error: Connection reset by peer]
slobodan has joined #u-boot
goliath has quit [Quit: SIGSEGV]
mmu_man has joined #u-boot
<zli>
Hi Marek,
<zli>
I just read the messages about usb_ether. Do you mean in USB gadget driver probe the controller should keep disconnected,
<zli>
then usb_eth_start() will connect it with usb_gadget_connect() ? In this way gadget interrupts is always available.
<zli>
Simply replace usb_ether_init() by 'bind' will reduce the likehood of the issue but won't fix it, unless the timing between
<zli>
'bind' and actual usage (e.g 'dhcp') is guaranteed (5 seconds for request processing in USB 2.0 spec)
Clamor has quit [Ping timeout: 252 seconds]
Stat_headcrabed has quit [Quit: Stat_headcrabed]
mmu_man has quit [Ping timeout: 252 seconds]
<marex>
zli: please give me a few hours, I'll get back to you, sorry
ikarso has joined #u-boot
ldevulder has quit [Quit: Leaving]
mmu_man has joined #u-boot
<marex>
zli: the bind command does only trigger the .bind callback of a driver, not the .probe callback of a driver
<marex>
zli: the probe callback is only called upon first use, i.e. when the 'dhcp' command is issued
urja has quit [Read error: Connection reset by peer]
atka has quit [Ping timeout: 252 seconds]
urja has joined #u-boot
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
mmu_man has quit [Ping timeout: 264 seconds]
sukrutb has joined #u-boot
zli has joined #u-boot
zli has quit [Changing host]
jfsimon has quit [Ping timeout: 248 seconds]
<marex>
zli: the bind command does only trigger the .bind callback of a driver, not the .probe callback of a driver
<marex>
zli: the probe callback is only called upon first use, i.e. when the 'dhcp' command is issued
mmu_man has joined #u-boot
zli has quit [Quit: Client closed]
zli has joined #u-boot
zli has quit [Changing host]
zli has joined #u-boot
<zli>
marex: Thank you for your explanation, I missed the point bind won't call .probe
<zli>
marex: Should I push a patch to let controller disconnected in usba_udc_probe ?
<zli>
marex: Otherwise when the driver probing in 1st time 'net list' run the error will happen:usb 1-2: new high-speed USB device number 68 using xhci_hcdusb 1-2: device descriptor read/64, error -110
slobodan has quit [Read error: Connection reset by peer]
atka has joined #u-boot
ikarso has quit [Quit: Connection closed for inactivity]
naoki has joined #u-boot
goliath has joined #u-boot
<marex>
zli: yeah, I dont think you should be doing connect in probe
slobodan has joined #u-boot
<marex>
zli: shouldn't the UDC interrupt handling deal with connect/disconnect events (interrupts) ?
slobodan has quit [Client Quit]
gsz has quit [Ping timeout: 272 seconds]
ikarso has joined #u-boot
<zli>
marex: More precisely keeping pullup off in probe
enok has joined #u-boot
<marex>
zli: yep
enok has quit [Ping timeout: 244 seconds]
zli has quit [Read error: Connection reset by peer]
memset has quit [Remote host closed the connection]
memset has joined #u-boot
goliath has quit [Quit: SIGSEGV]
memset has quit [Remote host closed the connection]
memset has joined #u-boot
memset_ has joined #u-boot
memset has quit [Ping timeout: 260 seconds]
memset_ has quit [Remote host closed the connection]
memset has joined #u-boot
atka has quit [Ping timeout: 276 seconds]
ikarso has quit [Quit: Connection closed for inactivity]